From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDB3C433B4 for ; Thu, 13 May 2021 08:01:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC6A861185 for ; Thu, 13 May 2021 08:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC6A861185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hs5m21keChrCy6MknfOiFxvkMEsIcAJRAiu2S2MbBSs=; b=QiLcOPK0OktcHUgGrhybFPj69 PHbzGqVc/fg7fphUSd4l9qpK9YRMV2MuQUF+bA/8dcSm6FYjNmoMzb9XTLEnqtT5bRd6Qq2EcgaOP rbVWp12f0XV0zYMr9HkwHCOqmb6OBSa6R8SMBcsI9YmHO/5fxvaSy8+sC6QrZGizl0tSD7+UFGPFh vw+ZV9JMzLnuvp2llLDlWnapqcVpn+z+Gf6Opp8Ka5GQajhSHHe+jGqgJmy1OZ7yGBvXOlZdycXLc xidoYxLnA4YuPU9K9btSIUH44a97t9JQkViL8emX4RmGLappgVFYV+ljMhDgBN6YftwIwqBBrnoXc l5Fc5zoyA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lh6Fk-0053Cb-FK; Thu, 13 May 2021 07:59:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh6Fh-0053CN-GC for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 07:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Slych82+jWu/Wv9V6D4t0VFYlgr6l0qVOeeSnC9vwpY=; b=v4r72in5d0a2afdTl0p5itQkEK yK+R7bWqzX/iSELceKIx1c7TSAsWDXkr99vP5tZ7BRzwdJNYZp6Cje9SXOFXkhqv5Dioa1awXUL9+ h00K4kSVcMx5/JnyXYKmqWS7epT0Wg0wxb9Qjp9UDTJFzKoNjp1i0cbtVdStBO8iVYboreFty2mTU B2Kv3X2KRelnSerlCEU0X7M3TvgolwlCFsgcDrValPEt8+KWjAvmxuS7fuGkPQbFhEnLb8dsZDZPa P+7AaMoFYPqnB7OsoNuMUdG7OynkUQjHheLTVfSFpkOiQ1PsJWnnXeoeG9/bueI4/xBfHuvaqjS3F HQT1/H1Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh6Fe-00B5sL-V7 for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 07:59:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2160261439; Thu, 13 May 2021 07:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620892762; bh=iUrtpqFnXdmWdBcpzXp0Ri1xgecNKmB4qbJd7wPBrss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PZAFz5rA4Fgu/+xKLoQ9cK5gmvGLaj+7VPIKvDgCzPaTPu0EQEUFLQn7VQYtn3NPw Tb6QNmaDZ1rTbKNzCAyXjAa2IZxsmloOCKJz11ifsxYmfnLpA7QygLBkYIGE4PpjeG 5KkRNkPitFKNhOlQekQHiniqnZyS/r3yJkClZ1Sfr3QyWaiVzeni5ybfphdGoVwJlW pNCb1xvkqtUA8hjIEWeV6Un9mxaRcwKzcm3prz9GnP2znWJDNWXuiyqDqBoxNFjVqA fOzV6p/lIUjp8gzn+tqQRfWOFBqb/mv6HHyB0cNSEsjTNP+McmsuNyf8gC6c6Ql+hK PXewaizjDjFvQ== Date: Thu, 13 May 2021 15:59:17 +0800 From: Shawn Guo To: Mian Yousaf Kaukab Cc: leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node Message-ID: <20210513075917.GX3425@dragon> References: <20210428125807.29553-1-ykaukab@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210428125807.29553-1-ykaukab@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_005923_066522_DD10D7A9 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 28, 2021 at 02:58:07PM +0200, Mian Yousaf Kaukab wrote: > On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module > then its probe fails with the following warning: > > [ 10.471363] couldn't get idr > [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0 > ... > [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr > [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16 > > Reason for the failure is that bus-num property is set for dspi node. > However, bus-num property is not set for the qspi node. If probe for > spi-fsl-qspi happens first then id 0 is dynamically allocated to it. > Call to spi_register_controller() from spi-fsl-dspi driver then fails. > Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property > optional") bus-num property is optional. Remove bus-num property from > dspi node to fix the issue. > > Signed-off-by: Mian Yousaf Kaukab Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel