From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3F1C433B4 for ; Thu, 13 May 2021 13:38:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B17613AA for ; Thu, 13 May 2021 13:38:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49B17613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hNyd9ocoshyqU5C0dZ+Q8l536pgX47vhdiwErzNWKIg=; b=aVkqb7XKjt1hHPOzIT/pRhKz3 niqRAFYhTZj82Ylp0+f3dGjyQZJyfui/MQDS1edg2G13zGUF19NCJVFoRavX0V1N5WExd+iYQya8k PvT4tk0rZK1orqlcw3V/GKlXGITcggjBOSDCXGnq5fhdVPT7/+oRqEiJHJZE3hfrkhlpStoPMkZ13 DyWFQtia3zS01+oUJeUKyTL8NaWqE3Rj0EnayVtnLFOqF2yqHGN+Kl+nDZu30t8EDLb0bbinVahFG yxT/Cwl4Y2rgYgTokbUK15SwJrZdn/k2yPe2N4RGA1R78BWqN/x+U79icuwZVk21+jHhToRyyw0O9 1ZOePbsJw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhBUu-005cnu-Es; Thu, 13 May 2021 13:35:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhBUo-005cmy-Oi for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 13:35:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FvODNgacZTe1Ns5tmv1ZfroyGHnuKDk2vNSeHohTzes=; b=RbRnoGW91EZLDZR2Nq7QPvyB+N wPtUsZPa5cQ0CYeqOp7HT57kL03r0jMrd38jyDPrXD3Y6Xh387IhndiFuS4L7iPIdT39SLM9cxrTr uj6hNykaoLngylMlJCbA9z/KIIPB/NQSB0dBxLRaXhiqoRifEsIb8Wr9cEkF5BZoGwk6RnQ1Qm1Dq 5Egn8UNa58eyLxUhnVNfInrp5SAHwjMARz5/dPQO+tqS4M5KwyDNg3PaxvISCWWFuANar5wEG4la5 qg6N3O+rFhJRYav/rA/xUZguTxUmn9cHyQe+rQULyqgDhWIPYqWdB9zRBpQToToiUoqUuQo3Sz02y JqO+FuWw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhBUm-00BHMW-3p for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 13:35:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B81461363; Thu, 13 May 2021 13:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620912919; bh=HDpcTZC6Tjfu3QfZbpafDsghdkb70bSqEzahKtVZt1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tJlXnHCahMn0YaLqyDMkcKi4GQPk49ILMVwovOrO9Ts8P9VIJzrWWOhbiXgBX0v9u dHZn2M9pkVVWKkHXm5u8GNabxZJel3Jw97hjiyOMnifqKRMf/bgVys5B3g/qw9mNfs eVb2RtbGJA8Fe06BBCCI0Ky0dpdzq3JtHqmHivg9QzCJwYSEvENIPceJe8y4x64xfr 5kwyExHNH4yTy7rlz/aaNqP/mSC0Hez4UO/ci6upXSU5Rs4E2k2UiE1+rrLXaR+VN/ 6VFpearoKqpvoE1UQkAVOur411bjTKrx6PgFhi3vr1KkqIUO1kvMeL7h72v5uueHnk VjjE/CZReNGnw== Date: Thu, 13 May 2021 21:35:13 +0800 From: Shawn Guo To: Alistair Francis Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.co, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alistair23@gmail.com Subject: Re: [PATCH] ARM: imx7d-remarkable2.dts: Add WiFi support Message-ID: <20210513133512.GZ3425@dragon> References: <20210418210003.2806-1-alistair@alistair23.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210418210003.2806-1-alistair@alistair23.me> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_063520_238543_24728D61 X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 19, 2021 at 07:00:03AM +1000, Alistair Francis wrote: > Signed-off-by: Alistair Francis I would suggest you add some commit log, and have subject like below. ARM: dts: imx7d-remarkable2: Add WiFi support > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 91 +++++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index 8cbae656395c..c3dda2b92fe6 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -21,6 +21,27 @@ memory@80000000 { > device_type = "memory"; > reg = <0x80000000 0x40000000>; > }; > + > + reg_brcm: regulator-brcm { > + compatible = "regulator-fixed"; > + regulator-name = "brcm_reg"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_brcm_reg>; > + gpio = <&gpio6 13 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <150>; > + }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi>; > + reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > + clocks = <&clks IMX7D_CLKO2_ROOT_DIV>; > + clock-names = "ext_clock"; > + }; > }; > > &clks { > @@ -56,6 +77,27 @@ &usbotg2 { > status = "okay"; > }; > > +&usdhc2 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default", "state_100mhz", "sleep"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>; state_200mhz is missing. Shawn > + pinctrl-2 = <&pinctrl_usdhc2>; > + mmc-pwrseq = <&wifi_pwrseq>; > + vmmc-supply = <®_brcm>; > + bus-width = <4>; > + non-removable; > + keep-power-in-suspend; > + cap-power-off-card; > + status = "okay"; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > &usdhc3 { > pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > pinctrl-0 = <&pinctrl_usdhc3>; > @@ -76,6 +118,13 @@ &wdog1 { > }; > > &iomuxc { > + pinctrl_brcm_reg: brcmreggrp { > + fsl,pins = < > + /* WIFI_PWR_EN */ > + MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > @@ -90,6 +139,39 @@ MX7D_PAD_EPDC_DATA08__UART6_DCE_RX 0x79 > >; > }; > > + pinctrl_usdhc2: usdhc2grp { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x59 > + MX7D_PAD_SD2_CLK__SD2_CLK 0x19 > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59 > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59 > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59 > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59 > + >; > + }; > + > + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x5a > + MX7D_PAD_SD2_CLK__SD2_CLK 0x1a > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5a > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5a > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5a > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x5a > + >; > + }; > + > + pinctrl_usdhc2_200mhz: usdhc2grp_200mhz { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x5b > + MX7D_PAD_SD2_CLK__SD2_CLK 0x1b > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x5b > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x5b > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x5b > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x5b > + >; > + }; > + > pinctrl_usdhc3: usdhc3grp { > fsl,pins = < > MX7D_PAD_SD3_CMD__SD3_CMD 0x59 > @@ -143,4 +225,13 @@ pinctrl_wdog: wdoggrp { > MX7D_PAD_ENET1_COL__WDOG1_WDOG_ANY 0x74 > >; > }; > + > + pinctrl_wifi: wifigrp { > + fsl,pins = < > + /* WiFi Reg On */ > + MX7D_PAD_SD2_CD_B__GPIO5_IO9 0x00000014 > + /* WiFi Sleep 32k */ > + MX7D_PAD_SD1_WP__CCM_CLKO2 0x00000014 > + >; > + }; > }; > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel