From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A78C433ED for ; Tue, 18 May 2021 10:17:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC288611B0 for ; Tue, 18 May 2021 10:17:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC288611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tr23/yfY8yZvECHCMXzU0XCkdKo3X7WbarfcbhrFANQ=; b=XcoShL2IkHe56EChAU/GU8wcf K/fOY07PwNuRdlUSkBwsDvhgKci5kvEwtAA2B0LLtchJsB0VmztmHukr8Bg7geG52E9cn4aDghKoa RBDq48lO4MgvkDqIDKXlUwmU3NWETbW0GRoqw5JrVDPVkZi8Yc9flyJiU8jykCDLGro7YbvmFxsQE /hgDO19uYU7kO5NK4XDiRGRNakOeOka4rfLw0whFP1BblRNnHlkwreovxwpzGJAmUb60GOgN9z/qA PZfcNdxfz3tYYBu/XWZxaiZZdNnmDqgthcj0pkUgjVAgCdno862UmlZxcCt/eXI1CuYIucsXve8be aIY0Yj+VQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liwlJ-000JrZ-1H; Tue, 18 May 2021 10:15:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liwZG-000Gml-HB for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 10:03:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xbxQ7LflgvywD0uq2+jWyofzThk1Q3xiYg3qZ0VHMnQ=; b=xyeTagqaJRfvftFudC4eC9JeCX PsEbVuDdaleR2SneR2otorJ2+MaxZZNxhhJr66spOD5AKcNZBKhoOGUOR6RMUt6YLr09sKXURtW/t A6smiM4B4JU0ACD2THMyvt5uRTT+ee/p3nw3J8sqclvGWCD8G2gxDsCUtCTdHXQHjvcvV0yoUa2VZ tWHyFcKhIUQHiIzE2SXBqXAWsaVO7l5+Tzcr2HajSGHEfNbAwPPnUJnSRcK0SSE8VASV8TP+SzQzh fJYDZzUYUl44W/+SDVrj+XfNRKNnQsWzjRxtTtzx1AkFoeha/UGolkP1qgaFjGI5+HTN7DQQNaZ5V SzCTolZQ==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liwZD-00EXQZ-Qk for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 10:03:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xbxQ7LflgvywD0uq2+jWyofzThk1Q3xiYg3qZ0VHMnQ=; b=Fd/X1Lue1feIdaCIJ/F9pJM4W aHDrQfIGkftvyaxgcswhtDvYDJvbovHuksw6PRa4zLWFAwG7RcyU5QgI8v6d05hpDe89xGMB2d4aZ IE/Odo6u7q8iUyq6upTArt5DXsrlMjY41xFIOn1zJQy1UucRtYzS51o73HxLkfhEmqJNObj4R/QVL lBnbTVBeOXJQl7Q1Zdy+RGn0dJhwrhav1O2Vs5dOW+a67jxUT3sHAFaEeJ/M1EvbVYPi6C4XHTiyB qTTrFfHgZWbnvLCvcUeZ8w9Uegkm0zbcMbF6k6mnW+HpLf11Z1lvqoFMjIFdI7v7wU48YkT7m1wwG +7waiIxvQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44124) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liwZA-00041w-6W; Tue, 18 May 2021 11:03:08 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1liwZ8-0007nC-So; Tue, 18 May 2021 11:03:06 +0100 Date: Tue, 18 May 2021 11:03:06 +0100 From: "Russell King (Oracle)" To: Randy Dunlap Cc: Steve French , CIFS , linux-fsdevel , LAK Subject: Re: Fwd: [EXTERNAL] Re: ioctl.c:undefined reference to `__get_user_bad' Message-ID: <20210518100306.GS12395@shell.armlinux.org.uk> References: <202105110829.MHq04tJz-lkp@intel.com> <5b29fe73-7c95-0b9f-3154-c053fa94cb67@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5b29fe73-7c95-0b9f-3154-c053fa94cb67@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_030311_884315_59511B31 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 02:06:33PM -0700, Randy Dunlap wrote: > [adding back linux-arm-kernel; what happened to it? ] Nothing. I'm not interested in trying to do major disgusting contortions to make get_user() work for 8-byte values. If someone else wants to put the effort in and come up with an elegant solution that doesn't add warnings over the rest of the kernel, that's fine. As far as I remember, everything in __get_user_err() relies on __gu_val _not_ being 64-bit. If we use the same trick that we do in __get_user_check(): __inttype(x) __gu_val = (x); then if get_user() is called with a 64-bit integer value and a pointer-to-32-bit location to fetch from, we'd end up passing a 64-bit integer into the __get_user_asm() which could access the wrong 32-bit half of the value in BE mode. Similar issue with 64-bit vs pointer-to-16-bit. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel