From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13D1C433ED for ; Tue, 18 May 2021 10:19:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B9BA60BD3 for ; Tue, 18 May 2021 10:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B9BA60BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O9VDykk3/yasJMlqeNMibg3Nz7Z9LTgF/bEZMePPYdk=; b=a2KX/VnK4fBpyJGiJMdnuaWEq mdQlaEwXG/aYBfeKTr+iAbntTrb+ETgEokxIicE+8xneBput3I+zQ3Y+wmkYjSdR4TGe/A+zdUTCX HjatuRIrL0Xee2UwxyWrZ6SK2Tbh7PvlhLgNsDXxxA4HUlHiyvEyso97t5BuZjH+El1M9z47g+rVa 8rnZjLfg98wx5Me46kLkxKGtvUobcsS1k4ejO1+Trxfy2GrlVIkissTXso+eiP2RRLP70+DvHrtNv GfWYTi9tQ7kdKzpiQsb9fPkZK+Iu28fftIBXDV8Etr+s2nxYILlrItDnW6CgYg0YPtD++533rxsJH JCdTUSR0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liwnP-000KVY-8q; Tue, 18 May 2021 10:17:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liwhE-000IWb-38 for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 10:11:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PD48VAeGtcgeqofKNCFhA5nKZ2fdLjnft0GlXSmcvyA=; b=2dovPO2DbdgVwyqljWWvW7td2d Wqx7TKVAD2UrY96p3Q3/RZf94Q0HBaHDJvj/WR+j5vCRaffp+mAOQRuUy9H59xK+XlNABip4kmLxm 7HcLFXv+6XXt8rYjtjQUMlDdowkXH84XLItKlFk+8+mcho8I9C0JRzgfLBNHaTh1cRGitDuISoSDl VDqBLwGdYW9S+B/k/QHlhzOEo1nxkBdx1s2oeHmsQEtQw4k9ZeQRf+Y/uqWy2MqiobZOcHp1bJAxT JQOb6MS3a8a06ZTqGVK9U0a/R1jE/Iu9f+LhFPmWSwWn21TaQWwFfMRcvCAlchXWiebBA9+L6UGIy FN49VlPg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liwhB-00EXyt-9n for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 10:11:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B6DD71FB; Tue, 18 May 2021 03:11:23 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.6.226]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 09E983F719; Tue, 18 May 2021 03:11:19 -0700 (PDT) Date: Tue, 18 May 2021 11:11:17 +0100 From: Mark Rutland To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Robin Murphy , Nitesh Lal , Jesse Brandeburg , Marc Zyngier , Will Deacon , linux-arm-kernel@lists.infradead.org, Frank Li , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Shaokun Zhang Subject: Re: [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint() Message-ID: <20210518101117.GC82842@C02TD0UTHF1T.local> References: <20210518091725.046774792@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518091725.046774792@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_031125_407081_71BE5E84 X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thomas, On Tue, May 18, 2021 at 11:17:25AM +0200, Thomas Gleixner wrote: > The modular PMU drivers use irq_set_affinity_hint() to set the affinity > for the PMU interrupts, which relies on the undocumented side effect that > this function actually sets the affinity under the hood. > > Setting an hint is clearly not a guarantee and for these PMU interrupts an > affinity hint, which is supposed to guide userspace for setting affinity, > is beyond pointless, because the affinity of these interrupts cannot be > modified from user space. > > Aside of that the error checks are bogus because the only error which is > returned from irq_set_affinity_hint() is when there is no irq descriptor > for the interrupt number, but not when the affinity set fails. That's on > purpose because the hint can point to an offline CPU. > > Sigh, if people would at least talk if something is missing... > > Clean up the mess by exposing irq_set_affinity() and converting the drivers > over to that. Sorry about this, and thanks for cleaning this up. For the series: Acked-by: Mark Rutland Mark. > > Thanks, > > tglx > --- > drivers/perf/arm-ccn.c | 6 +--- > drivers/perf/arm-cmn.c | 9 +----- > drivers/perf/arm_dmc620_pmu.c | 5 +-- > drivers/perf/arm_dsu_pmu.c | 8 +---- > drivers/perf/arm_smmuv3_pmu.c | 10 ++----- > drivers/perf/fsl_imx8_ddr_perf.c | 5 +-- > drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 3 -- > drivers/perf/hisilicon/hisi_uncore_hha_pmu.c | 3 -- > drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 3 -- > drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 3 -- > drivers/perf/hisilicon/hisi_uncore_pmu.c | 4 +- > drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c | 3 -- > include/linux/interrupt.h | 35 +------------------------- > kernel/irq/manage.c | 33 +++++++++++++++++++++++- > 14 files changed, 49 insertions(+), 81 deletions(-) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel