From: Will Deacon <will@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Nitesh Lal <nilal@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, Frank Li <Frank.li@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Subject: Re: [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint()
Date: Tue, 18 May 2021 11:48:49 +0100 [thread overview]
Message-ID: <20210518104849.GB7770@willie-the-truck> (raw)
In-Reply-To: <20210518091725.046774792@linutronix.de>
Hi Thomas,
On Tue, May 18, 2021 at 11:17:25AM +0200, Thomas Gleixner wrote:
> The modular PMU drivers use irq_set_affinity_hint() to set the affinity
> for the PMU interrupts, which relies on the undocumented side effect that
> this function actually sets the affinity under the hood.
>
> Setting an hint is clearly not a guarantee and for these PMU interrupts an
> affinity hint, which is supposed to guide userspace for setting affinity,
> is beyond pointless, because the affinity of these interrupts cannot be
> modified from user space.
>
> Aside of that the error checks are bogus because the only error which is
> returned from irq_set_affinity_hint() is when there is no irq descriptor
> for the interrupt number, but not when the affinity set fails. That's on
> purpose because the hint can point to an offline CPU.
>
> Sigh, if people would at least talk if something is missing...
>
> Clean up the mess by exposing irq_set_affinity() and converting the drivers
> over to that.
This all looks good to me, thanks. Given the number of PMU drivers it
touches, it may well conflict with driver work for 5.14. If you put the
IRQ core stuff on a stable branch, then I could pull that into the Arm
perf tree and stick all the driver changes on top. That also means any
new drivers that come in can use irq_set_affinity() right away.
Does that work for you?
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-18 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:17 [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint() Thomas Gleixner
2021-05-18 9:17 ` [patch 1/8] genirq: Export affinity setter for modules Thomas Gleixner
2021-05-18 9:17 ` [patch 2/8] perf/arm-ccn: Use irq_set_affinity() Thomas Gleixner
2021-05-18 9:17 ` [patch 3/8] perf/arm-cmn: " Thomas Gleixner
2021-05-18 9:17 ` [patch 4/8] perf/arm-dmc620: " Thomas Gleixner
2021-05-18 9:17 ` [patch 5/8] perf/arm-dsu: " Thomas Gleixner
2021-05-18 11:31 ` John Garry
2021-05-18 15:50 ` Thomas Gleixner
2021-05-18 9:17 ` [patch 6/8] perf/arm-smmuv3: " Thomas Gleixner
2021-05-18 9:17 ` [patch 7/8] perf/imx_ddr: " Thomas Gleixner
2021-05-18 9:17 ` [patch 8/8] perf/hisi: " Thomas Gleixner
2021-05-18 10:11 ` [patch 0/8] genirq, perf: Cleanup the abuse of irq_set_affinity_hint() Mark Rutland
2021-05-18 10:48 ` Will Deacon [this message]
2021-05-18 15:51 ` Thomas Gleixner
2021-05-19 9:08 ` Thomas Gleixner
2021-05-24 20:20 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518104849.GB7770@willie-the-truck \
--to=will@kernel.org \
--cc=Frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nilal@redhat.com \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox