From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F44C43460 for ; Tue, 18 May 2021 11:33:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32150611AD for ; Tue, 18 May 2021 11:33:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32150611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Id65SQOBXTJeSyK3n4nu2dzRJVO6BxzOmH3IbpT1lzs=; b=BTNixFsLcXyxv4n8czyAi4QbP aNVKiv2aTHTz29+W8gbi1eMkuYvdtHLHWIJZu3qXEwXwdQdzPi3gNpLo5l8ZQ3S3b/0Q6XkrF3FFz UiFKQ82QcGccilvcpkLRf2DtT8drkSvLeu46PAB7ednnDkKeTQWFYu/SaA3PxUhoaUHkhdcO95VPh 6QNsipvywoR9pgz1/6y2ORt9qAAZes2uxoB02aA7B16Vp7Jrh+vE5UpmjeXoWx7yjdJYgKUafilnX hXATvrcW9S6uDp/8Zc/WyKQyn4Gll4S5nO/w9wW+iWLBaUdbSxpbXC9GxkYTiGly7vlcvGCb7cxF3 VQNWjTfGA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lixx3-000ZDx-B8; Tue, 18 May 2021 11:31:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lixx0-000ZDO-5a for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 11:31:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RVUhSCgd6iQAK0YSfHil0g0540QhJdzDOaZHYw4efBo=; b=jMOTzz6Ucg+AYDAn6YPXixm5nX fswnkPro53vDJOoAOqux/BpYOnhorivcBBmhpXvEfDVBFpDefYJRUpMz8F5bCq+LpIliwjMfG3gCF njRu2cyP3Cn3C3zLOHUTHmmhLB/c+r2fmyd5o7zl81MP4WEkqQrNdslDiW171qsbhrcxu+4zBaBRK SVh47HB9jTrYGYH4bfCpBEGZ04I1qy19UD76UQqDz16GdowKPJXIMeoursx7YuwhAHB6+3Joq8nlG sJ7ZNRapTmmDD5FSslbtMZPWHikQl9378M5WegA1FLTI32mJgULs49xlutv0utJHzaiKkYe2HTycs Pa4EWqWQ==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lixwx-00EbQP-8l for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 11:31:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RVUhSCgd6iQAK0YSfHil0g0540QhJdzDOaZHYw4efBo=; b=tl66YL0JYskY6r9w4wyuz1msm 2nN5acglOY9mroY2uRDEigtHcNw/lxmbReo/GR0Wt8VyC5ni7zKmpRaOJLOCpfgK/dxHXOUIL5tCq aGcRVwrUs7lIyjwTfFnao1fs88QDm9YEdiHycchb9PR+GFUC1YH2UDApAY2ZT8SvG/z9PncAvC6Zp kZIL+XLsXuZroU2QD/0o93SjzghJ1ilf3PGOjpTy4b7OIhJYnRvzicYZQqZMJcjfL32lzzLH9ul/p otEiCDS+/fseB8D12RJcshFcL8vwUt2lQD8UdU5aY2WC3ZoQ7Ebs/yDoK5aYREWJ3OA6nFBvVCdEq QYEjvkmBw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44130) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lixuq-0004B6-8m; Tue, 18 May 2021 12:29:36 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lixum-0007r3-6a; Tue, 18 May 2021 12:29:32 +0100 Date: Tue, 18 May 2021 12:29:32 +0100 From: "Russell King (Oracle)" To: Yanfei Xu Cc: rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org, akpm@linux-foundation.org, carver4lio@163.com, tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Message-ID: <20210518112932.GV12395@shell.armlinux.org.uk> References: <20210518111254.3820480-1-yanfei.xu@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518111254.3820480-1-yanfei.xu@windriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_043147_332475_8B164D71 X-CRM114-Status: GOOD ( 24.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 18, 2021 at 07:12:54PM +0800, Yanfei Xu wrote: > The value of "vmalloc=" set in cmdline is always 8M more than the value > of "VmallocTotal" in meminfo. When use the "vmalloc=" parameter, user > expect to get the size what they input, and no need to consider the 8M > "hole" hided in codes. This commit make real vmalloc size equal to value > of "vmalloc=" in cmdline. > > Also, the commit will reduce the size of vmalloc printed in boot message > by 8M when the size set in cmdline is irrational. Hi, I think I'd like to do several cleanups with this: 1. change vmalloc_min to be an unsigned long. 2. exclude VMALLOC_OFFSET from vmalloc_min, moving it into adjust_lowmem_bounds where vmalloc_min is used. 3. rename vmalloc_min to be vmalloc_start 4. enforce vmalloc_start to be a multiple of 2MiB 5. in early_vmalloc(), calculate vmalloc_max as: VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET) and use that to set the upper bound of vmalloc_reserve (which is something your patch doesn't do, which I think is a bug. Thoughts? > > Signed-off-by: Yanfei Xu > --- > arch/arm/mm/mmu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index c1e12aab67b8..287c5115af4d 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -1133,19 +1133,20 @@ static int __init early_vmalloc(char *arg) > { > unsigned long vmalloc_reserve = memparse(arg, NULL); > > - if (vmalloc_reserve < SZ_16M) { > - vmalloc_reserve = SZ_16M; > + vmalloc_reserve = ALIGN_DOWN(vmalloc_reserve, SZ_8M); > + if (vmalloc_reserve < SZ_8M) { > + vmalloc_reserve = SZ_8M; > pr_warn("vmalloc area too small, limiting to %luMB\n", > vmalloc_reserve >> 20); > } > > if (vmalloc_reserve > VMALLOC_END - (PAGE_OFFSET + SZ_32M)) { > - vmalloc_reserve = VMALLOC_END - (PAGE_OFFSET + SZ_32M); > + vmalloc_reserve = VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET); > pr_warn("vmalloc area is too big, limiting to %luMB\n", > vmalloc_reserve >> 20); > } > > - vmalloc_min = (void *)(VMALLOC_END - vmalloc_reserve); > + vmalloc_min = (void *)(VMALLOC_END - vmalloc_reserve - VMALLOC_OFFSET); > return 0; > } > early_param("vmalloc", early_vmalloc); > -- > 2.27.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel