From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3324C433B4 for ; Tue, 18 May 2021 16:05:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F18A611AC for ; Tue, 18 May 2021 16:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F18A611AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6S30tmQnrPP00UQIQxALXcOFbO6yVpd6cqjDnKgj9hE=; b=SmGNHNkLw77Lm3tBy1L4O+HVl Vg9M+QbA1qtKTmC+h7Zf7YBksb6QCXBgSgaKCkQ7ch2zvneo3N96PzQS9EGJAaQFNAqzZ0LGCDgGm HJg8WVq1VEwSPbZjnU+fzzzZqL+bCpZlajmALvHy6CSXHkDBTKehPU+TOkU0GVc8iEwFc0NyqROVj pZc2E9bCmRu9Q+30sIo73g3MYZPOhPfN0YU0qdOc0el2nDEE9SyxJ/T2sjUM8ZHr4S/oq8oy+fkMC NkHu1lLPEAVrHfkYPqh2vfYrhV8Qr4ll4IhzIvULwZSqIZ5A6y0lkcQBdfejHpH4Mp09R9Fj8GmkK 76uJ+B4Tg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj2CG-001GPD-40; Tue, 18 May 2021 16:03:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj2CB-001GOb-R5 for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 16:03:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wQx5M8AJUFqXXymZp47ywacADpElg9z0TbfWu84GkU4=; b=PEWC74nPfjHk63Ld8r3L8hdeyM JvPy4dkISDY3O+R/KL0utVAOjhRvVuUTgJDZTYXgs0G4/yPLQb8xY9En5R/FfqSdbYKI7yd4gKHhs cxhG80h1n8J7oEAeRpgxIfPMapDeGmNKkFJls9OtmcT35zCKakfL3SP/VoHDhnjGtBwp2Ea71au26 Zb3F4P3cdV7OaHFKSwXirvEpK1ac++VsFimn5WYI3uKfP/7q/qADMbeOA0nc0O7+RnM57p0NEvgOG U7jceDdSH+GtyzcCK0F8XqrXVwUHqk+DXhITgZLuVgWiSBS+BmxTdS5/BeuWBz4awFJCQH348Yzys 0sd6+uQg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj2C9-00EmmM-0k for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 16:03:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 304076D; Tue, 18 May 2021 09:03:43 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.6.226]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 804793F73B; Tue, 18 May 2021 09:03:41 -0700 (PDT) Date: Tue, 18 May 2021 17:03:39 +0100 From: Mark Rutland To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com Subject: Re: [PATCH v2 07/16] arm64: Fix comments to refer to correct function __flush_icache_range Message-ID: <20210518160339.GN82842@C02TD0UTHF1T.local> References: <20210517075124.152151-1-tabba@google.com> <20210517075124.152151-8-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210517075124.152151-8-tabba@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_090345_129546_0BBC7EC8 X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 08:51:15AM +0100, Fuad Tabba wrote: > Many comments refer to the function flush_icache_range, where the > intent is in fact __flush_icache_range. Fix these comments to > refer to the intended function. > > No functional change intended. That's probably due to commit: 3b8c9f1cdfc506e9 ("arm64: IPI each CPU after invalidating the I-cache for kernel mappings") ... since that renamed flush_icache_range() to __flush_icache_range() and added a wrapper. > > Signed-off-by: Fuad Tabba Acked-by: Mark Rutland > --- > arch/arm64/kernel/hibernate-asm.S | 4 ++-- > arch/arm64/mm/cache.S | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/hibernate-asm.S b/arch/arm64/kernel/hibernate-asm.S > index 0ed2f72a6b94..ef2ab7caf815 100644 > --- a/arch/arm64/kernel/hibernate-asm.S > +++ b/arch/arm64/kernel/hibernate-asm.S > @@ -45,7 +45,7 @@ > * Because this code has to be copied to a 'safe' page, it can't call out to > * other functions by PC-relative address. Also remember that it may be > * mid-way through over-writing other functions. For this reason it contains > - * code from flush_icache_range() and uses the copy_page() macro. > + * code from __flush_icache_range() and uses the copy_page() macro. > * > * This 'safe' page is mapped via ttbr0, and executed from there. This function > * switches to a copy of the linear map in ttbr1, performs the restore, then > @@ -87,7 +87,7 @@ SYM_CODE_START(swsusp_arch_suspend_exit) > copy_page x0, x1, x2, x3, x4, x5, x6, x7, x8, x9 > > add x1, x10, #PAGE_SIZE > - /* Clean the copied page to PoU - based on flush_icache_range() */ > + /* Clean the copied page to PoU - based on __flush_icache_range() */ > raw_dcache_line_size x2, x3 > sub x3, x2, #1 > bic x4, x10, x3 > diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S > index d74b20cd6449..8920f63442ae 100644 > --- a/arch/arm64/mm/cache.S > +++ b/arch/arm64/mm/cache.S > @@ -62,7 +62,7 @@ alternative_else_nop_endif > .endm > > /* > - * flush_icache_range(start,end) > + * __flush_icache_range(start,end) > * > * Ensure that the I and D caches are coherent within specified region. > * This is typically used when code has been written to a memory region, > -- > 2.31.1.751.gd2f1c929bd-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel