Re: [PATCH v2 07/19] arm64: entry: convert IRQ+FIQ handlers to C

Mark Rutland
2021-05-21T15:28:35Z

On Fri, May 21, 2021 at 02:19:15PM +0100, Joey Gouly wrote:
> Hi Mark,
>
> On Wed, May 19, 2021 at 01:38:50PM +0100, Mark Rutland wrote:
> > For various reasons we'd like to convert the bulk of arm64's exception
> > triage logic to C. As a step towards that, this patch converts the EL1
> > and EL0 IRQ+FIQ triage logic to C.
> >
> > Separate C functions are added for the native and compat cases so that
> > in subsequent patches we can handle native/compat differences in C.
> >
> > Since the triage functions can now call arm64_apply_bp_hardening()
> > directly, the do_el0_irq_bp_hardening() wrapper function is removed.

[...]

> > - .macro el0_interrupt_handler, handler:req
> > - user_exit_irqoff
>
> Nothing is using the user_exit_irqoff macro anymore, it could be
> removed?

Sure, I'll get rid of that.

> > - enable_da
> > -
> > - tbz x22, #55, 1f
> > - bl do_el0_irq_bp_hardening
> > -1:
> > - irq_handler \handler
> > - .endm
> > -
>
> [..]
>
> Reviewed-by: Joey Gouly <joey.gouly@arm.com>

Thanks!

Mark.