From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 275D5C433B4 for ; Wed, 19 May 2021 14:08:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A872560FE9 for ; Wed, 19 May 2021 14:08:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A872560FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q808UzfD0ZRSyjKzhZuVp4lypxvN1beSY2oMH3tlro4=; b=k0n89gz3Dv7p1evUVPp6esX+b tsGmw0Qu4ux/fV1QNsIp8K51SBTyAEu09YYHqdzepW0ab8p8PSzWpWePJWohC2HSfbE8i7UwPhWYO lY5vUSuMsinL22X43lnV32amaRQ1JRIQFuhTofS/rMGlj/guQeErISSXsbd9f8DjdhOJhZ5KhZmAk XL0rR4jVneNQuiYaeW7wwAwVRYofHjQTQOttsYrZX7AK/ziQBzEYihnYnj0FtZ3Q0oE6Rbtftt38f uACrIeQaQb7WDwOJlSiQo75eJRNcteWoCBNN2RFWCHok8U8j4ys1CO6NJMmzMxaUi54pIujX8WMEv zIQ5NT6nw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljMpl-004Cxl-LU; Wed, 19 May 2021 14:06:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljMpi-004CxS-E4 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 14:05:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F8hfnOpsFHFKiDi3a3FsFNqLWg3Cj9oeQDowWGPevqg=; b=UHTUeL3UPP70pZhRYWaB9Bq//J 66zfRzLaJlWKNneoTQEqrTEqeectGdqoQGB0tgnmzr47KSJymWkfzef0A13DOE/VFFcIXL0rqapd/ 0E/FLbC53aDkPxflkPGQmuwafAUTCXTSk5KOj5Dw1ZUE64VWtBNvQVahXH/iG0Rn8laACfyW3yZAr XBLdrYrcMcAT5oYkE88p07DLvvnKJJ1Twj8gdSD+5kprjzdutCnX4LXiaJHKixlpEPOX23wmCBvXb fgsX/V7biYr3OhcewoE/zmh9MmcwlGdA06FHNPBRgGqyxQ1ss8faBg0oZwbp24BoS0hRBN25fPNhS hZ1+iSpw==; Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljMpf-00FWWh-Ez for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 14:05:56 +0000 Received: by mail-pf1-x432.google.com with SMTP id q2so9943922pfh.13 for ; Wed, 19 May 2021 07:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F8hfnOpsFHFKiDi3a3FsFNqLWg3Cj9oeQDowWGPevqg=; b=rHtXU7gHoN/C99voQdngvK7w0l1IuA+mMvx6YOEWYcDtedfJz4PB3d7xTWfzivp+OG dJ9W1UCw0X/5gFiWWtCs696TGDzTtr79Vt79a0GXYMLVs3AmLZjGeh9w1fQK90Ls0GVJ M8M0wekDuQI1kcYjJV5/Fq6s91qWe9eRrgmWV6eQ64Wgb0eegylfTJ2FU51pbLVu7Go4 7Zx53EYdQ6GuMK7sdFOH5EE3uUNwG0NIQ8+6MCychZxpEuIwgH8kQzF4xpPdbDIHqk+K QHQhPB6taAnUkSeGijZgaOvrDprlLgV35fYfEmKFxEGWCXR9VIRwJxVA4NWNp5pl4W10 PDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F8hfnOpsFHFKiDi3a3FsFNqLWg3Cj9oeQDowWGPevqg=; b=ntOze00S4g3i27ftF0KUo10/sALah8k80ospVbMKmsxOGTgQVEp1xTeXZlXDzpBAUo jQYrXWD7sbLSpye/KpWEoEXE7th2+ZYL/uo5B5hVNz1M2DD4VXhIqguqmt1AUTa4rTk7 4PHL0ulcNjMYzqUes/xUxVJfIHzt7OamBLU5+BMWt6Gszl/zAarg31Z9kEl+FeYjSoZz JvhaKRwmdHhyzcwNYAy5Zpmq16dNcEsC/OWPCppB+JNlWCAX+91Nnpa851FnqP8FC3A2 q2PMhHNtLLs9PzLfgWTAjRT7zrPOBnWZwEyFd2dRiZpxCB+cGbHfZIl8tqJ8/w/bqeTQ R3EA== X-Gm-Message-State: AOAM530AlancMr5aNaxh31l8RikJD1A+zuXHA6756YojUzbc1nGO7Ft1 oshwIRpwSgJtMcibQa5OxZ8Txw== X-Google-Smtp-Source: ABdhPJxzui/5fJJoxj2JLmIP48hL6wiLreukfO/zU8YhItORMzxDi+GmqSRBkQ8gE3Sh3tEafFVlKA== X-Received: by 2002:a05:6a00:1384:b029:2c7:fcda:8d83 with SMTP id t4-20020a056a001384b02902c7fcda8d83mr11247623pfg.0.1621433153365; Wed, 19 May 2021 07:05:53 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id u22sm15318844pfl.118.2021.05.19.07.05.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 May 2021 07:05:52 -0700 (PDT) Date: Wed, 19 May 2021 22:05:45 +0800 From: Shawn Guo To: Ard Biesheuvel Cc: Maximilian Luz , Catalin Marinas , Will Deacon , Jeffrey Hugo , Bjorn Andersson , linux-efi , Linux ARM , linux-arm-msm Subject: Re: [PATCH] arm64: efi: add check for broken efi poweroff Message-ID: <20210519140545.GA26772@dragon> References: <20210305065120.11355-1-shawn.guo@linaro.org> <20210517005903.GA15021@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_070555_582265_2C3B8BEB X-CRM114-Status: GOOD ( 26.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 18, 2021 at 09:44:12AM +0200, Ard Biesheuvel wrote: > On Mon, 17 May 2021 at 02:59, Shawn Guo wrote: > > > > + Maximilian > > > > On Fri, Mar 05, 2021 at 08:01:02AM +0100, Ard Biesheuvel wrote: > > > On Fri, 5 Mar 2021 at 07:51, Shawn Guo wrote: > > > > > > > > Poweroff via UEFI Runtime Services doesn't always work on every single > > > > arm64 machine. For example, on Lenovo Flex 5G laptop, it results in > > > > a system reboot rather than shutdown. Add a DMI check to keep such > > > > system stay with the original poweroff method (PSCI). > > > > > > > > Signed-off-by: Shawn Guo > > > > > > What is the point of using EFI runtime services on this machine if > > > poweroff doesn't work either? Can't we just boot this thing with > > > efi=noruntime? > > > > Ard, > > > > With Maximilian playing ACPI kernel on Microsoft Surface Pro X, this > > ResetSystem service issue triggers more discussion and testing [1]. > > Maximilian tested it with uefi-test-runner and reported that ResetSystem > > actually works [2]. > > > > Looking at the kernel dump, I'm wondering if it's because that kernel > > calls into the services with assuming they are in virtual addressing > > mode, while actually they are in flat physical mode instead, due to > > that SetVirtualAddressMap() call is skipped (efi_novamap). > > > > That looks like a firmware bug. Boot with efi=debug to figure out > whether the faulting address is a physical address that falls inside a > EfiRuntimeServicesData region. Last time when I was seeing reboot/poweroff broken on Flex 5G, I did not capture any kernel dumps. I will retry with efi=debug and see if I can get more information. In the meantime, could you help me understand if EFI must be running in virtual address mode when kernel is calling into the services, or it should work no matter EFI is running in virtual or physical address mode? Thanks! Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel