From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54DAC433ED for ; Fri, 21 May 2021 11:27:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73833613CC for ; Fri, 21 May 2021 11:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73833613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+u5JV1PAXOKahMNy+U1rjQqGuzbRlsHD9/BfD9HmceI=; b=aNOIPlmgQKEfPEVRCV3ADkLCAS jNpTkB12BYx3KO2ESeYVpI3Ro+rYHzkAj/MJ6KGNe/s9rpRmaqzhty2gtz/J8LTLDBNd2z3O2wPzL 1EZrGnf/OPtcEIzyA48B6bMrse6bPa71LPH34H5cisssr6NExRGzWSmCCupkZm+WC7eSZZ43onj27 0yADumuHwc2od5VmvToEN6h9pDFOxhfo3RU+9sQtnJoLulhvIVP2x/4zZhzVXct0FiqVYTEFGMPNy adSpOFB1zrKAPiqgvZd3EzFOhlVLyG5/93ecYlaxyTw+K/Un07NXLllgATQIpVC6v075CRagvz+id j5fNUKJQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk3HI-0058VG-5P; Fri, 21 May 2021 11:25:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk3HD-0058Ta-V2 for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 11:25:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=WuTQwMYw4rLCWjV1HlhIW9TmWK4/W4VSs1kGs8bXeMo=; b=RG8+c/MvXpG6ToXfaQGVREx/jb ZqdcMKqjKT96Epcp+qov1BcZ9sb/KptiP1sgxcj4HdfEE8awYcMqe3B9qIljOe2nUGo5BLGAS1MTh g/1SzKhMUwSlSDwZkWNT6SLKiZnpP+Ku8x/Y+C0/zZI879W0ZBG1IJh/0py30a+RPBqk8emAfZsS0 QBXqjC8Cgg/Oj4Ilw3MyiC3gJuxAHjpOElJ3ddeqBxji91XBaAkHYI0XxEPMmJo5O6xXWlIMn6Y6/ clygbf+lbdugaiK9T4jtVh99JvbIuok2o6pVeDI+Fj/sew/eHMXygnEMeho9D3JKbDTd/moklvSDq /MsRbOkg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk3HB-00H4C6-HT for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 11:25:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 550A060E09; Fri, 21 May 2021 11:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621596309; bh=0QLS03Am82gWxNzfPbPumFkWehre23Y1zPmBLcVt0+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8TJV3MSrd+BUggm1UVjjXHIjKMdoqxvI/zoI7coPCrWcW8xBMJ2RdP6fuw03Xcnz Ye3GaH9jyxom61gbcKUF4NCqbGCoGsWMrlspqLOOVH3G0WHakHB+vM1V7KgqkyFZaT pK8HPLRGbxgGLqnz/WZT3nC1KoL+de8/268i1OUYw+9PgpQUwMhvI2R/AfxMqxJTlS 0qaTDyYBYnf+bZgW8M2RFznh28yWjXh+qfq81xN9Zx7QKjlRBFYCGqm49JXHObk3qF l0CyQmk/Bx4lMrBd1RHVnOoLb43IfNohnwK5GHZCmsTP78G4g7DeqB/cG3bbcED22X DGsGq9/WuwESQ== Date: Fri, 21 May 2021 12:25:04 +0100 From: Will Deacon To: Mika =?iso-8859-1?Q?Penttil=E4?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Thomas Gleixner , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: Re: [PATCH 3/5] tick/broadcast: Prefer per-cpu oneshot wakeup timers to broadcast Message-ID: <20210521112503.GA11850@willie-the-truck> References: <20210520184705.10845-1-will@kernel.org> <20210520184705.10845-4-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_042509_623192_31BAB9D6 X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 05:25:41AM +0300, Mika Penttil=E4 wrote: > On 20.5.2021 21.47, Will Deacon wrote: > > /* > > * Conditionally install/replace broadcast device > > */ > > -void tick_install_broadcast_device(struct clock_event_device *dev) > > +void tick_install_broadcast_device(struct clock_event_device *dev, int= cpu) > > { > > struct clock_event_device *cur =3D tick_broadcast_device.evtdev; > > + if (tick_set_oneshot_wakeup_device(dev, cpu)) > > + return; > > + > > if (!tick_check_broadcast_device(cur, dev)) > > return; > = > Does this disable hpet registering as a global broadcast device on x86 ? I > think it starts with cpumask =3D cpu0 so it qualifies for a percpu wakeup > timer. Well spotted, I think you're probably right. I'll try to reproduce on my laptop to confirm, but I hadn't noticed the tricks played with the cpumask on x86. I'll probably need to rework things so that we install the broadcast timer first, but prefer global devices. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel