From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A310CC4707A for ; Fri, 21 May 2021 17:04:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C07D613D9 for ; Fri, 21 May 2021 17:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C07D613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C4W4RH8PtfNBvQDiGOgH9mkTfx6DAmN9JNTh4QwD1dM=; b=PSHgm4c9r43EKyY8S0fsRzpSgj 2xWNKqMtjF6GSE+OIaK0Pn4f7B/kwm98fbRaf05klwhxaICGxtoacvA6vkAM/5kuXL/KZhTMfENRc Nz1ElWdXDEg6MJT/V8QuQK8bl5sDeLheyj3GWkK86hwkUbs4nNCWE1fJ1rd9CNnYvTOK4mpcKcGoH lulTjkxyGlwadUftXxzFLuQdhApa0asDRnJRoH0VKh1n3SaHrwu57kLyqMx9kvuyXxgeKpxdoJcXv KmgNwzBLL/WPitG+QxxxW+02P56gtrEHbtqAqRf2foZHNQz5LYD+oY0VKtQ0iHe7wlSosOmuKQn3V 2F/81lrA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk8Y3-000OMC-U1; Fri, 21 May 2021 17:02:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk8Xy-000OLT-76 for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 17:02:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:In-Reply-To:Content-Type :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5RUFMI52fs0kfqOK2bkGxke9oh7AB3Zsz19dTrXpNsY=; b=fJJEqER0lDTGMpmaQkaxJd4XsK t8BEqiAGOihm1IQZJXbYNROQ62BPg0QkqfPcub6IHsFqTwrsa1oCreqdKZfuZQzh+nmMqOEHA2Yxs AGiHOBCXcpZ9hF0uPCIy3Zue3+yKGyPh8HTB7yV1rVseuTwV+WsEoTbgLNG7BfRAalf16MbMmyweR wOPKlMEg3TkafVIeVk24bz1VRgyYufGCxrt+ELQBGqVPxTNV/cNZpEeXNCmnOunHlkAvUmSs4haDe ea7CvQLG1XqtriuiRRAzVjAUV/Aow3AYdSOru6HZsAB+aXbAxQ2gOns27yimpt6onVrGZkuMubUit MjCTWnvA==; Received: from mail-eopbgr140072.outbound.protection.outlook.com ([40.107.14.72] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk8Xv-00HIO7-AV for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 17:02:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RUFMI52fs0kfqOK2bkGxke9oh7AB3Zsz19dTrXpNsY=; b=pSLP6Qt5XwLmU4QEeH9tDcvqDw/TWoKnG5hBDr+mlYiGNlJ4NDa5zvyWILpoFgxbe/Y7oHyDU8OckI7y+GSk/n4rb/9/V8oHFqInj/i6xz6XkRl5c2fuH0nSHkBCgYrlay9/fyNP0A3z71QmkDbTNxNeoj1aBdqYr8wXuaz8zu4= Received: from DU2PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:10:232::20) by AM5PR0801MB2003.eurprd08.prod.outlook.com (2603:10a6:203:4a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Fri, 21 May 2021 17:02:43 +0000 Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::1) by DU2PR04CA0075.outlook.office365.com (2603:10a6:10:232::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Fri, 21 May 2021 17:02:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Fri, 21 May 2021 17:02:43 +0000 Received: ("Tessian outbound 0f1e4509c199:v92"); Fri, 21 May 2021 17:02:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 29b76480c41ba35b X-CR-MTA-TID: 64aa7808 Received: from 24ef90daea37.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9FB5C682-2B67-4AFF-813A-5F0CE7040E65.1; Fri, 21 May 2021 17:02:31 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 24ef90daea37.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 21 May 2021 17:02:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ej6f39vuTYoDjhCDoCvLmjjEr/alT7ofXglD4oBnYM6e/19TKvJuqY751CCbYCBUvxXj1vDokyObp5SP7WDKqSaEIPnWT96p0igdnNnLfqcdPoZW6RaxfriLOUGVwxlXopDGoHUkmlMzBjifDPaBFUNqgS9Y2yZBRKNYNWbXMgU3jBlwXLGowDmGkCIHx0sjrOri39dQiQuUa420DGDYEBEQcZ9p2zCc1KseKzxMOLvimSycbcx4WldVDO2eznCNTEig4c18rhyS4vr4+sT2yn5aREpFu9MrGkdqR5lIWzZ3YsQV6SjTnTt5fQXIVqckfpVJw0AkUJLxsNBGzbQOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RUFMI52fs0kfqOK2bkGxke9oh7AB3Zsz19dTrXpNsY=; b=jgoOTBrwiozZgF/7Sx89CPhYGc64Y9m4D53XjF1OnN3Z2ujOGbFeJ/fPRy5G9U28jGuiBzLsRwB8utFQV+7gTL07bs2JEtCGaKEdEKoLc0rlJIo2cnWVbHoNg2Y8+VaC+4a++hQ4f0J9yh9CcAgPOZlabOwfwc3ggSBJsfikW7R3dSM+NUglM0fGxDEsuNUNxtUS5bmg+H8x9BE1bpAeeosduNzfy91bw3XJMeJV64u8j+nRXNjAhqQSSVaJx9sBMJRtRFJdoEeWgkYVSF8IOmlvp0DceH0bqfh3FjCMevCrtwG9BQQrzSgCzEJ/m9VELi4skbn4Ymd2NiXzZ+KXXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RUFMI52fs0kfqOK2bkGxke9oh7AB3Zsz19dTrXpNsY=; b=pSLP6Qt5XwLmU4QEeH9tDcvqDw/TWoKnG5hBDr+mlYiGNlJ4NDa5zvyWILpoFgxbe/Y7oHyDU8OckI7y+GSk/n4rb/9/V8oHFqInj/i6xz6XkRl5c2fuH0nSHkBCgYrlay9/fyNP0A3z71QmkDbTNxNeoj1aBdqYr8wXuaz8zu4= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) by DB7PR08MB3819.eurprd08.prod.outlook.com (2603:10a6:10:30::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Fri, 21 May 2021 17:02:29 +0000 Received: from DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039]) by DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039%7]) with mapi id 15.20.4129.034; Fri, 21 May 2021 17:02:29 +0000 Date: Fri, 21 May 2021 18:02:21 +0100 From: Joey Gouly To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, will@kernel.org, nd@arm.com Subject: Re: [PATCH v2 12/19] arm64: entry: improve bad_mode() Message-ID: <20210521170221.GI35816@e124191.cambridge.arm.com> References: <20210519123902.2452-1-mark.rutland@arm.com> <20210519123902.2452-13-mark.rutland@arm.com> Content-Disposition: inline In-Reply-To: <20210519123902.2452-13-mark.rutland@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.53] X-ClientProxiedBy: SN4PR0201CA0031.namprd02.prod.outlook.com (2603:10b6:803:2e::17) To DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124191.cambridge.arm.com (217.140.106.53) by SN4PR0201CA0031.namprd02.prod.outlook.com (2603:10b6:803:2e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Fri, 21 May 2021 17:02:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de683d33-a8e9-4b59-e513-08d91c7a4010 X-MS-TrafficTypeDiagnostic: DB7PR08MB3819:|AM5PR0801MB2003: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2mox6jNUh5w3Ezzeju3h3H6mPbz5vr9hDAxfY/xmOK01s4aExDZ+Td/3gzcueGgAd+7xVvFLXGHoaxtTewDCgqvieuxhdtNpnJQNU1RQ/Trsb5D+lR/ZReC+xPDnk1vctSg5A5B2vOdD41er39ataZB2NkUE4YyhlZojwuUkIM+MNzkG0ZVpd4C+ouczomh044MqZQ3ky/2f0subKGZDymwDvwofvBa4zTL9RbJbIJsLw+Eo/ytaB6DhxzKPWJUPiwoLjHH+2cVUFSKjjPHlMJymgslT5tACfaOT6izqYfRBH4uDTciIyxIqQ+Itn4GtRBMCzfc92inQ1K+oVxEJbsas7rdxXIcPV684g0Hxh67MCOZb3WCYH8ATTa4MNalD1ccsbzorl+W8Sl0huPrtXm84X5trjyiG/CpAraV23FNPiKpwvQhhzwgwb+oj+s8o72xbJK3XztUWA6d+8VnAR3mhmJyMdqfJE5uTA+Hz9sabAZu4jBZzXe6qgcyVX6jqW8jEp7QA8Q81Q9h39b9gGBDF2Q2o5k3kIPrOQMJ6O1I1j3jsELf7+RwlloJEEiG9/7CvrUQ2VMb0ysPFd4IKYDQD8vUlc3Jnkc73PqpxUuPgUi1rq2t3lv6S98A5coSidv58O4mvVNUzXSzn8TTAmqdmh9jwb/wfvX6OF2eE2mc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR08MB5433.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39850400004)(366004)(136003)(376002)(4326008)(26005)(38100700002)(1076003)(8676002)(7696005)(38350700002)(55016002)(66946007)(8936002)(33656002)(52116002)(66476007)(44832011)(956004)(86362001)(66556008)(6862004)(478600001)(186003)(6636002)(316002)(16526019)(5660300002)(6666004)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?HU7lyJja6HLprz7P8L5V8dGedR1SKpJLbBXaij75esU9HV6lR56Tk4xGywoe?= =?us-ascii?Q?Rvo2VPjoFG9xngUhlHpSZRUmlW2LfvVdxb8eyvJAygVeGqh4BNSXo4gzYbgh?= =?us-ascii?Q?e83znPw24vAtAfpCkby4B+KxwJpaseHi5XEQGfwZ7rsyfya3nTx4yZ8wN6KH?= =?us-ascii?Q?Iv51aFYAG9QqZXto9u+9oPvr05Rznex/7z546/x2QSVlmL2qxZEcmygEW47/?= =?us-ascii?Q?VNkzqQ3SgowRUmgHp8CljBK1DtuGJHaZP35L6FzzIm3dxGkwKNFer/Wv/RL+?= =?us-ascii?Q?uY7u6VnjSSNU6AdwWO62lYtWxX0xvqdgdjnJ3ftnDu5sH1e1d5zPn39EqEN9?= =?us-ascii?Q?IPzcQwYFfNCkz13d0UHj5PwrVuRbQHs7tj3RyAcf3C9mDCu6L5iRTRvKKk/+?= =?us-ascii?Q?azRWvu7fJDlGf7IQm3NHTH6eEsSCXC4QIrHLT5n+kgg5143IleY5Qjp/dxfz?= =?us-ascii?Q?SKNiWNm64sdVg8O2YKrtiN/rRsEC+Sn9VQCDxYSJpwo7HOSoSXo3JcUFfdbo?= =?us-ascii?Q?LkZIrqij6j9LPdoxm27z6njBCOVokM5jOKbLNI+YCnsfrjwiq0OlQI34lVX8?= =?us-ascii?Q?ueyE6XW4eARzEq82vckawGF+d2b0wwGcK/HhbsbZf10T3Ce/mX/eW0uy3qG5?= =?us-ascii?Q?zJbw/BXlqMgGRTR+5L6sbSHHxFJQwxJ/+0Mye3g1Wi+pNHM6W4gUGoDSkUhF?= =?us-ascii?Q?5/JNIERttHuFsLysu+kfgpJV+jHVxJLTCj75gkD9h5EVCp6HJsO0xK6TrW/t?= =?us-ascii?Q?BJG484XMCtFbeEANr35I/A61Zo7+neRU+2qecY17Ib5wk/nvUq2UCwhAeuES?= =?us-ascii?Q?eBexxQZhbfiugMj6yrn1pxGCe7ST8t9swpgg9dnB144SPqe9A1XZEnuZ+Kvs?= =?us-ascii?Q?gxpdBjZRZ4V0j8tGmcIYqhYLdyZEyTFESjVBcinQoRqZIs3CFtZOgcGNbyld?= =?us-ascii?Q?j891QCfqvDL8Bc7D94WBYqsSR1BiWMl1A4JJnURXrdZoLGeXjHTTFNkNrz/n?= =?us-ascii?Q?6Gct4ZSG3mX3Ls5zGp+t8+35tcAAdo3ANys0OAVXsyh5kM/i/npIRrUwopZ+?= =?us-ascii?Q?RzsKgB8sqk6PjDzJWdMpDklnPikhoHPRRNWXrflqJlCouA5gVy6tYFAWKpjM?= =?us-ascii?Q?hziHjzXYSebyj5FMO2ikUDPjpi0nuizA0I3T+mDjK/IleKXRiZH/k0Dr02EM?= =?us-ascii?Q?xXFkVhEK7qQhN5sQVw8+6APR4E6FqdL/YAN4O3Nv12F59sX1TGoR7tsPGI/k?= =?us-ascii?Q?XgzVYIczzYdTfWUs7cq1qt59QCN4KvipjeOVyFN5Tk2zCYTS2Kv/e2Hwv5EO?= =?us-ascii?Q?sj3vh1j+S6Uyd7KnwXmS81Rl?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3819 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f525ba6-148b-48e0-9fdf-08d91c7a376e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +nFnfw7j59CiKBjpm5dRzHT/oE34kgOsWBsEI+Wo+MFjE0gouhzOCuihciDEmt7a7M/sj1qIqxY+dNy6+ngje4uLfbhvmQztdOtbXEf9xDprhXv+5zCd271b0+uCzbQeEcbvmb4qG85FF1NBqD3JyPvfeAAKQKCeT0Z9PVPmBClbD2SFTTiDVo+YNq8D/eXl3jKSGe0NdLV8O/BS57TTgz9JKCWcgwq1T3PgsiccOd8kJJgD9f8ae0zuici1PbAI7h1O4Mx4dT+EzU544Pi/SV12Q7xiGCrpCLudu1osX+Vg/nvFB+M2NCwPcHtwA0JJw7aoZqY/gGQ7lc5eugBb+3IWoULA/b38UB7C2b78Da7Z4kv8WIaIJjvmoAFwP+QZ6z/X00kp+Cl3yVTauOtI7r5JQhJb43yUzj+TtgQTIRx+VnkQRrbdY0APdzn7SroqhLe9SRS2aVmLhFkv7WEenx3Veedzwp4i/aKsJI14c4Kz1uIgrZJ9yTL16SourIcMb83vQJoKnuvr8caIytU//9kpZbgXC23oKImTkqRDKpNnBA3WFPIFdbgEQL4k0ia3mAMe/ED3I3yNmvyzJ0sDqtzHl+xLqsvoiW9LNJ8g0VgOEc6bAyR7nbHkmNeThxwNyiec/mrymioFxGC03a5bt+Z5Ig6VHmfIt38ebrzbK7k= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(39850400004)(396003)(346002)(376002)(36840700001)(46966006)(70586007)(36860700001)(6862004)(82310400003)(70206006)(26005)(4326008)(47076005)(356005)(81166007)(82740400003)(55016002)(16526019)(8676002)(186003)(5660300002)(6666004)(6636002)(478600001)(336012)(86362001)(8936002)(44832011)(1076003)(956004)(7696005)(2906002)(316002)(33656002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2021 17:02:43.6002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de683d33-a8e9-4b59-e513-08d91c7a4010 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2003 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_100247_470404_90B64FDF X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 19, 2021 at 01:38:55PM +0100, Mark Rutland wrote: > Our use of bad_mode() has a few rough edges: > > * AArch64 doesn't use the term "mode", and refers to "Execution > states", "Exception levels", and "Selected stack pointer". > > * We log the exception type (SYNC/IRQ/FIQ/SError), but not the actual > "mode" (though this can be deocded from the SPSR value). > > * We use bad_mode() as a second-level handler for unexpected synchronous > exceptions, where the "mode" is legitimate, but the specific exception > is not. > > * We dump the ESR value, but call this "code", and so it's not clear to > all readers that this is the ESR. > > ... and all of this can be someqhat opaque to those who aren't extremely > familiar with the code. typo: someqhat -> somewhat > > Let's make this a bit clearer by having bad_mode() log "Unhandled > ${TYPE} exception" rather than "Bad mode in ${TYPE} handler", using > "ESR" rather than "code", and having the final panic() log "Unhandled > exception" rather than "Bad mode". > > In future we'd like to log the specific architectural vector rather than > just the type of exception, so we also split the core of basd_mode() out typo: basd_mode -> bad_mode > into a helper called __panic_unhandled(), which takes the vector as a > string argument. > Reviewed-by: Joey Gouly _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel