From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DB2C47080 for ; Sun, 23 May 2021 05:13:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46B8461152 for ; Sun, 23 May 2021 05:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46B8461152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bdNeYNkRNSmhOJgKLlWqkH9BDfNRCQJg1hyRfstAe0Q=; b=hpn3z99T/9it/boHeSyPhCzDfa N95aYuI54L/fK9O3aIFQPpPifWAcLCwvqwqNaPIbQ9s2Y19k7CRj+JYuVacArY3DAlpvjrk5v4X7N 0d48HKUBXHL29jZjPtpxaxiBut5vhFWvuDEN85wirTkLBV+nktwDguC/qt4sHMFaPrHKb78dcuLRl ST7GDiqIAY08lFk2ktrt+gC+3iSQ9JguZRlbXj6zYeXnNTf06wTcodsi51/Y26W5DlfG8R0mzQpr/ YwBWG3wXngY+XA9yma5wuniUw+8XmA8vm42LoouVLbhKAtA5XEXBIg2dfJxIbRLw8LiabvWCvXOat 0wg2yAxg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkgP5-003mw5-UX; Sun, 23 May 2021 05:11:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkgP3-003mvn-7z for linux-arm-kernel@desiato.infradead.org; Sun, 23 May 2021 05:11:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4AEanU6hhy0eJ1kE3zHsF4fLqCkL8nm9enka3L4kjXQ=; b=CcMsI1SeZ1Wf3DIEt0Rp2zuoAB wHfHxnvhaXemgBrxEpq00XoFWgNEFQchsyzKtrX/7m0q6BrdF1v3ZAt4u878YFosaAdmGsiDc10Ob tTohq4yblS+kzgos6EPscw1StXBxS6UX4FgYHMdoE1mrK/Uzv9EGwDSOHn5+PM6YXBFcm6QKDESPD KY0BkmDnwuxXwTlzm0yktuCLPxKTD5XDh6McUFqWQzeRVBNgSPRULY0m4u+Lz0n66/+xWZ/tX/ytL bHlE9ZzU+OMmnp525xyMqseKnCHB2rqBv1+hSvTfkCzLBooBaCMIJJ9fUlR10mko9nDVZTSVhehos I81o5+6g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkgP0-000Jzm-PU for linux-arm-kernel@lists.infradead.org; Sun, 23 May 2021 05:11:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8EC3961175; Sun, 23 May 2021 05:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621746710; bh=JzbkgxHVP+qyg6EWN9dyTFjhQejudhV0HgHDOpVmfgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wy2jgXlWFk1fWIWJOepwyGf+2J5zWqRMda7EP+JHTL07lONVDpJCIrRXcWZTC6yeH 93MHuJQQ8eAyKSz/brX0JlAxluq4r+Y7QL4OgTT+HVoNet8rOxUVqj34FbVG+C5sy/ etuUmeleCqm3mRomjUozCT3IBan/N10W4l7DiemCs0X/v03Rnlmlp8Q6wbiTW0+rYG r2qQ7isgCpH+pp+L8OfF0EWxEHHPFw7uf27UkHbQ+MXcyN2WcJjkVhq6dYD/NiEgP1 qX8OqOjaDlZubuunxTVIullceLg2k1tCqFi1VF1hKjGN6eA44rpUTe/d5BR9R5ctAz Wn7R4FkNk9yvQ== Date: Sun, 23 May 2021 13:11:46 +0800 From: Shawn Guo To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [PATCH -next] ARM: imx: add missing clk_disable_unprepare() in imx_mmdc_remove() Message-ID: <20210523051145.GW8194@dragon> References: <20210517111523.477889-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210517111523.477889-1-yangyingliang@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_221150_873455_9762B05D X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 07:15:23PM +0800, Yang Yingliang wrote: > clock source is prepared and enabled by clk_prepare_enable() > in probe function, but no disable or unprepare in remove. > > Fixes: 9454a0caff6a ("ARM: imx: add mmdc ipg clock operation for mmdc") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > arch/arm/mach-imx/mmdc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c > index 0dfd0ae7a63d..7d87fa8c70a9 100644 > --- a/arch/arm/mach-imx/mmdc.c > +++ b/arch/arm/mach-imx/mmdc.c > @@ -77,6 +77,7 @@ static const struct of_device_id imx_mmdc_dt_ids[] = { > { /* sentinel */ } > }; > > +struct clk *mmdc_ipg_clk; Missing static. But an even better change should be putting it into struct mmdc_pmu, I guess. Shawn > #ifdef CONFIG_PERF_EVENTS > > static enum cpuhp_state cpuhp_mmdc_state; > @@ -463,6 +464,7 @@ static int imx_mmdc_remove(struct platform_device *pdev) > cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node); > perf_pmu_unregister(&pmu_mmdc->pmu); > kfree(pmu_mmdc); > + clk_disable_unprepare(mmdc_ipg_clk); > return 0; > } > > @@ -536,7 +538,6 @@ static int imx_mmdc_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > void __iomem *mmdc_base, *reg; > - struct clk *mmdc_ipg_clk; > u32 val; > int err; > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel