From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1429CC2B9F7 for ; Mon, 24 May 2021 19:27:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF49613F7 for ; Mon, 24 May 2021 19:27:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF49613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WoUGkHiX5nlL1KFGafmQ5UkvjKcIuZUTTukLsix6oE4=; b=amhzQIHajVR8Dv XSMr+40vlZRBqG3sDLV2xn1jOLQNws2CQ/jI4ZGtZeB/KZSjK22B16YNOYWCtZj6qPcmESXvEUeSF V9LstbomFHFutyiFDnjfFNpctrDWmFrH39nCF7F58mArUYAM2MUIMyhkw0dzhi4D/7LOPoWGjviIw QtC0a6NLnski1gQEdqqNj7VnS2l24SMBtsSWFvbo2mtfe7SBlERlGsKoMcixQ9gBIGq4eMWvFxoYt NQOl3Tt2uuhkvc0EiSnWyHL5zk7O56chNW51IN44xY6tOX5TjlggvN4pvf0ZgCIK+KH0/Ub4lhy2B dD8f7VQ09au/1DH+NSuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llGC9-001exZ-Hr; Mon, 24 May 2021 19:24:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ll8Wx-000rZe-H2 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 11:13:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C05331B; Mon, 24 May 2021 04:13:51 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.38.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C14E3F719; Mon, 24 May 2021 04:13:49 -0700 (PDT) Date: Mon, 24 May 2021 12:13:46 +0100 From: Mark Rutland To: Marco Elver Cc: Jisheng Zhang , Catalin Marinas , Will Deacon , Alexander Potapenko , Linux ARM , LKML Subject: Re: [PATCH] arm64: mm: don't use CON and BLK mapping if KFENCE is enabled Message-ID: <20210524111346.GE1040@C02TD0UTHF1T.local> References: <20210524153659.58a707a9@xhacker.debian> <20210524103740.GD1040@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_041355_686054_B06D92D1 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 24, 2021 at 12:43:56PM +0200, Marco Elver wrote: > On Mon, 24 May 2021 at 12:37, Mark Rutland wrote: > > > > On Mon, May 24, 2021 at 03:36:59PM +0800, Jisheng Zhang wrote: > > > Fix below warning if KFENCE=y but RODATA_FULL=n: > > > > > > [ 0.000000] ------------[ cut here ]------------ > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at mm/memory.c:2462 apply_to_pmd_range+0xec/0x190 > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.13.0-rc1+ #10 > > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > > [ 0.000000] pc : apply_to_pmd_range+0xec/0x190 > > > [ 0.000000] lr : __apply_to_page_range+0x94/0x170 > > > [ 0.000000] sp : ffffffc010573e20 > > > [ 0.000000] x29: ffffffc010573e20 x28: ffffff801f400000 x27: ffffff801f401000 > > > [ 0.000000] x26: 0000000000000001 x25: ffffff801f400fff x24: ffffffc010573f28 > > > [ 0.000000] x23: ffffffc01002b710 x22: ffffffc0105fa450 x21: ffffffc010573ee4 > > > [ 0.000000] x20: ffffff801fffb7d0 x19: ffffff801f401000 x18: 00000000fffffffe > > > [ 0.000000] x17: 000000000000003f x16: 000000000000000a x15: ffffffc01060b940 > > > [ 0.000000] x14: 0000000000000000 x13: 0098968000000000 x12: 0000000098968000 > > > [ 0.000000] x11: 0000000000000000 x10: 0000000098968000 x9 : 0000000000000001 > > > [ 0.000000] x8 : 0000000000000000 x7 : ffffffc010573ee4 x6 : 0000000000000001 > > > [ 0.000000] x5 : ffffffc010573f28 x4 : ffffffc01002b710 x3 : 0000000040000000 > > > [ 0.000000] x2 : ffffff801f5fffff x1 : 0000000000000001 x0 : 007800005f400705 > > > [ 0.000000] Call trace: > > > [ 0.000000] apply_to_pmd_range+0xec/0x190 > > > [ 0.000000] __apply_to_page_range+0x94/0x170 > > > [ 0.000000] apply_to_page_range+0x10/0x20 > > > [ 0.000000] __change_memory_common+0x50/0xdc > > > [ 0.000000] set_memory_valid+0x30/0x40 > > > [ 0.000000] kfence_init_pool+0x9c/0x16c > > > [ 0.000000] kfence_init+0x20/0x98 > > > [ 0.000000] start_kernel+0x284/0x3f8 > > > > > > Fixes: 840b23986344 ("arm64, kfence: enable KFENCE for ARM64") > > > Signed-off-by: Jisheng Zhang > > > > It would be good if the commit message could explain the problem more > > thoroughly, e.g. > > > > | When we added KFENCE support for arm64, we intended that it would > > | force the entire linear map to be mapped at page granularity, but we > > | only enforced this in arch_add_memory() and not in map_mem(), so > > | memory mapped at boot time can be mapped at a larger granularity. > > | > > | When booting a kernel with KFENCE=y and RODATA_FULL=n, this results in > > | the following WARNING at boot: > > | > > | < warning here > > > > > With that: > > > > Acked-by: Mark Rutland > > We also need "Cc: stable@vger.kernel.org", right? That would be a good idea, yes. I can't recall whether "Fixes" alone is intended to be sufficient or not to trigger a backport. Mark. > Acked-by: Marco Elver > > Thank you both! > > -- Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel