From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F11C47088 for ; Wed, 26 May 2021 12:33:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F4C861378 for ; Wed, 26 May 2021 12:33:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F4C861378 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FL75cPNRYUkEzgC5pi2voBpfgh+vy1ADiYWxAHvcrhI=; b=EVvnS/PzQ5Y8hK M251Lrksi5x15U9oy60h6/Gi5vKrERxbc2dcLnBAJuNZIxb/7ppzMb08xyRdBWAhawRY4vf8JTBEC rSqj97xRIKk0udzfsbuJ7YnPA3e59nfxXXoxfpCs7ZcezoZo8KLeQshA7Diew8tsnByqeAk8fvlYc gT4Os6hPqTRNMtuKzdptwOZKEg7vmhRG7/WYpPYhaXz/i/UN5ubs9tMJTvoXMF/RbPeewAjS97lX2 vMGzeOUninJb1ohB/In/RPVBYvT5twcejLz4/tMRnb3cDdq1bUXY1H9aKzKJZZ34BLJo9DF+FjtpF cWJfQ6uv/UCP9YHD5kJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llshC-00DzqE-KW; Wed, 26 May 2021 12:31:35 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llqSF-00D5qm-3A for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 10:08:00 +0000 Received: by mail-pj1-x102f.google.com with SMTP id q6so523808pjj.2 for ; Wed, 26 May 2021 03:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iPLF4+a0+7osNgqIih0t63HrK/7cIyUQjVdMCaByTx4=; b=McT6WvIIhYAITiYiVmvf9diDdxUIeXVUj80svSmWGZkKzERBTUuSJICT+1aesu0rp6 lr80GxhsP2CYf5+Lw6jVHyvsQFNY8zWtYKk8qr+J2a08R8+xAAAhuyNthUrYDEUHSLar bZK+isSOTBLoqPBpXTUSRBlE4gZRemVynfwxuq7PqcQ6EqzMDe+0asg3YL5NbA3tHVAw AK/trgfEAqzrGO5b68L32EIpaomzB2jSVCI1OFzs5WBBx/zAOb+DdAk9itkr711JC7eP 4EVN6K6LceUbBdPd7hJMMCIuVTRgEF5sUXjwoS113it4WpU2qgqCokQ4cO60j/aT0bce lzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iPLF4+a0+7osNgqIih0t63HrK/7cIyUQjVdMCaByTx4=; b=rbuR+0Kh1HFWZHZvbufva0UJ06G0ImtayJRuLJ1JB7YizqezMo//FxZ5g8wd71U5Zs WNCcCOJEtHc3z6ur+J2oynM9fZLvlB7Q73gejOkvX8AHEi6OfE5OlBIiYYQWElmt542K 2GMLAqptFYclcoJLke3pL6QDQqxf9ovJPkzqEhT1AiYPUT1vvU2RqT5Oqc1bVksaO/ta 3h9Z+LEQrOTLNT5xLjh/G23lwbgqpp91DHfWXmel3NYKXhKHvqT9wMIKya47lSd9fxiU h/8LSL38RNJBigoDe8VGa9SO7C+s7TI7yJAuCkPKS/+3UgRYL1sBpmaqeKoLsPaCp2ML UV9Q== X-Gm-Message-State: AOAM533tkD2ffRR01pMxwLZHrpE3bfVs/6NFSfymiveENfed+qcdsE8S +NUmM9XM93bMPPlMmH0skGAv X-Google-Smtp-Source: ABdhPJxzbNRZCM/TUHJmvxFI6Zega3duBzCjyNdGs7pP8S8t49WpLEQQCp9uUr72qRdzGtzi1G/axA== X-Received: by 2002:a17:90a:8902:: with SMTP id u2mr35505244pjn.143.1622023676967; Wed, 26 May 2021 03:07:56 -0700 (PDT) Received: from work ([120.138.12.4]) by smtp.gmail.com with ESMTPSA id 184sm14858556pfv.38.2021.05.26.03.07.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 May 2021 03:07:55 -0700 (PDT) Date: Wed, 26 May 2021 15:37:43 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210526100719.GC10723@work> References: <973b08fe414321ba4ade096a4917cadc2013426e.1615221459.git.cristian.ciocaltea@gmail.com> <20210316035845.GB1798@thinkpad> <20210316181437.GB1111731@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316181437.GB1111731@BV030612LT> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_030759_183546_4F4D8BCF X-CRM114-Status: GOOD ( 26.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 08:14:37PM +0200, Cristian Ciocaltea wrote: > Hi Mani, > > Thanks for reviewing this patch series! > > On Tue, Mar 16, 2021 at 09:28:45AM +0530, Manivannan Sadhasivam wrote: > > On Mon, Mar 08, 2021 at 07:18:27PM +0200, Cristian Ciocaltea wrote: > > > Drop the unsupported entries in the factor table used for the SD[0-2] > > > clocks definitions on the Actions Semi Owl S500 SoC. > > > > > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > > > Signed-off-by: Cristian Ciocaltea > > > --- > > > drivers/clk/actions/owl-s500.c | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > > > index 75b7186185b0..69cd959205f5 100644 > > > --- a/drivers/clk/actions/owl-s500.c > > > +++ b/drivers/clk/actions/owl-s500.c > > > @@ -127,8 +127,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > > > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > > > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > > > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > > > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > > [...] > This is basically what gets translated to sd_factor_table and I removed > the extra entries 25..31. Actually I also dropped the 24th one, since > that would give us an odd number of items, although I'm not quite sure > this is a bug in the xapp-le code or the HW is really supposed to work > like that. > In my datasheet I can see the factor values till 24. So let's remove the entries from 25-31. Thanks, Mani > Kind regards, > Cristi > > > Thanks, > > Mani > > > > > > > > /* bit8: /128 */ > > > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > > > @@ -137,8 +135,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > > > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > > > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > > > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > > > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > > > { 0, 0, 0 }, > > > }; > > > > > > -- > > > 2.30.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel