From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7530FC47089 for ; Wed, 26 May 2021 17:20:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 417C0613C3 for ; Wed, 26 May 2021 17:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 417C0613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e4TnxcbHCfDzW0Xg8yNxfRuGu2XAxPC1gWlGj5fzqHc=; b=2czAl+BPnUJLbg jQOTZGZeoWbOOuTDEkk5di3dud2C7eJOYvl60+m7tzf3p5FBjF/i3hr6pY+7siCgqyHM2jT+MPunF fI2nQN8C4E6LeG6agRBz1JQlltTxo+Mag7/s8Y1Cd81Qpisv4LKhtrTgr6oCvhek7kHm0fBDfI1vd C7BK53fLa1hyfW7aRUUxmCgpdrmqZdtrPh9y93uKNCbxREp1lUbXGV4mtyGTiyEDMXla1b2eZxxUU t9sTVRtyVqOaWFG+o3rdWjcRH3v1pZHT4d7JTmNDA5s0JIeUC9NY01aMQXqzjYqLlCHyarb5gtAMi jJdAgxqkfN99PTicFCjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llx98-00G2Jm-LH; Wed, 26 May 2021 17:16:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llw4L-00FbvI-Qg for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 16:07:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E5806613D4; Wed, 26 May 2021 16:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622045261; bh=j6Odz9vOMSnIs4wWXntwTwZIr6CshcRW2BHOShPDJPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rUgCR+uaaXALcZoWRgnnPpHPi975FoacDvb1MOnemnXtnzIJw6OoodjAJogz+f5Hr LCGMkt0nePk8Xg4xhmvlzLQuPhuTKQM9nKSUn5tk1XvRbfM20V9tFNWQiS30yKmN0v Qs0sM8xsdz0Y697b2/XcH+a/MuIqb7pDKNgNU3Oa9SKJREzdifQfQLrFV6bmUKXh8h 4UaVu3v1+B+ii8daplbddOL8mGcXICalVn17kYd0tbISr2zvid2Oerh51XYFu6mPk/ zB3UehjCy0WLcUY63OG/VbtG5QJ6eQx+iauqd6obdjMUBNnBVEkrK7MK1kIVxFhHM+ /VhhB7JDtKP8g== Date: Wed, 26 May 2021 17:07:31 +0100 From: Will Deacon To: Peter Zijlstra Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , kernel-team@android.com, Li Zefan Subject: Re: [PATCH v7 08/22] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Message-ID: <20210526160730.GC19691@willie-the-truck> References: <20210525151432.16875-1-will@kernel.org> <20210525151432.16875-9-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_090741_943675_32CCFC28 X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 05:02:20PM +0200, Peter Zijlstra wrote: > On Tue, May 25, 2021 at 04:14:18PM +0100, Will Deacon wrote: > > void cpuset_cpus_allowed_fallback(struct task_struct *tsk) > > { > > + const struct cpumask *cs_mask; > > + const struct cpumask *possible_mask = task_cpu_possible_mask(tsk); > > + > > rcu_read_lock(); > > + cs_mask = task_cs(tsk)->cpus_allowed; > > + > > + if (!is_in_v2_mode() || !cpumask_subset(cs_mask, possible_mask)) > > + goto unlock; /* select_fallback_rq will try harder */ > > + > > + do_set_cpus_allowed(tsk, cs_mask); > > +unlock: > > if (is_in_v2_mode() && cpumask_subset(cs_mask, possible_mask)) > do_set_cpus_allowed(tsk, cs_mask); > > perhaps? Absolutely. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel