From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AE6C47082 for ; Wed, 26 May 2021 20:03:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C57EF61440 for ; Wed, 26 May 2021 20:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C57EF61440 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s09yqJO40hBVFAVG2ubnbTEkdVUK7RE2YWj9MQ3uK/4=; b=aAbRdVwXmqRFVA Fdcf2g2/YGbcceMKZERZTTDPAwx4RUh4gM3tpKhAUSgBR3GNwOJsxXtOhizCL6Vc80EjhTUeHjsgR Nn9gslhOBXrGpmaG18SESP7ANa9XufrkJVwZRN++5SK6rYRkBTIsvJ7mCKYZNHUsD+UUg7tE9OWFo tHcG7eQIJ6SILr3wTiCnZ30+JY2s99XppHn+vPniKgBdpVoCLbAVmLbAxZ5kfb90cyPLFe9GzE2Mp 8Yz8MQ3h5LhjLZY9hDveoX82G+RqU6aWkaAwtJMZ6hQODNtEWxdqiu24x2fu9JN2uaGo5w+UFuPrb brsOUTOXYu1EvRFmjrLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llzhO-00HCea-Lv; Wed, 26 May 2021 20:00:15 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llycx-00GiJm-8c for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 18:51:36 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14QIpXQr023283; Wed, 26 May 2021 13:51:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1622055093; bh=BKwkIfBERwTZedUQYKugmdcf1E8hKbfekE2TBc1GF3I=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=swLeJDJ1yxuHYqIOz7Tmqd9cplo5eZGnfVP0OBDfEhQfZbLskVubqEX964v5/hjoi dQOYmmNCpqdgIaXPny9JIms7YxczG5YKFBg+/6nxWMdWgLdyMwkaw7R8FQAFH8xbPM 8BbXGhc4MQf81MEDH2hQzAtBR1Z1qpVRDNEQYd58= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14QIpXoN011162 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 May 2021 13:51:33 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 26 May 2021 13:51:33 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 26 May 2021 13:51:33 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14QIpXbf064439; Wed, 26 May 2021 13:51:33 -0500 Date: Wed, 26 May 2021 13:51:33 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Tero Kristo , Rob Herring , , , , Lokesh Vutla Subject: Re: [PATCH v3 2/5] arm64: dts: ti: k3-am64-main: Add PCIe DT node Message-ID: <20210526185133.sm2iqqpequz3mmvq@crafty> References: <20210526142921.12127-1-kishon@ti.com> <20210526142921.12127-3-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526142921.12127-3-kishon@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_115135_429261_282B1C90 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19:59-20210526, Kishon Vijay Abraham I wrote: > AM64 has one PCIe instance which can be configured in either > host mode (RC) or device mode (EP). Add PCIe DT node for host > mode and device mode here. > > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 46 ++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index a67f10406a8e..9c77f7da5d28 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -728,4 +728,50 @@ > #clock-cells = <1>; > }; > }; > + > + pcie0_rc: pcie@f102000 { > + compatible = "ti,am64-pcie-host", "ti,j721e-pcie-host"; > + reg = <0x00 0x0f102000 0x00 0x1000>, > + <0x00 0x0f100000 0x00 0x400>, > + <0x00 0x0d000000 0x00 0x00800000>, > + <0x00 0x68000000 0x00 0x00001000>; > + reg-names = "intd_cfg", "user_cfg", "reg", "cfg"; [...] > + > + pcie0_ep: pcie-ep@f102000 { Hmm... Warning (unique_unit_address): /bus@f4000/pcie@f102000: duplicate unit-address (also used in node /bus@f4000/pcie-ep@f102000) we could pick reg for pcie-ep for node address, instead of intd_cfg address? OR, does that mess something else up? > + compatible = "ti,am64-pcie-ep", "ti,j721e-pcie-ep"; > + reg = <0x00 0x0f102000 0x00 0x1000>, > + <0x00 0x0f100000 0x00 0x400>, > + <0x00 0x0d000000 0x00 0x00800000>, > + <0x00 0x68000000 0x00 0x08000000>; [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel