From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE765C47089 for ; Thu, 27 May 2021 10:55:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E720613AA for ; Thu, 27 May 2021 10:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E720613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q9r3KZdgpv79EkLfnze28OHDkuU41bDB0JpTRrdMJBo=; b=fOH4eY9YJex2pz FD+4+rbbuneRysJirUpOV4CnLaC/e3JAII68cj3rjhanrBez4xJot+EzNnvWpu3bCpuJTdpRuQam9 NzKwY/BveGbjkFZUJzvjW+y3xgxZP1ZkicVYOtTj+GJMlydFCs2LFMJMf73twCChnJbK7w71IW0WI riR+doSqSSh7e8Nn0WPtShIXUZWfnCWxKufJ7KxdidLRZmfd/tS500Zr2W/C6tyFd76xduEogEt0u VjM++5vloxY3wJwjx3gl9P0dx+igS7ujslYSNO2ll7trCsQhSAFMMI9vb7vrNg/CDzDvdAiEc2Dcc CWdd/EaLcQr2vBWZHsEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmDe7-004zMX-VZ; Thu, 27 May 2021 10:53:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmDe2-004zKw-H6 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 10:53:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B831913A1; Thu, 27 May 2021 03:53:41 -0700 (PDT) Received: from bogus (unknown [10.57.70.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FE3D3F73D; Thu, 27 May 2021 03:53:39 -0700 (PDT) Date: Thu, 27 May 2021 11:53:34 +0100 From: Sudeep Holla To: Etienne Carriere Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Cristian Marussi , Florian Fainelli , Jim Quinlan , Peter Hilber Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema Message-ID: <20210527105334.ouz3pgth7whmqxzl@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-9-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_035342_695631_461EAB90 X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 27, 2021 at 08:37:58AM +0200, Etienne Carriere wrote: > Hello Sudeep, > > On Wed, 26 May 2021 at 20:28, Sudeep Holla wrote: > > > > Convert the old text format binding for System Control and Management Interface > > (SCMI) Message Protocol into the new and shiny YAML format. > > > > Cc: Rob Herring > > Cc: Cristian Marussi > > Cc: Florian Fainelli > > Cc: Jim Quinlan > > Cc: Etienne Carriere > > Cc: Peter Hilber > > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/arm,scmi.txt | 224 --------------- > > .../bindings/firmware/arm,scmi.yaml | 270 ++++++++++++++++++ > > 2 files changed, 270 insertions(+), 224 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt > > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > Hi, > > > > I have converted all the bindings except the below regulator part of the > > binding. This needs to be addressed before merging ofcourse. Just posting > > the remaining changes to get feedback and also ask suggestion for the below: > > > > scmi_voltage: protocol@17 { > > reg = <0x17>; > > regulators { > > regulator_devX: regulator@0 { > > reg = <0x0>; > > regulator-max-microvolt = <3300000>; > > }; > > > > regulator_devY: regulator@9 { > > reg = <0x9>; > > regulator-min-microvolt = <500000>; > > regulator-max-microvolt = <4200000>; > > }; > > }; > > }; > > > > I will reply with things I have tried separately to avoid confusion with this > > the patch here. > > Few minor typos, but LGTM for this part, aside a comment on SCMI > version reference. > > Both old and new descriptions refer to SCMI v1.0 (DEN0056A) in both > description text and URL reference. > Not mentioning the version would age better. From the implementation, > versions are already well managed at discovery and enumeration so we > don't expect regressions due to spec version. > > At: > - the SCMI as described in ARM document number ARM DEN 0056A ("ARM > System Control > + the SCMI as described in ARM document number ARM DEN 0056 ("ARM > System Control > and at: > - [0] http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/index.html > + [0] https://developer.arm.com/documentation/den0056/latest > Good point, most of the recent specs, I am referring to latest. This predates that practice. I will update this and fix typos pointed out. Thanks for taking a look at this. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel