From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9995CC4707F for ; Thu, 27 May 2021 13:40:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58EC1613AC for ; Thu, 27 May 2021 13:40:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58EC1613AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7jJBVHRI3Mf9gKVSgkokHgvGyptU0arVsvo6HE9KLPU=; b=3P95JH1nS+zkjx L1dtnvyetAQdsz4j0uomFBySE/KgoyOKzkz8Pm4jUnQEqN82hU8m0V8lvVNuMprew79j16/oDwsQw zKSPv8wgJ6aeiDK+HivYDoPTtOwXmynNrhiUzZVAl1pG9oyWyVza87YCnbY2AqiKkWUHw2frIZu9n soUDSsH5jNfY8EynvGkKLwW6a77Q0peMUX3thZqz+muImziDlIfn6b2u2biwYRSuBX1X9myIZiQH3 F3gaa+xsxsVhyBZLdQqa9xh7XJ/a/gJEl1oUkZJbFrmaiO3XYwNycXB2Pr5+6lq8ikK0GMUco6MIu AtLOY2Y9PNcIgwNcD+mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmGD8-006LDe-IF; Thu, 27 May 2021 13:38:08 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmG30-006GHa-A1; Thu, 27 May 2021 13:27:40 +0000 Received: by mail-ej1-x62d.google.com with SMTP id l1so77064ejb.6; Thu, 27 May 2021 06:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ppiS+kUHEmNMA/rfiFdU2fGCovIYKgvsvBDMkMx1l8g=; b=N1ld5ltqPVFeWqGp+B9xVK3nRLjNtJfBEO3iq55ubS3wXZjWH65JSzfQL20TnWsEwg Qw1WwKn39XWjuFxzRXL6jAu6RJJymed0cbr5GjwRlZABwYYffYfVrlXuyYLQAZENPvJD CiPKtinmr7xwogY5ChiR2cMTCrW1G5C0ZSTGtSDF/L88GmokztHKdFSzX/fU+fzu7HiM sodB2E25l3ZqtpXhJDpcOv/zm/vIH2TWjY/dQECaj/IAVweEe4lLx+KO1IxKYs0K8pns jlVj9lmjcZM5OJL0BLeF6bqI/nDvTt5VCpb7MovQHrGafqNpIqd4388FoH9ucvjv0JOq ylsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ppiS+kUHEmNMA/rfiFdU2fGCovIYKgvsvBDMkMx1l8g=; b=KnLuX4apQOIJVFjqZy79ESZKijQm4pLO0qOj8G+inlfow0CyQyUMl5FDqZGvyeYFq1 dMrKa41yET/m95lEzVKedB1B4T+QIV6LrTzT1Kp8WyiHg9MHaN6G2ZKyi+QhD5Om5upz vbRENeW9baD78G396yWiSx/B33ll4/yLugdAtn+JbEihuqmQtDdaJENS3R7lNiZKkYwT Z+Pzq4A/6/JUnH+fJw4Rbkaa2VFDki/ZNmp7oH9fa6B9cGZCDgdG9eIgqDqWEdE9bZd6 i9/yWKtEH69BSWWWY3EgQlfKMHcZYOZYUbNw9cp2FcZ9B8Ke/rQLnb3GhBA5CyCLN9s+ wezg== X-Gm-Message-State: AOAM530zeveolafuv5ArMz0WnVsLQv141ybdiy+4mlONOPVAq/USRPOW pU+/kZYznXeEPYi6RyuhaQ4= X-Google-Smtp-Source: ABdhPJwHz+PO0bxmokSeO7kLTi0+JZ/h/GLDeWjzuo/3J0bHnA1plBUGwNC8SjCRQyMwcMX/Beskxw== X-Received: by 2002:a17:906:90c9:: with SMTP id v9mr3813868ejw.102.1622122056454; Thu, 27 May 2021 06:27:36 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id p25sm1011450eja.35.2021.05.27.06.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 06:27:35 -0700 (PDT) Date: Thu, 27 May 2021 16:27:33 +0300 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210527132733.GA1300160@BV030612LT> References: <973b08fe414321ba4ade096a4917cadc2013426e.1615221459.git.cristian.ciocaltea@gmail.com> <20210316035845.GB1798@thinkpad> <20210316181437.GB1111731@BV030612LT> <20210526100719.GC10723@work> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526100719.GC10723@work> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_062738_409071_C386143B X-CRM114-Status: GOOD ( 27.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 03:37:43PM +0530, Manivannan Sadhasivam wrote: > On Tue, Mar 16, 2021 at 08:14:37PM +0200, Cristian Ciocaltea wrote: > > Hi Mani, > > > > Thanks for reviewing this patch series! > > > > On Tue, Mar 16, 2021 at 09:28:45AM +0530, Manivannan Sadhasivam wrote: > > > On Mon, Mar 08, 2021 at 07:18:27PM +0200, Cristian Ciocaltea wrote: > > > > Drop the unsupported entries in the factor table used for the SD[0-2] > > > > clocks definitions on the Actions Semi Owl S500 SoC. > > > > > > > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > > > > Signed-off-by: Cristian Ciocaltea > > > > --- > > > > drivers/clk/actions/owl-s500.c | 4 ---- > > > > 1 file changed, 4 deletions(-) > > > > > > > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > > > > index 75b7186185b0..69cd959205f5 100644 > > > > --- a/drivers/clk/actions/owl-s500.c > > > > +++ b/drivers/clk/actions/owl-s500.c > > > > @@ -127,8 +127,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > > > > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > > > > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > > > > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > > > > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > > > > > [...] > > > This is basically what gets translated to sd_factor_table and I removed > > the extra entries 25..31. Actually I also dropped the 24th one, since > > that would give us an odd number of items, although I'm not quite sure > > this is a bug in the xapp-le code or the HW is really supposed to work > > like that. > > > > In my datasheet I can see the factor values till 24. So let's remove the > entries from 25-31. I got an updated datasheet and I confirm 24 is a valid selector. Applied the correction in v2: https://lore.kernel.org/lkml/cover.1622119892.git.cristian.ciocaltea@gmail.com/ Thanks, Cristi > Thanks, > Mani > > > Kind regards, > > Cristi > > > > > Thanks, > > > Mani > > > > > > > > > > > /* bit8: /128 */ > > > > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > > > > @@ -137,8 +135,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > > > > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > > > > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > > > > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > > > > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > > > > { 0, 0, 0 }, > > > > }; > > > > > > > > -- > > > > 2.30.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel