From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C62C47089 for ; Thu, 27 May 2021 17:23:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76F85613BE for ; Thu, 27 May 2021 17:23:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76F85613BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0bkPIgJ7+XIlVJ1YJsav2DPCZ+Yz/WLCjNo6Ml7VL7A=; b=RUMMRLVSK7tJ+D yGSuNsuZG1wwT4d9JnS9V/VTHPlvWwk5TQfg9A9iHtHE/JEWtopWFLzPVpHmo3emQLws5EfFTuZF8 3ZR+d0TA2YdT5vEL3vLfnMjXDaieozK+MYhlCBhVuag9qBRknpFIr02RBFEPvym6EWSxJR3c26Jzv dAdA7gTP9f0OhJVrcQFXu6XxpKlunTVosAZPRq1/cFLq8kTMoYRGshtjfdSiIORhKuoxTroRtAg5t wy7naCaWqF0p0hLYfTO188gGesw1nIv4b3APUv/mft3k+ewya3XbdcZ6AX5/EBpSfOCsvf0lGH2Mu zSMkDSEKznNxKPch2Xcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmJhA-0082Mj-R9; Thu, 27 May 2021 17:21:22 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmIIN-007MuX-V4 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 15:51:41 +0000 Received: by mail-pl1-x634.google.com with SMTP id t21so188735plo.2 for ; Thu, 27 May 2021 08:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P8n+j10CtxBhN58oDikgqY5q7G+Pum8G2KPAGFOMoQM=; b=jPc88E/Li2I3/MCp6PbTsfXs8TtZnXLmb8LdXdkTQ5vTSK/O4NfrBhYAFsH6149K2C 8Dzg7ZUxwJefPaH+g3ruPpkiFLF7d3xvk3kSUjBx4L00M574OXpCIFIg9slizleb/XLf 9Nu2PDmHJhXalDOOitKfMg4eR3sUk6Ao4FitbV3Nu+AQ6iEIkmtx2NhuQtH2osPxT+DY qtWbLsybPkM6QNJoU4rd+zYP9JwSBdUkB3omFDtvv/EDYlqjpsX0pHzOmWz4AiV6Honq L+HNC5YcOh5ieRsQ1ORuethWH/0SYGZHCCfEYziFX+45jC9ER0tmQBqm4qaC2LuLH683 Erxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P8n+j10CtxBhN58oDikgqY5q7G+Pum8G2KPAGFOMoQM=; b=dRBu7YHOp67+9c3p8ZDDAh9n6DW4BvMFt9uRslWwVFDlCNH1OE3siG/mCjSZQp5R3B hY8Vwi+3Jd1z6JLVTGkrqsDuWoysIAVswOBp8wffEATBCGArZJXm2DRHW6rn0wRsWlSY GLVZYfYyyg8KqIgRDHGHmQ2VJP9NVRZ2Arl1fZp+3/WT2H9/Vrev3gh5a0QSTkTiE2uT 7gJSSKYEfIYl1Ow6XiUE8yxhWJbr0rN13LNZHyuNHD68nHmx8g6qPn2UhVOGIDyuzkes bEA3E8bhPpxexufCxZBi0iBoxvPoG5j88B8fRlsRmBYDIIXvfl5mHI0WVAMOTabIDKv5 oGvw== X-Gm-Message-State: AOAM532JV3tqoY6e119cJympDYPgYvL0uSZ/U2jBrNfLx7TyRK0TwcAT tpS+AF0rsI47s8/yVqaRhihLEw== X-Google-Smtp-Source: ABdhPJwoNPGZY0cleeBw9UHOnt01xQnmJp/s6zYtjQoV9W6cTuQL+NMaDUZgw+qbaQLY1O6LN3+TMw== X-Received: by 2002:a17:902:7c0b:b029:ff:5396:2edd with SMTP id x11-20020a1709027c0bb02900ff53962eddmr1462767pll.79.1622130698590; Thu, 27 May 2021 08:51:38 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id gt23sm2306226pjb.13.2021.05.27.08.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 08:51:37 -0700 (PDT) Date: Thu, 27 May 2021 09:51:35 -0600 From: Mathieu Poirier To: Jeremy Linton Cc: coresight@lists.linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Propagate symlink failure Message-ID: <20210527155135.GA1297106@xps15> References: <20210526204042.2681700-1-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526204042.2681700-1-jeremy.linton@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_085140_050551_84DADAAE X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 03:40:42PM -0500, Jeremy Linton wrote: > If the symlink is unable to be created, the driver goes > ahead and continues device creation. Instead lets propagate > the failure, and fail the probe. > > Signed-off-by: Jeremy Linton > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 6c68d34d956e..2dc4b0110442 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev) > } > } > > - return 0; > + return ret; I have applied your patch. Thanks, Mathieu > } > > static int coresight_remove_match(struct device *dev, void *data) > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel