From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19490C47089 for ; Thu, 27 May 2021 20:35:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C57B6613E2 for ; Thu, 27 May 2021 20:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C57B6613E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z09I19FDOx6T3eAiGCZbl1I2QqJ/WyaVrJwRsOZwIvM=; b=nplbYkzQn0OYc4 FO82gHzMWnTDSLvmF+LHNXWXG27zxex/YiCnTFbvicLoEG7Tn7jo/iepk6olpVxZmX51O5b6RW7H7 CgYRO61zk2pb7H7hZF2fLqKyTv30oUYLHFbXcofZsJp9H/4QBwPrMHrP/pWUGhp1aMVfva9h8z/8Q KhtBJP0v4Rpl1ku+MJnn96hpNJ7ReWWQHwF9KdQ5N/ly3GGfUsYgXz/dF/c4C5JDGAPbyJi2fu7tQ Oi+ELx7N4XACQC2PSijGftx9upDv9+RuWQlPsIh41brYFCMU2jZoc77VKMW28j02QZdNh6318d3B7 xt7f33eed4mpuXNEEzwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmMhC-009MGi-Rm; Thu, 27 May 2021 20:33:35 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmMh8-009MF2-V8 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 20:33:32 +0000 Received: by mail-ot1-f50.google.com with SMTP id t10-20020a05683022eab0290304ed8bc759so1427442otc.12 for ; Thu, 27 May 2021 13:33:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=neTM7k0BTcCRqNpLEncEiA8vBVxatHM1/pWJWEun4K4=; b=ce0mGuoUDN81H0+ogm5oTchBzfBKglOi4Sa8U8q6YjK48ucoFEgMjjWH23e9KSrHB8 mjvMWOzLExM579XQ3f2feY4rXhKr5Bc8CJowRMquf3rCXQyeoYLMdbMJnBhs/jci/v45 hFuHTLZDme9+uwI1uyklBuk7K6IyWc7oJRSV9L6oY0B0/oKnPY5zdtb/fCEB5BTEslJI jacL8WlQVN3OJcdCa0QYGvUu62E8gFDxcZI6YsHTGSjAhLym+rgW2lZXjmwbr5zdMEEt EtqJgu55737yKWw+9O6nFA+fSo7kpkZYuV94kqHN2xW+ghh1QBbhtsF5CpJZDHx7AiNy gfzQ== X-Gm-Message-State: AOAM533cHBZ4LkKDg1a08YdmQW1IsbMYJ9C64tWwp2cYdKB8pMNYw0Q+ u12ECVi7u/kh9QjVAu17KPsr5Xlc6A== X-Google-Smtp-Source: ABdhPJyzvsvKu5axANduODYLrdJqsZZVFn8s3e5fGfoh1h8RnB95y+CJ8MP236uMdNYTABB/IkXifA== X-Received: by 2002:a05:6830:1f52:: with SMTP id u18mr4148044oth.298.1622147610162; Thu, 27 May 2021 13:33:30 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x5sm683678otg.76.2021.05.27.13.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 13:33:29 -0700 (PDT) Received: (nullmailer pid 1366788 invoked by uid 1000); Thu, 27 May 2021 20:33:27 -0000 Date: Thu, 27 May 2021 15:33:27 -0500 From: Rob Herring To: Sudeep Holla Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet Subject: Re: [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: Convert to json schema Message-ID: <20210527203327.GA1356362@robh.at.kernel.org> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-8-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210526182807.548118-8-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_133331_037855_3B97319F X-CRM114-Status: GOOD ( 20.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 07:28:06PM +0100, Sudeep Holla wrote: > Convert/merge the existing text format SCPI binding additions for > amlogic,scpi into the common arm,scpi json scheme. > > Couple of things to note: > "amlogic,meson-gxbb-scpi" is always used with "arm,scpi-pre-1.0" > hence no need for separate "arm,scpi-pre-1.0" standalone entry and > "amlogic,meson-gxbb-scpi-sensors" is used always with "arm,scpi-sensors" > > Cc: Rob Herring > Cc: Kevin Hilman > Cc: Neil Armstrong > Cc: Jerome Brunet > Signed-off-by: Sudeep Holla > --- > .../devicetree/bindings/arm/amlogic,scpi.txt | 15 --------------- > .../devicetree/bindings/firmware/arm,scpi.yaml | 4 ++++ > 2 files changed, 4 insertions(+), 15 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > deleted file mode 100644 > index ebfe302fb747..000000000000 > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > +++ /dev/null > @@ -1,15 +0,0 @@ > -System Control and Power Interface (SCPI) Message Protocol > -(in addition to the standard binding in [0]) > ----------------------------------------------------------- > -Required properties > - > -- compatible : should be "amlogic,meson-gxbb-scpi" > - > -Sensor bindings for the sensors based on SCPI Message Protocol > --------------------------------------------------------------- > -SCPI provides an API to access the various sensors on the SoC. > - > -Required properties: > -- compatible : should be "amlogic,meson-gxbb-scpi-sensors". > - > -[0] Documentation/devicetree/bindings/arm/arm,scpi.txt > diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > index 9c115e9c1536..d1179a4ea4e9 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > @@ -34,6 +34,7 @@ description: | > to SCPI v1.0 > items: > - const: arm,scpi-pre-1.0 > + - const: amlogic,meson-gxbb-scpi This says that compatible should be: "arm,scpi-pre-1.0", "amlogic,meson-gxbb-scpi" The order would be wrong and you lost supporting 'arm,scpi-pre-1.0' by itself. You want an enum here if it is either one or another items list if it is 2 entries. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel