From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 046E4C47082 for ; Mon, 31 May 2021 08:38:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE830610C9 for ; Mon, 31 May 2021 08:38:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE830610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/UHeeGpGRhMWUBIPB3C+hpqaODlzLctewKcJVz3O62M=; b=b4WGjIWOQx9rRe Q08O1hBHpArXIHwnQ2KAAJtIXnoXDsskWUEh0C/Z4y1KJjCDyGMCbvj7L243lr5R1z8Yg/HdA0WJ9 1ohPobqmA1GZkPqRoT8/dGR5stCREJEvQkpJ9u9fQUAUnDOJnoDrB2EjW6BS04pAgUEJTdsr2iEwT eeQ7P5YIuIxmKLQDhTH8unVxf5TMscUAXZvbse5o5nyHRyRXQoUQGi+Bw0tPrbkrG8K9JPlq8AbT6 nXGhRErOoQFdMnc9GLrHBhq+7JvWq31Qd262wYEN37wTM0NAL42d+jccCTeLB97SsnY1wMX3uax2V jlH3W3m4MCg37+VFGGMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lndPx-00BUEW-U1; Mon, 31 May 2021 08:37:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lndPr-00BUDC-Vv for linux-arm-kernel@lists.infradead.org; Mon, 31 May 2021 08:36:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96AE56D; Mon, 31 May 2021 01:36:54 -0700 (PDT) Received: from bogus (unknown [10.57.72.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 228D03F73D; Mon, 31 May 2021 01:36:52 -0700 (PDT) Date: Mon, 31 May 2021 09:36:47 +0100 From: Sudeep Holla To: Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet Subject: Re: [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: Convert to json schema Message-ID: <20210531083647.w4caop4v6vjpo2i2@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-8-sudeep.holla@arm.com> <20210527203327.GA1356362@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210527203327.GA1356362@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210531_013656_152170_284AD9BF X-CRM114-Status: GOOD ( 26.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 27, 2021 at 03:33:27PM -0500, Rob Herring wrote: > On Wed, May 26, 2021 at 07:28:06PM +0100, Sudeep Holla wrote: > > Convert/merge the existing text format SCPI binding additions for > > amlogic,scpi into the common arm,scpi json scheme. > > > > Couple of things to note: > > "amlogic,meson-gxbb-scpi" is always used with "arm,scpi-pre-1.0" > > hence no need for separate "arm,scpi-pre-1.0" standalone entry and > > "amlogic,meson-gxbb-scpi-sensors" is used always with "arm,scpi-sensors" > > > > Cc: Rob Herring > > Cc: Kevin Hilman > > Cc: Neil Armstrong > > Cc: Jerome Brunet > > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/amlogic,scpi.txt | 15 --------------- > > .../devicetree/bindings/firmware/arm,scpi.yaml | 4 ++++ > > 2 files changed, 4 insertions(+), 15 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > > > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > deleted file mode 100644 > > index ebfe302fb747..000000000000 > > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > +++ /dev/null > > @@ -1,15 +0,0 @@ > > -System Control and Power Interface (SCPI) Message Protocol > > -(in addition to the standard binding in [0]) > > ----------------------------------------------------------- > > -Required properties > > - > > -- compatible : should be "amlogic,meson-gxbb-scpi" > > - > > -Sensor bindings for the sensors based on SCPI Message Protocol > > --------------------------------------------------------------- > > -SCPI provides an API to access the various sensors on the SoC. > > - > > -Required properties: > > -- compatible : should be "amlogic,meson-gxbb-scpi-sensors". > > - > > -[0] Documentation/devicetree/bindings/arm/arm,scpi.txt > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > index 9c115e9c1536..d1179a4ea4e9 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > @@ -34,6 +34,7 @@ description: | > > to SCPI v1.0 > > items: > > - const: arm,scpi-pre-1.0 > > + - const: amlogic,meson-gxbb-scpi > > This says that compatible should be: "arm,scpi-pre-1.0", "amlogic,meson-gxbb-scpi" > > The order would be wrong and you lost supporting 'arm,scpi-pre-1.0' by > itself. You want an enum here if it is either one or another items list > if it is 2 entries. > Ah right, I checked about the order and then forgot to update. The idea when I wrote this was not to support arm,scpi-pre-1.0 by itself but recent found some other user of SCPI binding. I better keep the support though it is not in upstream DTS. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel