From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jungseung Lee <js07.lee@gmail.com>
Subject: Re: [PATCH 1/2] ARM: mm: Refactor __do_page_fault()
Date: Tue, 1 Jun 2021 15:31:26 +0100 [thread overview]
Message-ID: <20210601143125.GB30436@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210529034138.83384-2-wangkefeng.wang@huawei.com>
On Sat, May 29, 2021 at 11:41:37AM +0800, Kefeng Wang wrote:
> 1. cleanup access_error(), make vma flags set and check into
> __do_page_fault() and do_page_fault() directly.
>
> 2. drop fsr and task argument, instead, using vm_flags in
> __do_page_fault().
>
> 3. cleans up the multiple goto statements in __do_page_fault().
>
> 4. use current->mm directly in do_page_fault().
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
This patch is a really good example of something that is very difficult
to review and see that there are no unintended changes.
Many people have complained about my patches, where I create a series of
many patches where each patch does exactly _one_ simple transformation to
the code. This is a good example _why_ I do that - a step by step single
transformation approach is way easier to review.
Sorry, but I'm not able to sensibly review this patch, and therefore
I won't apply it. Please split it into smaller changes.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-01 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 3:41 [PATCH 0/2] ARM: fix PXN process with LPAE feature Kefeng Wang
2021-05-29 3:41 ` [PATCH 1/2] ARM: mm: Refactor __do_page_fault() Kefeng Wang
2021-06-01 14:31 ` Russell King (Oracle) [this message]
2021-06-02 6:42 ` Kefeng Wang
2023-06-02 9:49 ` Ard Biesheuvel
2023-06-02 9:51 ` Ard Biesheuvel
2023-06-02 9:59 ` Kefeng Wang
2021-05-29 3:41 ` [PATCH 2/2] ARM: mm: Fix PXN process when ARM_LPAE enabled Kefeng Wang
2021-06-01 13:29 ` [PATCH 0/2] ARM: fix PXN process with LPAE feature Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601143125.GB30436@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=js07.lee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).