From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7153FC47080 for ; Tue, 1 Jun 2021 20:34:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D5E61026 for ; Tue, 1 Jun 2021 20:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D5E61026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ipPtHN4dGYIXNdCIDUn1ygn0VaaMvav0IaJ6GzYVhbc=; b=vudPQJIBVUF7Sa 7BJ210XIShPVFtqZ+DGkGzdLC+iuUXqqHmjgG9+T848KhGwTDzoL+y+cF0Ih+xw8Pt9eHJe1Iv4Wh 9m4jkgwKCpLx9/R5V5lPsSZujBaYkpj3QeSNgrz9AJ3XIACRAWbiZJ+tYiucYqT0A9DkOHxpt3hio lGmBjRNQUOKVilz+FT7+OqOtN6R28aXs6Fl9Vi5tuL9w5c1ITEg8QwpQu9iTPkx9hoXKZRSiWu6rV AnoyDX21rervqEUqdg64fdd7hRK7AKxI+WMiXFllpTTr7OnsCBioOqVWhms7dlBAxpXJq/Ii+XF9z mKqcw1XK+VUzQDlbPHyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loB4j-000n9N-UO; Tue, 01 Jun 2021 20:33:22 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loB4g-000n8s-2i for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 20:33:19 +0000 Received: by mail-oi1-f174.google.com with SMTP id w127so590196oig.12 for ; Tue, 01 Jun 2021 13:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QrEdnEwQRqeosY6gkgi2Hdn7Yt87QUVcHOSzMSN62Lc=; b=ZgsyN+Mv8zykB3Ijg9LTOEfCEXH8basrd/gRuR6a8hNfwLmgJ+3Du7C6ButjKsyOTp DZoWsw0kIRs45JD4lqMEZQx0jK19JFcfxsGsR8gIBm/Oljq/4AuYdSXuU9h0AFupIsze X4o5JL2H3mpmIcgzgZNP8p4RmFzJUJpGOMPAtr6Uu7CR3KU5USpDNBA733/cnusmVg4q MuuxhR0wWJpN55faFUMl1hKwspOBT1a+ccL8Z6BEadaGqtRHJe2rrzO6fAgjkQXPZOl0 NAmWItWZo6wMdu1fykwnZG3t0AipxoKPEZtI2YpN/p5FmysHOdBLybHN4t8w6WNC/OVW 4B5A== X-Gm-Message-State: AOAM532O/LZJLqVx26YWKV0tA5zbKIBaAcMRkjFn/ARGPOFs/L3S9BfA LuK90WC6sn2vOoowzOTopw== X-Google-Smtp-Source: ABdhPJwC3oC7hefJFsHAhMPWQ6kmcmL5EL4tOd4wqe3rJZvXBFChtRBITnFPHbbFFjAGtpaQ8LQBdw== X-Received: by 2002:a05:6808:1394:: with SMTP id c20mr18806663oiw.90.1622579596906; Tue, 01 Jun 2021 13:33:16 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 7sm3907126oti.30.2021.06.01.13.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 13:33:16 -0700 (PDT) Received: (nullmailer pid 984921 invoked by uid 1000); Tue, 01 Jun 2021 20:33:14 -0000 Date: Tue, 1 Jun 2021 15:33:14 -0500 From: Rob Herring To: Mark Kettenis Cc: linux-pci@vger.kernel.org, Hector Martin , robin.murphy@arm.com, devicetree@vger.kernel.org, Mark Kettenis , maz@kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie Message-ID: <20210601203314.GA977583@robh.at.kernel.org> References: <20210530224404.95917-1-mark.kettenis@xs4all.nl> <20210530224404.95917-2-mark.kettenis@xs4all.nl> <1622554330.029938.242360.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1622554330.029938.242360.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_133318_146179_D9F178BA X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 08:32:10AM -0500, Rob Herring wrote: > On Mon, 31 May 2021 00:44:00 +0200, Mark Kettenis wrote: > > From: Mark Kettenis > > > > The Apple PCIe host controller is a PCIe host controller with > > multiple root ports present in Apple ARM SoC platforms, including > > various iPhone and iPad devices and the "Apple Silicon" Macs. > > > > Signed-off-by: Mark Kettenis > > --- > > .../devicetree/bindings/pci/apple,pcie.yaml | 167 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 168 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory > 20 | #include > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Looking at the example, I don't think you need this header. Looks like irq.h is needed though. Otherwise, LGTM. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel