From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60897C4708F for ; Wed, 2 Jun 2021 10:16:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 262456121D for ; Wed, 2 Jun 2021 10:16:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 262456121D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QE19ZKVD9KDH/ovnMTCwm2Lu0lNa5qqAxmOYDbCKZ8U=; b=0f/8m750Xe/cWI fAdgsV8PmImQJX/BbrhKE9Z7or5DLuKVxr7u8223ujLd7/A4uriL+dq61//WVrYBPxFt+2OAUr+hE 2kzNtbfC6sC25N2ZDA7R/TLroUNsBtCycTMmFZk9n44sGwjDokGhQv2j4ALaZdMg3RZrywAr3pUyt P55EpL61rVu8eWI59zYb1J+85eKRCHYubtX2t22D67IBC4OaFXzlvs/8QXOwYdMH1fkPSLJO4zVOk XQ/vFWYCc82eE2bBzS3x0LM46n10uAp7ex0znIpJ3ThdjotA/+pKvJ2vb7Ceqh5ALZrN6T5gA7H9x MQCZfBdvJB/vc4hzD+dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNtS-003EGv-1i; Wed, 02 Jun 2021 10:14:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNtM-003EEV-50 for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 10:14:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63BBE1042; Wed, 2 Jun 2021 03:14:24 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.31.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CEF0B3F73D; Wed, 2 Jun 2021 03:14:22 -0700 (PDT) Date: Wed, 2 Jun 2021 11:14:13 +0100 From: Mark Rutland To: Tian Tao Cc: will@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag Message-ID: <20210602101413.GA12753@C02TD0UTHF1T.local> References: <1622595642-61678-1-git-send-email-tiantao6@hisilicon.com> <1622595642-61678-2-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1622595642-61678-2-git-send-email-tiantao6@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_031428_273493_43FF9B35 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 02, 2021 at 09:00:41AM +0800, Tian Tao wrote: > request_irq() after setting IRQ_NOAUTOEN as below > irq_set_status_flags(irq, IRQ_NOAUTOEN); > request_irq(dev, irq...); > can be replaced by request_irq() with IRQF_NO_AUTOEN flag. > > this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which > is being merged: https://lore.kernel.org/patchwork/patch/1388765/ > > Signed-off-by: Tian Tao I see that the patch above was merged in v5.13-rc1 as commit: cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") With that in mind: Acked-by: Mark Rutland ... I expect Will will pick this up. Thanks, Mark. > --- > drivers/perf/arm_pmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index e57b348..eb3a802 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu) > } > > irq_flags = IRQF_PERCPU | > - IRQF_NOBALANCING | > + IRQF_NOBALANCING | IRQF_NO_AUTOEN | > IRQF_NO_THREAD; > > - irq_set_status_flags(irq, IRQ_NOAUTOEN); > - > err = request_nmi(irq, handler, irq_flags, "arm-pmu", > per_cpu_ptr(&cpu_armpmu, cpu)); > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel