From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE603C4708F for ; Wed, 2 Jun 2021 10:17:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7573613B8 for ; Wed, 2 Jun 2021 10:17:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7573613B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WnW0Y60NELkjaO6DWFeQfkA5k0nMkb1sMtN4zxhix3Q=; b=nOeOO3vl6qrANh ZSaGB3k7M4z5NnDlNb+bFQvfpCb1gz5chOuzBbuCgia0uGt9vRsnITTO9iMfL/IoMOaF1ZOZ4EQnN GWy5WR0ZsafZWSxMWuEZO8Vjt2l3Fx4U4tYzkIEMiAUAhFlOCEBDbph+WQa1K7DNA3Bo70kXj/Y8i QOFyG+y0YZnkTbgcKxs56zISfO4dj/dkW1phl/QDhfey8fBHua6+x3W/EUeiD6yCPOfwW7Z8EqyMd fy6LvCVuNk58B0ftvzSadRHEkgHXUcjaf7m1Em9PsdA5v82DzLbttbcDtIMYzD+gyCHjXe1LERHTD ic2H9TXHTjADLrx0fFDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNv2-003Ejf-0U; Wed, 02 Jun 2021 10:16:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loNux-003EiF-17 for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 10:16:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 437371042; Wed, 2 Jun 2021 03:16:05 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.31.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 955503F73D; Wed, 2 Jun 2021 03:16:03 -0700 (PDT) Date: Wed, 2 Jun 2021 11:16:00 +0100 From: Mark Rutland To: Tian Tao Cc: will@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag Message-ID: <20210602101600.GB12753@C02TD0UTHF1T.local> References: <1622595642-61678-1-git-send-email-tiantao6@hisilicon.com> <1622595642-61678-3-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1622595642-61678-3-git-send-email-tiantao6@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_031607_164698_357D30DA X-CRM114-Status: GOOD ( 19.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 02, 2021 at 09:00:42AM +0800, Tian Tao wrote: > request_irq() after setting IRQ_NOAUTOEN as below > irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can > be replaced by request_irq() with IRQF_NO_AUTOEN flag. > > this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which > is being merged: https://lore.kernel.org/patchwork/patch/1388765/ > > Signed-off-by: Tian Tao As with patch 1, I see that the patch above was merged in v5.13-rc1 as commit: cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") With that in mind: Acked-by: Mark Rutland I expect Will will pick this up. Thanks, Mark. > --- > drivers/perf/qcom_l2_pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c > index fc54a80..b60e301 100644 > --- a/drivers/perf/qcom_l2_pmu.c > +++ b/drivers/perf/qcom_l2_pmu.c > @@ -869,14 +869,14 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data) > irq = platform_get_irq(sdev, 0); > if (irq < 0) > return irq; > - irq_set_status_flags(irq, IRQ_NOAUTOEN); > cluster->irq = irq; > > cluster->l2cache_pmu = l2cache_pmu; > cluster->on_cpu = -1; > > err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq, > - IRQF_NOBALANCING | IRQF_NO_THREAD, > + IRQF_NOBALANCING | IRQF_NO_THREAD | > + IRQF_NO_AUTOEN, > "l2-cache-pmu", cluster); > if (err) { > dev_err(&pdev->dev, > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel