From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B957EC4708F for ; Wed, 2 Jun 2021 10:41:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 886D8613AD for ; Wed, 2 Jun 2021 10:41:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 886D8613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=psL8UaDJTWVkmqxN/Ez+PCaFGbWDVFEax7dwvN+/TXo=; b=er3aEVHNpg/Bqd 9t01Mq9/NiSozl+InPQrl4v7uJTRtF0O2nEGA3BpLR9U7gyFFWsJaHJQnov9PLRMVH+qW2HJi6tTz c7zokndMrSXgZ0MdsU4LbpMIDVXHumDVgMQdSuMwf2hSJVvqY9JcUjmzG6SExd0Ja8fdiA+ccAJ8/ OqEpf6rJYNun17iXedWHK2vuGJNJUIe8HVRGL2EY7U6fD6jBEIc2lJ0crbEi91Q99kqn8SBEYBgzJ /bBLclk6NpUcsGf4SdGszXC665fyhE63wzzaNJkrVhcGcVYpyk0gRlElW4PgpnZdnRSLfQs1BjB+w bs4eBroJSjhdFeyNTMSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loOHT-003Oi3-FM; Wed, 02 Jun 2021 10:39:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loOHJ-003Oen-TI for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 10:39:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oqCJhYD+APXhLiRbdzUFdNItab0UJDYn8NBVU6Y8mtY=; b=yc/d8gMsUVyNDNHXZbmPcX+AY VoqgRmhfPjp7x2ZRyO2iyAj0VGFYPhe8VmMMNw57lvFGZ/ojWHModK+R0Hxn87WTmWXbrLK28yJw1 FgjQsL8jc7W6TB/Q0ECoVsRgTZfMpRhA5JBVM8vjVyddtn5nqjW1v7nILdJ8rKyB5mcSRr6sXT/nt yJseil1dqavyTZe+s2YMdQ5/CvEEN1kdoJb1yba+wOiTF8SzBtgu3EjMpAAgFjgeAnb86yQytzlXk 2S6vr8j/FpFWOyMSWCkn4y2Lc+5SM8hVn4Y5F618NurWqenwiTGtyA9EZny6MUdi6KJ6PISdLTGML fCYVFp4PA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44614) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loOHI-000112-5v; Wed, 02 Jun 2021 11:39:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loOHH-00013e-Fc; Wed, 02 Jun 2021 11:39:11 +0100 Date: Wed, 2 Jun 2021 11:39:11 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH v2 3/7] ARM: mm: Cleanup access_error() Message-ID: <20210602103911.GG30436@shell.armlinux.org.uk> References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602070246.83990-4-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_033913_980598_96736144 X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jun 02, 2021 at 03:02:42PM +0800, Kefeng Wang wrote: > Now the write fault check in do_page_fault() and access_error() twice, > we can cleanup access_error(), and make the fault check and vma flags set > into do_page_fault() directly, then pass the vma flags to __do_page_fault. > > No functional change. > > Signed-off-by: Kefeng Wang Looks fine to me. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel