From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90829C4708F for ; Wed, 2 Jun 2021 16:40:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51680619B1 for ; Wed, 2 Jun 2021 16:40:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51680619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X7uWeysONUhpEmseI2qtrxNLxf5/Ejn6j5qwaxbiJHE=; b=sF02TyXSgOBuAK kk3NX7Kj4jos0VH11qbSnWGE34bN66wGownh0melMkW34INL/FL0ZD6Nn0p0cHNVmxycWhKmAv/nl mYOp4AMK6UYxE5Cn6uhOniSd4Ucmz0ga0E3vViZQ47POnHoK/GpZnG1OG36GnLZ3+XN2sqAFftv3D A4GSZj87O6/Q56FBptm0Dpswo+dTe5iPtuJRy0I6LL1I3izK2OiN6R78M1aDD26ntCBV1Lxsl3KB0 9CpXG2oPQ63br9hFRY2+A8Sn9ekzBdmnCw6j73JcPugCNgev3JEf2cf0H8r4aHLoZDm8Q2PaVJwyP XedJSSW0wuHn6bw4q0Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTt1-005BxM-Kq; Wed, 02 Jun 2021 16:38:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loTst-005BvQ-Ev for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 16:38:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xgBO7fdSr6YSsVQBLRDAGFaBV9JpUZ1T6Fnms/JHljk=; b=Zq5z+xhHzF1/WVUrMUxtHyrO2 9/uMO4e+CR3AAO8dP6KevTOZ0IMUq7emOs+1aFKz/9yKmXXLovec7iGNoEnW9DGitAhlp50BYlYfL 7+n6Q+VfJcv+yTZdgnRik/7PZkWtl2CAGku4kNtSIJdUswL3gE9nu2zBmA1q1o2K3qsKOlytgu4R0 4mNDJoljSVvGcdrWmenY1JvMPN0nVgSCFraURpb7LXCQwIU2xYD9XWPriIOFmto0mT21+kHndg+Ea TJNeME+hK0Je+U0bLvF7EZlAUNAtk9GJwz1yDPjhGDPoF++OjeOdj/WhKhN3wFOQyzKrDLVzIXZvl m9ifRTCKw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44636) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loTsq-0001YY-2E; Wed, 02 Jun 2021 17:38:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loTsk-0001HG-6E; Wed, 02 Jun 2021 17:38:14 +0100 Date: Wed, 2 Jun 2021 17:38:14 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: Nathan Chancellor , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm: mm: qsd8x50: Fix incorrect permission faults" Message-ID: <20210602163814.GO30436@shell.armlinux.org.uk> References: <20210528074444.17291-1-wangkefeng.wang@huawei.com> <248320ed-494b-937d-734c-c97e0c32038a@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248320ed-494b-937d-734c-c97e0c32038a@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_093823_553147_D43E3C79 X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kefang, On Wed, Jun 02, 2021 at 11:14:51PM +0800, Kefeng Wang wrote: > Hi Russell, any comment about this patch, thanks. I think it's fine - looking at the history, this was a change submitted in 2009 for the MSM platform that has been dropped from the kernel. It seems the option was never enabled, even when support for this platform was present in the kernel. So please send to the patch system and I'll merge it in due course. Thanks. > > On 2021/5/28 15:44, Kefeng Wang wrote: > > This reverts commit e220ba60223a9d63e70217e5b112160df8c21cea. > > > > The VERIFY_PERMISSION_FAULT is introduced since 2009 but no > > one use it, just revert it and clean unused comment. > > > > Signed-off-by: Kefeng Wang > > --- > > arch/arm/mm/Kconfig | 2 -- > > arch/arm/mm/abort-ev7.S | 26 -------------------------- > > 2 files changed, 28 deletions(-) > > > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > > index 35f43d0aa056..8355c3895894 100644 > > --- a/arch/arm/mm/Kconfig > > +++ b/arch/arm/mm/Kconfig > > @@ -601,8 +601,6 @@ config CPU_TLB_V6 > > config CPU_TLB_V7 > > bool > > -config VERIFY_PERMISSION_FAULT > > - bool > > endif > > config CPU_HAS_ASID > > diff --git a/arch/arm/mm/abort-ev7.S b/arch/arm/mm/abort-ev7.S > > index f7cc5d68444b..f81bceacc660 100644 > > --- a/arch/arm/mm/abort-ev7.S > > +++ b/arch/arm/mm/abort-ev7.S > > @@ -17,31 +17,5 @@ ENTRY(v7_early_abort) > > mrc p15, 0, r1, c5, c0, 0 @ get FSR > > mrc p15, 0, r0, c6, c0, 0 @ get FAR > > uaccess_disable ip @ disable userspace access > > - > > - /* > > - * V6 code adjusts the returned DFSR. > > - * New designs should not need to patch up faults. > > - */ > > - > > -#if defined(CONFIG_VERIFY_PERMISSION_FAULT) > > - /* > > - * Detect erroneous permission failures and fix > > - */ > > - ldr r3, =0x40d @ On permission fault > > - and r3, r1, r3 > > - cmp r3, #0x0d > > - bne do_DataAbort > > - > > - mcr p15, 0, r0, c7, c8, 0 @ Retranslate FAR > > - isb > > - mrc p15, 0, ip, c7, c4, 0 @ Read the PAR > > - and r3, ip, #0x7b @ On translation fault > > - cmp r3, #0x0b > > - bne do_DataAbort > > - bic r1, r1, #0xf @ Fix up FSR FS[5:0] > > - and ip, ip, #0x7e > > - orr r1, r1, ip, LSR #1 > > -#endif > > - > > b do_DataAbort > > ENDPROC(v7_early_abort) > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel