From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Etienne Carriere <etienne.carriere@linaro.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH -next] firmware: arm_scmi: Fix the build when CONFIG_MAILBOX is not selected
Date: Thu, 3 Jun 2021 13:55:02 +0100 [thread overview]
Message-ID: <20210603125502.GC28060@e120937-lin> (raw)
In-Reply-To: <20210603072631.1660963-1-sudeep.holla@arm.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Cristian Marussi <cristian.marussi@arm.com>
Cristian
On Thu, Jun 03, 2021 at 08:26:31AM +0100, Sudeep Holla wrote:
> 0day CI kernel test robot reported following build error with randconfig
>
> aarch64-linux-ld: drivers/firmware/arm_scmi/driver.o:(.rodata+0x1e0):
> undefined reference to `scmi_mailbox_desc'
>
> Fix the error by adding CONFIG_MAILBOX dependency for scmi_mailbox_desc.
>
> Cc: Etienne Carriere <etienne.carriere@linaro.org>
> Cc: Cristian Marussi <cristian.marussi@arm.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 5e8e9337adc7..ca71568c5c41 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -1571,7 +1571,9 @@ ATTRIBUTE_GROUPS(versions);
>
> /* Each compatible listed below must have descriptor associated with it */
> static const struct of_device_id scmi_of_match[] = {
> +#ifdef CONFIG_MAILBOX
> { .compatible = "arm,scmi", .data = &scmi_mailbox_desc },
> +#endif
> #ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY
> { .compatible = "arm,scmi-smc", .data = &scmi_smc_desc},
> #endif
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-03 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 7:26 [PATCH -next] firmware: arm_scmi: Fix the build when CONFIG_MAILBOX is not selected Sudeep Holla
2021-06-03 12:55 ` Cristian Marussi [this message]
2021-06-03 13:33 ` Etienne Carriere
2021-06-03 14:59 ` Sudeep Holla
2021-06-04 8:55 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603125502.GC28060@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).