From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35DDC47082 for ; Thu, 3 Jun 2021 12:57:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C38613E7 for ; Thu, 3 Jun 2021 12:57:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C38613E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3FKcNu0WBJx+N79ModZgeT/aDndUQfeoKO79L4+Djmo=; b=yYjCzbrNgafsa6 aZAdRanyxzSTjO27iq3U2d9Mhw97CYZXVJV4BikMviTwpgLQ8Wa7f7w40g6M9wNnC4V9fNVlXTmdE t9Nh45zlxUzm1ptaVOx7KRdiFDfEmS17JETaIAHYSl1cv0XD203pdZuuWgO9jdYWK2907JThQVyke Mh37jBR+p+pYEj9mCFE9nGSLAmbJF9RMXQApL2Cb0LP+HYRmRaRrfsSz612MMuudyTs7/BWb0yvaR evmRoyP9MwHGRLk3Oqp2K+kzMoZ0FK3te/ciKBRY/MnPzIC5AiPuX7+agP4QOeg+s7T62wlDaqQ6p fTEl31RiKTH33mBD0w6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lomsc-008mWn-1e; Thu, 03 Jun 2021 12:55:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lomsV-008mUa-LO for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 12:55:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC95F1063; Thu, 3 Jun 2021 05:55:14 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AFB0F3F774; Thu, 3 Jun 2021 05:55:08 -0700 (PDT) Date: Thu, 3 Jun 2021 13:55:02 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Etienne Carriere , kernel test robot Subject: Re: [PATCH -next] firmware: arm_scmi: Fix the build when CONFIG_MAILBOX is not selected Message-ID: <20210603125502.GC28060@e120937-lin> References: <20210603072631.1660963-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210603072631.1660963-1-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_055515_790418_A0A1F253 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reviewed-by: Cristian Marussi Tested-by: Cristian Marussi Cristian On Thu, Jun 03, 2021 at 08:26:31AM +0100, Sudeep Holla wrote: > 0day CI kernel test robot reported following build error with randconfig > > aarch64-linux-ld: drivers/firmware/arm_scmi/driver.o:(.rodata+0x1e0): > undefined reference to `scmi_mailbox_desc' > > Fix the error by adding CONFIG_MAILBOX dependency for scmi_mailbox_desc. > > Cc: Etienne Carriere > Cc: Cristian Marussi > Reported-by: kernel test robot > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scmi/driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 5e8e9337adc7..ca71568c5c41 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1571,7 +1571,9 @@ ATTRIBUTE_GROUPS(versions); > > /* Each compatible listed below must have descriptor associated with it */ > static const struct of_device_id scmi_of_match[] = { > +#ifdef CONFIG_MAILBOX > { .compatible = "arm,scmi", .data = &scmi_mailbox_desc }, > +#endif > #ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY > { .compatible = "arm,scmi-smc", .data = &scmi_smc_desc}, > #endif > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel