Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding

Bjorn Andersson
2021-06-14T21:27:34Z

On Mon 14 Jun 14:15 CDT 2021, Suman Anna wrote:

> Hi Bjorn,
>
> On 6/7/21 8:19 AM, Rob Herring wrote:
> > On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <s-anna@ti.com> wrote:
> >>
> >> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> >> $id and fails to compile the example due to undefined args specifier
> >> values for clocks and resets. Fix both of these issues.
> >>
> >> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> >> Signed-off-by: Suman Anna <s-anna@ti.com>
> >> ---
> >> Hi Wilken,
> >>
> >> This fixes the warnings for now on linux-next, but I think the example
> >> should be including sun6i-a31-ccu.h files instead to be accurate, and
> >> those files are missing the definitions for CLK_BUS_SPINLOCK and
> >> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> >> patch on top.
> >>
> >> regards
> >> Suman
> >>
> >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> >
>
> Gentle ping, can you pick up this patch and the remoteproc pas binding
> indentations fixes please so that linux-next is sane w.r.t these?
>

Sorry, I picked up some (biological) bug and haven't been of much use
the last couple of weeks. I've picked the two patches now, thank you
Suman!

Regards,
Bjorn