From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 907B7C47097 for ; Thu, 3 Jun 2021 15:17:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6557661208 for ; Thu, 3 Jun 2021 15:17:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6557661208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZvL5DQgtUjf2UQfSe3xUmzMLQn+r7bOgnus4K73995s=; b=vrCn97dWso7mnR 1whPH9Fv6L5DzKAIG1aPe3S0Gn6HDRIGb4GsjDyPnHK088hj48Q5pR7p3HP4KrYiSyUrUBmoqr03o byFgAYhy1Vyj9syy+GL9NGL0UqfRKObhVKT51fgn67Cr6I3DMQLZJRr7qwb9xAj5HjJFkQbID8XiL WfjFM6FQzIah2USk9Q2nRBcUUOkxQF7jU1emqbrI50HYXQcYPPi5LLAHT4bX7c+WGKb8yBE/8RMRs aHhE8L7U0mQpWPhsG7VjeDhq5/gRRomrnlAU+4wuUQoTei3xtI5URi7n9aJXmBE/8EDxG4VssGv23 D964u00uVUeDXDD8w6ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lop54-009KCA-7c; Thu, 03 Jun 2021 15:16:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lop4x-009KAE-6i for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 15:16:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B477112FC; Thu, 3 Jun 2021 08:16:12 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 04C3C3F73D; Thu, 3 Jun 2021 08:16:10 -0700 (PDT) Date: Thu, 3 Jun 2021 16:16:05 +0100 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/42] PCI: aardvark: Various driver fixes Message-ID: <20210603151605.GA18917@lpieralisi> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210506153153.30454-1-pali@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_081615_364763_8D6DCB6E X-CRM114-Status: GOOD ( 26.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 06, 2021 at 05:31:11PM +0200, Pali Roh=E1r wrote: > This patch series fixes various issues in pci-aardvark.c driver > (PCIe controller on Marvell Armada 3700 SoC) used on Espressobin > and Turris Mox. > = > First patch fixes kernel panic (or TF-A panic depending on used > firmware) during execution of PIO transfer and I would suggest to > include this fix into v5.13 release to prevent future kernel panics. > = > Other patches then fixes PIO issues, PCIe link training, initialization > of PCIe controller, accessing PCIe Root Bridge/Port registers, handling > of interrupts (including ERR and PME), setup of Multi-MSI interrupts, > adding support for masking MSI interrupts, adding support for more than > 32 MSI interrupts with MSI-X support, and adding support for AER. > = > Note that there are still some unresolved issues with PCIe on A3720. > I asked Marvell for PCIe documentation or explanations but I have not > received anything (yet). > = > Patch "Fix checking for PIO status" is taken from the Marvell github fork > and adapted for inclusion into mainline kernel: > https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/84444d2= 2023c > = > Whole patch series is available also in my git branch pci-aardvark: > https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=3Dp= ci-aardvark > = > If you have Espressobin, Turris Mox or other A3720 board with PCIe > please test this patch series with your favourite PCIe card if > everything is working fine. > = > Evan Wang (1): > PCI: aardvark: Fix checking for PIO status > = > Pali Roh=E1r (39): > PCI: aardvark: Fix kernel panic during PIO transfer > PCI: aardvark: Fix checking for PIO Non-posted Request > PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO > response > PCI: pci-bridge-emul: Add PCIe Root Capabilities Register > PCI: aardvark: Fix reporting CRS Software Visibility on emulated > bridge > PCI: aardvark: Fix link training > PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros > PCI: aardvark: Fix PCIe Max Payload Size setting > PCI: aardvark: Implement workaround for the readback value of VEND_ID > PCI: aardvark: Do not touch status bits of masked interrupts in > interrupt handler > PCI: aardvark: Check for virq mapping when processing INTx IRQ > PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts > PCI: aardvark: Don't mask irq when mapping > PCI: aardvark: Change name of INTx irq_chip to advk-INT > PCI: aardvark: Remove unneeded goto > PCI: aardvark: Fix support for MSI interrupts > PCI: aardvark: Correctly clear and unmask all MSI interrupts > PCI: aardvark: Fix setting MSI address > PCI: aardvark: Add support for more than 32 MSI interrupts > PCI: aardvark: Add support for masking MSI interrupts > PCI: aardvark: Enable MSI-X support > PCI: aardvark: Fix support for ERR interrupt on emulated bridge > PCI: aardvark: Fix support for PME on emulated bridge > PCI: aardvark: Fix support for PME requester on emulated bridge > PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on > emulated bridge > PCI: aardvark: Disable bus mastering and mask all interrupts when > unbinding driver > PCI: aardvark: Free config space for emulated root bridge when > unbinding driver to fix memory leak > PCI: aardvark: Reset PCIe card and disable PHY when unbinding driver > PCI: aardvark: Rewrite irq code to chained irq handler > PCI: aardvark: Use separate INTA interrupt for emulated root bridge > PCI: pci-bridge-emul: Add description for class_revision field > PCI: pci-bridge-emul: Add definitions for missing capabilities > registers > PCI: aardvark: Add support for DEVCAP2, DEVCTL2, LNKCAP2 and LNKCTL2 > registers on emulated bridge > PCI: aardvark: Add support for PCI_BRIDGE_CTL_BUS_RESET on emulated > bridge > PCI: aardvark: Replace custom PCIE_CORE_ERR_CAPCTL_* macros by > linux/pci_regs.h macros > PCI: aardvark: Replace custom PCIE_CORE_INT_* macros by linux > PCI_INTERRUPT_* values > PCI: aardvark: Cleanup some register macros > PCI: aardvark: Add comments for OB_WIN_ENABLE and ADDR_WIN_DISABLE > PCI: aardvark: Add support for Advanced Error Reporting registers on > emulated bridge > = > Russell King (2): > PCI: pci-bridge-emul: re-arrange register tests > PCI: pci-bridge-emul: add support for PCIe extended capabilities > = > drivers/pci/controller/pci-aardvark.c | 980 +++++++++++++++++++------- > drivers/pci/pci-bridge-emul.c | 149 ++-- > drivers/pci/pci-bridge-emul.h | 17 +- > include/uapi/linux/pci_regs.h | 6 + > 4 files changed, 850 insertions(+), 302 deletions(-) May I ask you please to split this series in smaller sets so that it is easier to merge ? Let's start with the more urgent fixes that don't involve rework (or you have not received change requests for since they are simple). Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel