From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05EA5C47083 for ; Fri, 4 Jun 2021 04:57:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6E096140C for ; Fri, 4 Jun 2021 04:57:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6E096140C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=posteo.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+KB/6MgiByM5qT5qli3b0aUm4bVDMBZis6hDUIVKslE=; b=KLthN/dyRT7TCC 6KQVMO/mOMXWbTRr/eMKKmHaNkge9FHge1Fy99NeLzVBTpbPno2m+e+DFCGJ1kyhov2G8fG68Pf9o WohBLPg5kAoM2RUaAnJDBrAYNo0XrZiLXp5cgNjwMTLq4CbKie0GFcc/hZjK5XDGTBam42vgkHxlb klkVNQjshogkBYmwZo6cT7HLJqtIQBRCYPiex58xjPm2MVuOh7Qenh9A+TsfECiGs6gEjohux3cTs uOwnZG01DDPTOZT9XtUyklPjBeVJz4/RI2vEtqRt9ytK+bfdBrIpK7OnZOiwiTWrBxKD5Hk9eRQad 01W0qkaLxGPnHY8K5P7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp1sE-00BXSN-TB; Fri, 04 Jun 2021 04:55:59 +0000 Received: from mout02.posteo.de ([185.67.36.66]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp1sA-00BXQo-8g for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 04:55:56 +0000 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 983582400FE for ; Fri, 4 Jun 2021 06:55:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1622782547; bh=TTyTROyQXjsSXo74wJBHn6lqKWQ3+EbGHja6XTO7Rds=; h=Date:From:To:Cc:Subject:From; b=b4kfkQdftGPZQAMXH5LvwkFcZ3zhObfnY0zCw1HWa3vz1OjKz0xIDlQZfAUqaYm8n LEzDIeuIPtgW+cna1vw2q7i1wnM3oFCyxkSEA+W10Mt7I3CRYrP+A9ukIObzFVybPW pMClWvFX+BOQV2lPrTodITHK5rXrTxjmGbUTwKcFW1rUQUb1/w0DWPByV2HRJQMX/A 2icvC+zVgqIzhPQSq2W2c6YEOu0PV+VnOzM+DGMS+tgOEnXNRHlASnZ7hzPZRlQDME 9LASZa1tebUvbv6Ie5EVrYQPsgmQlntWn/Ef8HlLZU61ngXarVx6ERq9Tfp56/pUbZ gKf2dD0fGmqfg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fx9Sc48Wdz6tm9; Fri, 4 Jun 2021 06:55:44 +0200 (CEST) Date: Fri, 4 Jun 2021 04:55:43 +0000 From: Wilken Gottwalt To: Suman Anna Cc: Bjorn Andersson , Rob Herring , Mathieu Poirier , Maxime Ripard , Chen-Yu Tsai , , , , , Subject: Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Message-ID: <20210604065543.3d71ca53@monster.powergraphx.local> In-Reply-To: <20210603144216.10327-1-s-anna@ti.com> References: <20210603144216.10327-1-s-anna@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_215554_490271_3299971F X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Jun 2021 09:42:16 -0500 Suman Anna wrote: > The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched > $id and fails to compile the example due to undefined args specifier > values for clocks and resets. Fix both of these issues. > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > Signed-off-by: Suman Anna > --- > Hi Wilken, > > This fixes the warnings for now on linux-next, but I think the example > should be including sun6i-a31-ccu.h files instead to be accurate, and > those files are missing the definitions for CLK_BUS_SPINLOCK and > RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental > patch on top. > > regards > Suman Hi Suman, thank you for fixing this. I would have fix it the same way for now, so it is fine for me. But I will keep an eye on it. greetings, Will > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index > 733c3d01e56c..10e5a53e447b 100644 --- > a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ > b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml# > +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs > @@ -36,6 +36,9 @@ additionalProperties: false > > examples: > - | > + #include > + #include > + > hwlock@1c18000 { > compatible = "allwinner,sun6i-a31-hwspinlock"; > reg = <0x01c18000 0x1000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel