From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E78C07E94 for ; Fri, 4 Jun 2021 14:08:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB4A061405 for ; Fri, 4 Jun 2021 14:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB4A061405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uffArjYB6wbBrHXSSR/14br4Wd50hPEV0d9UJgbEPn4=; b=J49Lz2B1lOkIX9 bvyuV2faMQEBOfpyBqVoNC0gcOxDYoKhF4UpQ8/baevgpBHdOHbvwuRlP9t2atIy5OCvy1zR5CS6U G8RVaRqopSekOvlLdQSyN/ef13gv6kQn6yFN45AdT0nVp74il5g3wptemSlebcD4cPClpijBf9ecR BUlBIKXSan1uOKwFEjt2MwAGDcZzlCGq1+pDvGjmkBxBQFANnScq7FqRcxym9f20WkhoYkrFONgp0 ywXbVCzPHqK711k+loDN8H2bIcUgE8yzX4E/Ev4jhXqPI4VNuhu33fGVkDX9nrClkLpRE966PQ/SA xlU2j1yW29TljQVuFHBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpATS-00Dr7x-FW; Fri, 04 Jun 2021 14:06:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpASM-00DqXi-Rk for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 14:05:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 148D4613FF; Fri, 4 Jun 2021 14:05:46 +0000 (UTC) Date: Fri, 4 Jun 2021 15:05:44 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v13 4/8] KVM: arm64: Introduce MTE VM feature Message-ID: <20210604140544.GF31173@arm.com> References: <20210524104513.13258-1-steven.price@arm.com> <20210524104513.13258-5-steven.price@arm.com> <20210603160031.GE20338@arm.com> <20210604113658.GD31173@arm.com> <2265cbf6-d643-9122-79a8-90198ea16c64@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2265cbf6-d643-9122-79a8-90198ea16c64@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_070550_979275_2663D640 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 01:51:38PM +0100, Steven Price wrote: > On 04/06/2021 12:36, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 11:42:11AM +0100, Steven Price wrote: > >> On 03/06/2021 17:00, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:09AM +0100, Steven Price wrote: > >>>> @@ -971,8 +1007,13 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > >>>> if (writable) > >>>> prot |= KVM_PGTABLE_PROT_W; > >>>> > >>>> - if (fault_status != FSC_PERM && !device) > >>>> + if (fault_status != FSC_PERM && !device) { > >>>> + ret = sanitise_mte_tags(kvm, pfn, vma_pagesize); > >>>> + if (ret) > >>>> + goto out_unlock; > >>> > >>> Maybe it was discussed in a previous version, why do we need this in > >>> addition to kvm_set_spte_gfn()? > >> > >> kvm_set_spte_gfn() is only used for the MMU notifier path (e.g. if a > >> memslot is changed by the VMM). For the initial access we will normally > >> fault the page into stage 2 with user_mem_abort(). > > > > Right. Can we move the sanitise_mte_tags() call to > > kvm_pgtable_stage2_map() instead or we don't have the all the > > information needed? > > I tried that before: kvm_pgtable_stage2_map() is shared with the > hypervisor so sadly we can't go poking around in the host as this breaks > on nVHE. I mentioned it in the v12 cover letter but it was in a wall of > text: Ah, I missed this in the cover letter (haven't read it). So, apart from the nitpick with the early return for less indentation, feel free to add: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel