From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D9BC4743C for ; Fri, 4 Jun 2021 17:46:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58068613F9 for ; Fri, 4 Jun 2021 17:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58068613F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/iukO+zMQJThkGfg2lxlR8U+CfksTfYqYvBU2PUkLwI=; b=eCrpDtvqN01ik9 owIVB3rNDN75ZAlTIU1puhqKjsrILCYy8M542fxNz2zS2owDEGXDJ1/574f4GusW4oYKxTcwenzjk a6hvQTuyMI8wEdNfbFj9bKoc19lF32hHspYZS8rcXq+uUYQynxk7QAPyLzDp0qNpbpsuRmhN6+54i 47rFYY8QgId1hN+8F9BNQE3zbRMC7U4lOtw0tjwsOZrGPUQsd2FukcgeAlLjxcrTPLXSt2ej6meHk fiLs4HsLBsYXtp9GqlFzObHKWIJs2AXkjCKyMLE24whyZjALcn84THw2blTT0Tc4gVc6B8sWX9ju6 sEVwbQiuuj64cx5maG/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpDsW-00EjpG-6O; Fri, 04 Jun 2021 17:45:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpDsP-00EjnG-Uc for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 17:45:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B9FC611CE; Fri, 4 Jun 2021 17:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622828697; bh=v4hAs282S3fATvgG2QSaLBO3ce1FFWWGjLHqhxPYBGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KzK71CkofDZHouDV8pjHtKUGHznzSjDDCTofNQwIEcaK3HJg+NWLwbsDpGgvmifG4 SumAu+bbBOl+d7mTIrFjdl5cdtbHV5bNz1nVr+IdBlAVYwZBuB1PVhEkKamszdl9vF hy6Hdb5/WbzUUJC+4P6O6sX4rSugsM+IuVTty64hx+FWZsRAtJhLJkTCO0O7pjYM6i sQQa0nEZ+/srEVpir5F1dctMMA6qLOEAP2P/OywPdxCoXfzKF3NwsehLfM6lu4CZXM 3Vw2/owcM5PqDGpKxQx/NtYqMUjpiHBco0RHoW+WFuY0gvVrXKrEtDIU8GID+QYkJj TZZiES+EwgaQg== Date: Fri, 4 Jun 2021 18:44:53 +0100 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, maz@kernel.org Subject: Re: [PATCH v3 08/20] arm64: entry: organise entry handlers consistently Message-ID: <20210604174452.GB3703@willie-the-truck> References: <20210525183302.56293-1-mark.rutland@arm.com> <20210525183302.56293-9-mark.rutland@arm.com> <20210604165141.GB3416@willie-the-truck> <20210604173959.GB73426@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604173959.GB73426@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_104458_031604_3097BF89 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 06:39:59PM +0100, Mark Rutland wrote: > On Fri, Jun 04, 2021 at 05:51:41PM +0100, Will Deacon wrote: > > On Tue, May 25, 2021 at 07:32:50PM +0100, Mark Rutland wrote: > > > In entry.S we have two comments which distinguish EL0 and EL1 exception > > > handlers, but the code isn't actually laid out this way, and there are a > > > few other inconsitencies that would be good to clear up. > > > > Typo: inconsitencies > > > > > This patch organizes the entry handers consistently: > > > > > > * The handlers are laid out in order of the vectors, to make them easier > > > to navigate. > > > > > > * All handlers are given the same alignment, which was previously > > > applied inconsitently. > > > > It's that word again. > > > > Anyway, why is this alignment needed in the first place? > > The alignemnt isn't functionally necessary. It's been there since day 1, > in commit: > > 60ffc30d5652810d ("arm64: Exception handling") > > I'm happy to have them or delete them; I just need to make this > consistent for when this gets templated. I agree that consistency is good here, so the "obvious" thing would be to use SYM_CODE_START_LOCAL because we don't have any specific alignment constraints, I think. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel