From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF55C4743F for ; Mon, 7 Jun 2021 13:17:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ECA26100B for ; Mon, 7 Jun 2021 13:17:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ECA26100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JCXH/VNpDxlwkDn7iBg+V0dGqr/KFM5VZtLyIF4w1a4=; b=srZYjvrZnwV6D+ V1SXYHcccJL5TQ1mdehmlQPfEyJL3byIie5mN0/VeQ1nRZjBcN1h/CXA20zDBAQj7dpS6PzpR2hpQ JxDpo1837q8CIcbPbgrX7eyk7VnYbDAg5IwJrRxbvk/wXt7+wtDPn6xo9Kkpgqayj8uG0m4Z0m6BW M/Jhm+bJQAGUQMp5zD6D/PxGUHPSFJf6Pl+gxTS1YIerRTUJrchCcHOA3VnwhKCPbZi8C33npn0lS PGSHv2zJnDzpvyh64R3DNcYmRNioaPXV9sd9uF5sAiRpBByilDJk0paIUd57+wxrPdssJWJLHN62B 08cDmZBPpiteaXgCy0QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqF5T-003j8y-GA; Mon, 07 Jun 2021 13:14:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqF3W-003iYM-9I for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 13:12:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzx+toA+I5GhMZJQ4bshpMENsBCltPEDS9fQ3Twfj7g=; b=bd0/P2zv8OxN2aVXSWnOUmYg/ aAmWH4AskdREZQW0GRs6yatKOr8pzi8lUzSILehQ1+JrS469ZEehPY66eojybpFjQcaFuQIATEL1G smkIGo30rk+3bnoIdEWQn1nLjOBIgeewLXNrg75mpVuaANWFym9dPQlraYGiex+6ZtpDlzK0zhsH7 gg0CCwD7Lm4LAl6tcmC5SfXNVMqLHF8K5kE4DTtyJH7QA5kQgpdP2kvB2Nl60FdgDIToKC+LbNfKV wFDsi20DA506bpZ3g2fAoooHoCR8x+iD2uAYipfJ048acaFGSssrrrtLZyxqZtV4oI1NgucOXF6vE xreUBIc5w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44794) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqF3Q-0000YM-At; Mon, 07 Jun 2021 14:12:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lqF3P-0005xU-Vc; Mon, 07 Jun 2021 14:12:31 +0100 Date: Mon, 7 Jun 2021 14:12:31 +0100 From: "Russell King (Oracle)" To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjarni Jonasson , Lars Povlsen Subject: Re: [PATCH net-next v3 04/10] net: sparx5: add port module support Message-ID: <20210607131231.GF22278@shell.armlinux.org.uk> References: <20210604085600.3014532-1-steen.hegelund@microchip.com> <20210604085600.3014532-5-steen.hegelund@microchip.com> <20210607092136.GA22278@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_061238_374519_656E50D1 X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jun 07, 2021 at 02:46:44PM +0200, Steen Hegelund wrote: > Hi Russell, > > Thanks for your comments. > > On Mon, 2021-06-07 at 10:21 +0100, Russell King (Oracle) wrote: > > It looks to me like the phylink code in your patch series is based on > > an older version of phylink and hasn't been updated for the split PCS > > support - you seem to be munging the PCS parts in with the MAC > > callbacks. If so, please update to the modern way of dealing with this. > > > > If that isn't the case, please explain why you are not using the split > > PCS support. > > I need to be able to let the user set the speed to get the link up. > > So far I have only been able to get the user configured speeds via the mac_ops, but if this is also > possible via the pcs_ops, there should not anything preventing me from using these ops instead. > > Will the pcs_ops also support this? I really don't understand what you're saying here, so I can't answer. What exactly do you mean "user configured speeds" ? Please give examples of exactly what you're wanting to do. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel