From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7276C47095 for ; Tue, 8 Jun 2021 03:12:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B21F60240 for ; Tue, 8 Jun 2021 03:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B21F60240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wv+CrOzFux8bv91LgXDtRCpl03p89aNWHW4DyzmKLTk=; b=lHLqOPGaI15usA GKzP9LJsI8K9trP8gAwdi510JION+nUWOepAH/rTjbVd8+VIz3+HHLodHWiiscRBsrfnMx3m/88gQ SrB9mcRa4TadELjmQxY0uvykiArJtut7SGTo+BKwYNI6+ZHP8rm+1qhv4Bz0fS35oZsB+KxUKM+oT Oco5m06FONwXdY9f1v75f7NrcgrSy2mjNwv4E6uI+B82eU8vsSHywcVEJkwR3uosxfLHLHL5Vblm4 nebQtAagpFCou4fDKz+BzXvUH33qtw0O49lk9/sI/YhfQ/O9OWvp74mKh5JCuQkY5zEdkXnbvzYCr z5msSwIoAX81vgikZ7MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqS8L-006D5c-3E; Tue, 08 Jun 2021 03:10:29 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqS8D-006D14-OH for linux-arm-kernel@bombadil.infradead.org; Tue, 08 Jun 2021 03:10:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1VEhzVmk5NUoOFMZfaMQYlMs28fEUDs6uxsxojma03A=; b=lSZRjqNDjnq3SVb8vW9QD3iwAp aPzi6uUElJJ/72YY/fZIfVfeZ9w5uwCjYxG4WsFbvF9uvzyfvD1X7maLSTLmo61UMQjhXJIZ0Q14T GqPxgnEn8IX85lMlppA6uD/ULMil2+N53mD0yRz6+7TH0QlBGDQUbfyl7Pw/ZUdzrKU8M9cvT3S/Q AY5KhgryNJYRrGulBOZJ5Iri1jDUMbWqljdrpOe/SyqlFO1gIZRuAQTD5KiXlOuMOC5By1aZxCtAG eLmY3MJ0xvwVHVPqjMhfJ/LPVjC5UI2239sU0WNDOVGk3uf5q1kTjGuslSjl4z/iHYuRm+PLzdLAj /VXr3Hsw==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lqRRt-00GTat-QN for linux-arm-kernel@lists.infradead.org; Tue, 08 Jun 2021 02:27:07 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1582BpMG065091; Tue, 8 Jun 2021 10:11:51 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 10:25:40 +0800 Date: Tue, 8 Jun 2021 10:25:32 +0800 From: Steven Lee To: Andrew Jeffery CC: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Billy Tsai Subject: Re: [PATCH v4 3/7] ARM: dts: aspeed-g6: Add SGPIO node. Message-ID: <20210608022531.GA2948@aspeedtech.com> References: <20210607071514.11727-1-steven_lee@aspeedtech.com> <20210607071514.11727-4-steven_lee@aspeedtech.com> <5277db96-4eb8-4794-a1fa-6a5bc40bffb7@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5277db96-4eb8-4794-a1fa-6a5bc40bffb7@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1582BpMG065091 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_032655_593857_34AC09CC X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 06/08/2021 07:28, Andrew Jeffery wrote: > On Mon, 7 Jun 2021, at 16:45, Steven Lee wrote: > > AST2600 supports 2 SGPIO master interfaces one with 128 pins another one > > with 80 pins. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-g6.dtsi | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > > index f96607b7b4e2..c09b24824b6d 100644 > > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > > @@ -377,6 +377,36 @@ > > #interrupt-cells = <2>; > > }; > > > > + sgpiom0: sgpiom@1e780500 { > > + #gpio-cells = <2>; > > + gpio-controller; > > + compatible = "aspeed,ast2600-sgpiom-128"; > > + reg = <0x1e780500 0x100>; > > + interrupts = ; > > + ngpios = <128>; > > Doesn't this affect the way the data is presented on the bus? > I add ngpios in aspeed-g6.dtsi as it can be overridden by dts files and driver won't return error if users only add status = "okay" in dts files without adding ngpios property. I will remove the property from aspeed-g6.dtsi if we don't need a default value for ngpios. > My understanding is this should be defined by each platform, not in the dtsi. Having said that, it appears it is specified in aspeed-g5.dtsi (as the value 8?). > I will remove the property from aspeed-g5 in a separate patch. Thanks, Steven > > + clocks = <&syscon ASPEED_CLK_APB2>; > > + interrupt-controller; > > + bus-frequency = <12000000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_sgpm1_default>; > > + status = "disabled"; > > + }; > > + > > + sgpiom1: sgpiom@1e780600 { > > + #gpio-cells = <2>; > > + gpio-controller; > > + compatible = "aspeed,ast2600-sgpiom-80"; > > + reg = <0x1e780600 0x100>; > > + interrupts = ; > > + ngpios = <80>; > > As above. > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel