From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D5EC47082 for ; Tue, 8 Jun 2021 08:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57E346101A for ; Tue, 8 Jun 2021 08:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57E346101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o+SXsLvWya49W835v6CjrBMjRRqen8FhBPuVYjKzaxw=; b=lKptvewFVARnVM LBQ3CsPGdwD8c4eitmj+CYu3l2dgbqSsFgR7AHt7XF03572Il6W8lFcg2h2089BDBngjVQt/xyU2g juSUKzopp/Y7l3pcIHFY5scQR/KnwoyXsUYApPA7wVfn1XJpoR4Mi3HUx7i1w7BZ3P7dmQY61Mhko QGDz7P5/hOGeAs3CEPf42dfB9C34348wZ1UW12BPtQjtyHn04ZESimtgewvJC4tA7Kr82Vc1XcYNU pPh4Nc7UqphHqH62us+sK9Rg7/OY2d0DfQWBCFJoeWMe5MOeFkJ1qFoqj7Ij4+ot/9w2z0Tz49k1W G1zwTMd0Ats226heTK1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqXXz-007Dbz-Fk; Tue, 08 Jun 2021 08:57:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqXXv-007DaS-91 for linux-arm-kernel@lists.infradead.org; Tue, 08 Jun 2021 08:57:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCA1E12FC; Tue, 8 Jun 2021 01:57:12 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.5.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74B023F719; Tue, 8 Jun 2021 01:57:08 -0700 (PDT) Date: Tue, 8 Jun 2021 09:57:00 +0100 From: Mark Rutland To: Arnd Bergmann Cc: Maxime Ripard , Will Deacon , emma@anholt.net, Marek Szyprowski , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, Catalin Marinas , Ard Biesheuvel , Vincent Whitchurch , Bartlomiej Zolnierkiewicz , dri-devel Subject: Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) Message-ID: <20210608085700.GA9741@C02TD0UTHF1T.local> References: <20210602135123.GD12753@C02TD0UTHF1T.local> <130ce34f-460a-0046-f722-00144f2d5502@samsung.com> <20210604100114.GC64162@C02TD0UTHF1T.local> <0d10411d-49fe-fbca-0479-e2983af16aa8@samsung.com> <20210607120118.GC97489@C02TD0UTHF1T.local> <20210607130859.GD97489@C02TD0UTHF1T.local> <20210607133953.GB7330@willie-the-truck> <20210607151740.moncryl5zv3ahq4s@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_015715_389189_F6499298 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 07, 2021 at 05:50:57PM +0200, Arnd Bergmann wrote: > On Mon, Jun 7, 2021 at 5:17 PM Maxime Ripard wrote: > > On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > > > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > > On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote: > > > > > On Mon, Jun 07, 2021 at 01:01:18PM +0100, Mark Rutland wrote: > > > > > > On Mon, Jun 07, 2021 at 11:58:32AM +0200, Marek Szyprowski wrote: > > > I notice that it checks index 'fifos_state[channel].in_use', but then > > > uses a different index 'i' for looking at the 'pending_commit' field > > > beyond the end of the array. > > > > > > This code was introduced by Maxime Ripard in commit 9ec03d7f1ed3 > > > ("drm/vc4: kms: Wait on previous FIFO users before a commit"). > > > > Awesome, I tried to find out that bug a few weeks ago but couldn't > > reproduce the KASAN spat. You're right, it should be channel here > > instead of i. Since you did the whole work, do you want to send the > > patch? > > Marek and Mark did most of the work finding the problem, I just looked > in the right place a few times (and a bit in the wrong place). I'd suggest > you send that patch with the corresponding Reported-by/Analyzed-by/ > Tested-by tags. I've sent: https://lore.kernel.org/r/20210608085513.2069-1-mark.rutland@arm.com Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel