From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF52C4743D for ; Wed, 9 Jun 2021 03:14:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D750C6128A for ; Wed, 9 Jun 2021 03:14:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D750C6128A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iZGn8QA9fXKbncspihCZKmNN6S16DGj2Hlcf+q7ogG4=; b=pe3fFy6MK1HMlk /i/jhhCqDF4NmdRV0f4M7K0zSoYpYq1QvTC5xVDMJKFSYxx1PmDt8HGiNb78c9CMNsiF7UZnI72YN niGnoMYgv9daTM7gvDJEKo4ZX76MjhZ9Z8/SKPFBGvZQKZGcHDdZTrwlW4OFjMi036KCYXwxMg3nY A3YIpookkFwWrPan4qMQY7e+lmz7QojPRhVueDjfb4/haXCAzWM3JOaEX+H+x8E85188wXrjj1+xx rmwfMqICX5btS0LhBNH3Wp+KI4Zck6gB+NHFeMcDI/g7yzg9XRixyO2IFkndreQ+unL5hJjzsdsg5 bWn2pdL3i4W3LkT/552Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqobZ-00BXQk-MC; Wed, 09 Jun 2021 03:10:09 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqobX-00BXQV-NP for linux-arm-kernel@bombadil.infradead.org; Wed, 09 Jun 2021 03:10:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oHJTxC8oenDuxUkkWAD1c+knFps4ac5mBYEkB7UKxls=; b=wIBfjzr4tNzYS6u4u1kf2S/HIi s+NFW1lZi4S9sK0vqHbCpMZU2VnyoYk93+NejIXUDrEBnI0Esk3hjj6uELCzWruK+yXGiAb68JxOu ZSaXwuwKvWMXhv8ruiqsMNby/FKKRO6a3aJJFx7KEbH/X4doNCQr/CKt3NkeoF6lOB3r4YXPPa4I4 HkDMk5BaWHJxW9/nv6+8BZGD/IKBwiU/h00FEH8/PcSqPmiG1pyRDlqgXNwdzF4TTS5csTwdvQLpm atWcaqhSJoEQikmrSb9rbX764Q+q7kj0Rzbexnqn5EA36MzdKP3oO3ZuEkbMnLt0jzPRJUVX30gJc 8M/gjR+Q==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lqnPE-0001xr-7O for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 01:53:29 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1591c2nC096728; Wed, 9 Jun 2021 09:38:02 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 9 Jun 2021 09:51:53 +0800 Date: Wed, 9 Jun 2021 09:51:49 +0800 From: Steven Lee To: Andrew Jeffery CC: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Billy Tsai Subject: Re: [PATCH v5 03/10] ARM: dts: aspeed-g6: Add SGPIO node. Message-ID: <20210609015148.GA14839@aspeedtech.com> References: <20210608102547.4880-1-steven_lee@aspeedtech.com> <20210608102547.4880-4-steven_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1591c2nC096728 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_025326_872661_5876AAB1 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 06/09/2021 08:43, Andrew Jeffery wrote: > > > On Tue, 8 Jun 2021, at 19:55, Steven Lee wrote: > > AST2600 supports 2 SGPIO master interfaces one with 128 pins another one > > with 80 pins. > > > > Signed-off-by: Steven Lee > > --- > > arch/arm/boot/dts/aspeed-g6.dtsi | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > > index f96607b7b4e2..c55baaf94314 100644 > > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > > @@ -377,6 +377,34 @@ > > #interrupt-cells = <2>; > > }; > > > > + sgpiom0: sgpiom@1e780500 { > > + #gpio-cells = <2>; > > + gpio-controller; > > + compatible = "aspeed,ast2600-sgpiom-128"; > > + reg = <0x1e780500 0x100>; > > + interrupts = ; > > + clocks = <&syscon ASPEED_CLK_APB2>; > > The example in the binding document used ASPEED_CLK_APB. Which is correct? I assume ASPEED_CLK_APB2? > The example in the binding document is for aspeed-g5. aspeed-g5 and aspeed-g6 use different clocks. Should I add a new patch for adding an example for aspeed-g6? > > + interrupt-controller; > > + bus-frequency = <12000000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_sgpm1_default>; > > + status = "disabled"; > > + }; > > + > > + sgpiom1: sgpiom@1e780600 { > > + #gpio-cells = <2>; > > + gpio-controller; > > + compatible = "aspeed,ast2600-sgpiom-80"; > > + reg = <0x1e780600 0x100>; > > + interrupts = ; > > + clocks = <&syscon ASPEED_CLK_APB2>; > > + interrupt-controller; > > + bus-frequency = <12000000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_sgpm2_default>; > > + status = "disabled"; > > + }; > > + > > gpio1: gpio@1e780800 { > > #gpio-cells = <2>; > > gpio-controller; > > -- > > 2.17.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel