From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5849CC47094 for ; Thu, 10 Jun 2021 09:53:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13D99613C1 for ; Thu, 10 Jun 2021 09:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13D99613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MjXOTw3uhdZwlR2ZLx5waJQKxFLB+2SFQqfc2/75wKQ=; b=yhLetqaRwVbpky SoaRfQCDuTppEO/D2oWrT2jhSvmzeOqafQkEyK/4MmndqplKhqwyJGZRkK9K0JXn6guyKoc+LDw0U Ub1JtYp+bcFA5Wm950cAavuj9pHB8J4+Q4DOAlmJpgy9yo7Swb98RdkYl4L72DsmG7YaAXACIYJfe cjolisOyYCz3OavZHhKNuO7ZwR/IcALBdqTomfQ1ad0k42bHeiEaoggfNNXT7MqSGs1deLd/rE1Vg /mZRh6ZZ3lb0na0eWVz3cCI7rzmwhgiYpjGIL6ABpdxnUvg2V6foj4bqVcNOGrVwq0k6lL39rzIQQ 204jZD8ESwmLkeaJLjFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrHLm-000JMn-OX; Thu, 10 Jun 2021 09:51:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrH91-000EH5-62 for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 09:38:36 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 63E7E613E3; Thu, 10 Jun 2021 09:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623317914; bh=H0ZhLfr/5Hg/IZlJSy+dpLmyl0DCA+2od95bDkRhhnY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RI0mhbUXHuKpeEbO9MAxYjA8RKfjDQf1lEw+dbXcDpKRbNBnpp/W1apVaWbK5KuoK jLPU8IIzH24YvfPJXsMU8mfbAqP0e9nbh2VMjLw1UJ+F8LxF4ZNXTYfcIe+orZf0Gq T8RnL8mPkQ2ovbgVtkrTwvEIRGnyrwC9FLv8gdyoCz6GeiY4jn+a0E7u8fD3lQ7Iz5 LXRjwrUf8qn0/7B5ukhu16vHExHUApTrqbw0/Ho/YtPtgTwh8Ys2EA2VLNTWETL86e IuiiQH2W6JWMX+p2z1idS4A7ZYF2wW0cGzSwAD64FXrHMVKhfhWm6Uq/hTIHO8wMuv ZM6GhiGSMkI+g== Date: Thu, 10 Jun 2021 11:38:27 +0200 From: Mauro Carvalho Chehab To: Subject: Re: [PATCH 08/25] media: atmel: properly get pm_runtime Message-ID: <20210610113827.57db9e77@coco.lan> In-Reply-To: References: <975645970144b6c8401ab9bd1243619978a868a9.1620207353.git.mchehab+huawei@kernel.org> <20210505130835.000006b7@Huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_023835_314524_E61B28A4 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, Ludovic.Desroches@microchip.com, Jonathan.Cameron@Huawei.com, mauro.chehab@huawei.com, mchehab@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, 10 Jun 2021 09:04:07 +0000 escreveu: > >> diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c > >> index fe3ec8d0eaee..ce8e1351fa53 100644 > >> --- a/drivers/media/platform/atmel/atmel-isc-base.c > >> +++ b/drivers/media/platform/atmel/atmel-isc-base.c > >> @@ -294,9 +294,13 @@ static int isc_wait_clk_stable(struct clk_hw *hw) > >> static int isc_clk_prepare(struct clk_hw *hw) > >> { > >> struct isc_clk *isc_clk = to_isc_clk(hw); > >> + int ret; > >> > >> - if (isc_clk->id == ISC_ISPCK) > >> - pm_runtime_get_sync(isc_clk->dev); > >> + if (isc_clk->id == ISC_ISPCK) { > >> + ret = pm_runtime_resume_and_get(isc_clk->dev); > >> + if (ret < 0) > >> + return ret; > >> + } > > Hi Mauro, > > With this patch, the ISC is broken on latest media tree. It looks like > pm_runtime_resume_and_get for the ISC_ISPCK clock returns -ENOACCESS and > thus, the probe of the driver fails: > > atmel-sama5d2-isc f0008000.isc: failed to enable ispck: -13 > atmel-sama5d2-isc: probe of f0008000.isc failed with error -13 > > > Could you point out how I could fix this ? Maybe the isc_clk->dev is not > properly handled/initialized in some other part of the code ? Looking at RPM implementation: static int rpm_resume(struct device *dev, int rpmflags) { ... if (dev->power.runtime_error) retval = -EINVAL; else if (dev->power.disable_depth == 1 && dev->power.is_suspended && dev->power.runtime_status == RPM_ACTIVE) retval = 1; else if (dev->power.disable_depth > 0) retval = -EACCES; ... It sounds that RPM is disabled for this clock. Did you call pm_runtime_enable() before calling isc_clk_prepare()? Thanks, Mauro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel