From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D03C47094 for ; Thu, 10 Jun 2021 17:00:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBE68601FA for ; Thu, 10 Jun 2021 17:00:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBE68601FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ew36b+jHuDesb5E06KVac5RytaLPMk3zEaVGrcTOrMk=; b=evQE2Q/KHvJZKZ 5POZFVwHuBh8WRXEhAgrPKSy/EqAuh6cBZkCbUaktxeAFxrLD4N7ffZF9F5nB8eTeEQmBl69+y8JH IOhYVFwLgORrna7/vT3ab+HWJEyCgnr+8LSZMyJNA7kw4H5geqhdgpEF+bcZUnaFW4E1hGyfvnnnT q57S/Q5d1uD0lWdlJV2YDRXWN13EIqUpSbd1n0HiipvT1H7TAnkvNwO6kOJjzaAZgyAQlh5OviEw2 hn399WxK7bmtohooyEMVkEsLAtTGWOVKU1CUqRF8nk/EYiV0dhp2zwWNv0I5P3/17Zn6e9ePLHCWA UwMUhnXPN9BkBggdpymw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNzx-001prA-39; Thu, 10 Jun 2021 16:57:42 +0000 Received: from mail-ot1-f43.google.com ([209.85.210.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrNvF-001oCU-0M for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 16:52:51 +0000 Received: by mail-ot1-f43.google.com with SMTP id 102-20020a9d0eef0000b02903fccc5b733fso351263otj.4 for ; Thu, 10 Jun 2021 09:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xmSSSTzI1G/+6aJZJ8BoKiXXr7B+qXzntJBgHmeug3Y=; b=U7XLVVTiGx2SNwz4AoETEg52Gf2kgWvjmM271mMF+vjgMAKh2LF87gb7N46BgPSZoi Z0LxPbEj4mysIsgqmiaTFPl5/naB0Wz8cRXaO8Tq4YrrE/fo4O+2W/ESjx9DuHZU7yk7 A3NFuvy0hBGVxeugBaSLKQIWu6rhGpkIf8E9hYTsQ18j6/fJ5lQxC0U9aJK1fIss7bMM Lhu6rQRL3jitb0J7BsxIJL53Vdo90Hw6NIJrW/D0HGD5js4HE42I57PLmUUUqFIryqsh QHBxXiedxdUsM1FxJz6LU7S8n8A3oxAKWGp6ewGeRywr1rW1TtvzDPOS7VGb4Iprouyg HjOg== X-Gm-Message-State: AOAM530pxEQ4DBe4gkwoJeQLBI+5WBx5OGoCCCSnvCwJ16ufM6WK5t6M Wzb9jUfCj7d8Ua7ccw0FIGxLbNyBOQ== X-Google-Smtp-Source: ABdhPJyxJx2yyoRpM5CWFF+cVvOk3Yz7iEbL+70+P4FScA/iA6sbd53xkBffuUIqKvda7xsVEg0IYQ== X-Received: by 2002:a9d:6d0e:: with SMTP id o14mr3267889otp.90.1623343968019; Thu, 10 Jun 2021 09:52:48 -0700 (PDT) Received: from robh.at.kernel.org ([172.58.99.113]) by smtp.gmail.com with ESMTPSA id t15sm643045oie.14.2021.06.10.09.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 09:52:47 -0700 (PDT) Received: (nullmailer pid 1955270 invoked by uid 1000); Thu, 10 Jun 2021 16:52:44 -0000 Date: Thu, 10 Jun 2021 11:52:44 -0500 From: Rob Herring To: Sven Peter Cc: Will Deacon , Robin Murphy , Joerg Roedel , Arnd Bergmann , devicetree@vger.kernel.org, Hector Martin , linux-kernel@vger.kernel.org, Marc Zyngier , Mohamed Mediouni , Stan Skowronek , linux-arm-kernel@lists.infradead.org, Mark Kettenis , iommu@lists.linux-foundation.org, Alexander Graf Subject: Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings Message-ID: <20210610165244.GA1948260@robh.at.kernel.org> References: <20210603085003.50465-1-sven@svenpeter.dev> <20210603085003.50465-3-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210603085003.50465-3-sven@svenpeter.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_095249_094743_2F915EDC X-CRM114-Status: GOOD ( 22.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote: > DART (Device Address Resolution Table) is the iommu found on Apple > ARM SoCs such as the M1. > > Signed-off-by: Sven Peter > --- > .../devicetree/bindings/iommu/apple,dart.yaml | 81 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iommu/apple,dart.yaml > > diff --git a/Documentation/devicetree/bindings/iommu/apple,dart.yaml b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > new file mode 100644 > index 000000000000..db21ca07d121 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iommu/apple,dart.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iommu/apple,dart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple DART IOMMU > + > +maintainers: > + - Sven Peter > + > +description: |+ > + Apple SoCs may contain an implementation of their Device Address > + Resolution Table which provides a mandatory layer of address > + translations for various masters. > + > + Each DART instance is capable of handling up to 16 different streams > + with individual pagetables and page-level read/write protection flags. > + > + This DART IOMMU also raises interrupts in response to various > + fault conditions. > + > +properties: > + compatible: > + const: apple,t8103-dart > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: > + Reference to the gate clock phandle if required for this IOMMU. > + Optional since not all IOMMUs are attached to a clock gate. > + > + '#iommu-cells': > + const: 1 > + description: > + Has to be one. The single cell describes the stream id emitted by > + a master to the IOMMU. > + > +required: > + - compatible > + - reg > + - '#iommu-cells' > + - interrupts > + > +additionalProperties: false > + > +examples: > + - |+ > + dart1: iommu@82f80000 { > + compatible = "apple,t8103-dart"; > + reg = <0x82f80000 0x4000>; > + interrupts = <1 781 4>; > + #iommu-cells = <1>; > + }; > + > + master1 { > + iommus = <&{/dart1} 0>; /dart1 is a path, but 'dart1' is a label. You need '&dart1' (or '&{/iommu@82f80000}' but that doesn't really work here because the examples get prefixed with /example-n/...) With that fixed, Reviewed-by: Rob Herring > + }; > + > + - |+ > + dart2a: iommu@82f00000 { > + compatible = "apple,t8103-dart"; > + reg = <0x82f00000 0x4000>; > + interrupts = <1 781 4>; > + #iommu-cells = <1>; > + }; > + dart2b: iommu@82f80000 { > + compatible = "apple,t8103-dart"; > + reg = <0x82f80000 0x4000>; > + interrupts = <1 781 4>; > + #iommu-cells = <1>; > + }; > + > + master2 { > + iommus = <&{/dart2a} 0>, <&{/dart2b} 1>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 673cadd5107a..4373d63f9ccf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1240,6 +1240,12 @@ L: linux-input@vger.kernel.org > S: Odd fixes > F: drivers/input/mouse/bcm5974.c > > +APPLE DART IOMMU DRIVER > +M: Sven Peter > +L: iommu@lists.linux-foundation.org > +S: Maintained > +F: Documentation/devicetree/bindings/iommu/apple,dart.yaml > + > APPLE SMC DRIVER > M: Henrik Rydberg > L: linux-hwmon@vger.kernel.org > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel