From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D08C48BE5 for ; Fri, 11 Jun 2021 07:16:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0D4661364 for ; Fri, 11 Jun 2021 07:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0D4661364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MH+QLOHXrb/yv1I99NN9NmEiMM54RocWjWIKLQkrSNU=; b=oE1RATo2iF2Sm1 ASBzQUKIVFbG4TRFLhU4U7/FZ6lnVIYe/SkoOD2LwMTsJMdtngubbBSbT2B2OhDR1kCw1KYY/cJ1I PnRMib6u5hhTP8JILhWDdcLH8F/vZrf7KVu79Y+kJzgQGlJYAhV8XlSx+BoyK5B40IQYJQcArwZGZ iq/w2wiwwrrxq5gv+mUMtbYW0G+ULI844xI/A5KdiZkGS9u6a9UNynyF3c2quclmMk5EVGKd8si87 VHaoGW7ul8k+kldXFCSl62yeI6ykbIbwgzbaBjHVITeizooRdwjoJErFlcA3dEpu6KC5mEnj2gbPn HIViWF+U2cu5WOyzLNlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbN9-0046Nk-9H; Fri, 11 Jun 2021 07:14:31 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbN5-0046MO-IQ; Fri, 11 Jun 2021 07:14:28 +0000 Received: by mail-ed1-x52a.google.com with SMTP id ba2so34195772edb.2; Fri, 11 Jun 2021 00:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bIXUmcz0475283/uMOiisZMWlRUta5WeCtmUMaqN56g=; b=ecqbOYYVy7yWEVZKERSBjadHIuKhPGtC74g3WhlwcyWIj/JxdctZD3Au0B/q8y/UsI kmCORpQOu9HhrM6G5G0Vur/QxY1ghqvQRi2FVmAxAVCkwFAsYiRICI3MNxojomNo0vyP ZS2CbK6Gn3tL0ZKc6BeS/3LwqCxMM6EBfLZfD8dM50/a4pHBTIT4iv04E05biOw2QpRP XdcL/ls8YAgFGD0m0QgAbvAyVNAiUzSrswYm3QXWSPV04Hk14PHthNi4QH7T/R5dcotv KcrPOD6GAWTly6qIy2xQX0RBpeNQO+GqT8BUBTGXTdTtCogLEy+84l4vkZGP7BhDZv14 i6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bIXUmcz0475283/uMOiisZMWlRUta5WeCtmUMaqN56g=; b=SRzhgr1HICm7WpYyoF9fcBVifzxNbhulXrlxdX5C39aY7wlRLg5jjPUwU0vaPjD3De GHFHTYFfX2NB0z8/cXqt5OIgUIVDLTfzsxaLXmsYgWZUVX9Ohb/Ey0ohRUBx5QqsBwxc tlWDBum2afQu4i9t9RaazJFTHXX37YXvW9gJEr0Vwl/r0kRKBps2TRfN/f7rYpx9cK4G y67uFX59jtYLEMJpTBcZxkCx/ojCFkVnzCH4vI1kWXT85GeCqtAQUX9Is7+UPxPhzsnI tOFWVj5LGcjC/cyTMYXsi2Ds0jxG8sCb7Cywe6ZA4yQqdgatclKzM5JE0bzTievIkDni WWVQ== X-Gm-Message-State: AOAM5303p+L0U3oa1TAEKXcorzDxiYG0R9VQWdfSX8tfKyvOhg1lXhv/ 92D8XXrS3+ffUEvWI6yUOsOyimkTD4I= X-Google-Smtp-Source: ABdhPJz3xPPBl6k78Xi9P1zutkk7QbFlLnSMDn5+tRQMxJsIOscJVy4VeCdwULHnEEMAT424hNaeeQ== X-Received: by 2002:aa7:dc12:: with SMTP id b18mr2216461edu.52.1623395665330; Fri, 11 Jun 2021 00:14:25 -0700 (PDT) Received: from BV030612LT ([188.24.178.25]) by smtp.gmail.com with ESMTPSA id q20sm1833645ejb.71.2021.06.11.00.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 00:14:24 -0700 (PDT) Date: Fri, 11 Jun 2021 10:14:22 +0300 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support Message-ID: <20210611071422.GB1520454@BV030612LT> References: <632e12c445ced7f10e6d7240162484ae5afc148e.1623358117.git.cristian.ciocaltea@gmail.com> <20210611055606.GB6950@thinkpad> <20210611063147.GA1520454@BV030612LT> <20210611063940.GD6950@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611063940.GD6950@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_001427_636472_E699E6C3 X-CRM114-Status: GOOD ( 25.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 12:09:40PM +0530, Manivannan Sadhasivam wrote: > On Fri, Jun 11, 2021 at 09:31:47AM +0300, Cristian Ciocaltea wrote: > > On Fri, Jun 11, 2021 at 11:26:06AM +0530, Manivannan Sadhasivam wrote: > > > On Fri, Jun 11, 2021 at 12:09:22AM +0300, Cristian Ciocaltea wrote: > > > > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > > > > SBC. Additionally, provide the necessary properties for the generic S500 > > > > ethernet node in order to setup PHY and MDIO. > > > > > > > > Signed-off-by: Cristian Ciocaltea > > > > --- > > > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 56 ++++++++++++++++++++++ > > > > 1 file changed, 56 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > > index b8c5db2344aa..bffabc7eaa50 100644 > > > > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > [...] > > > > > + mdio { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > > > > + reset-delay-us = <10000>; > > > > + reset-post-delay-us = <150000>; > > > > > > reset-* properties belong to "ethernet-phy" node. Also, while adding new nodes > > > please run the dtbs_check and try to address the warnings. > > > > The properties are those described in Documentation/devicetree/bindings/net/mdio.yaml > > Do you mean the reset properties are applicable for all PHYs in this SoC? Actually there is only one PHY connected. I've also checked the vendor code and didn't notice any special handling for the PHY reset. > > The dtbs_check doesn't report any issues in my case, usually this > > happens when dtschema is not updated to the latest version. I always > > run the following command after rebasing to a new kernel version: > > > > pip3 install --upgrade dtschema > > > > That's good! > > Thanks, > Mani > > > Thanks for the review, > > Cristi > > > > > Thanks, > > > Mani > > > > > > > + > > > > + eth_phy: ethernet-phy@3 { > > > > + reg = <0x3>; > > > > + max-speed = <100>; > > > > + interrupt-parent = <&sirq>; > > > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > &twd_timer { > > > > status = "okay"; > > > > }; > > > > -- > > > > 2.32.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel