From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336D8C48BE0 for ; Fri, 11 Jun 2021 09:19:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6404613CA for ; Fri, 11 Jun 2021 09:19:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6404613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uF/eerm8G/FvRqPAlLONCbiUtCEo9vU0Cx0nR6OrF+E=; b=KJvTIpOjDpzgvb cC0YCwssO4SBtOCySB1is7HPEwfgVpZa0l2mkymT0TepxodH1mNGjJFeJBSXHAaH3G49i8+HOVDtU kTzLismNOKe5lP7+F6AFnB73ZuA175bw7ntTTYNMLoVEjxWc1tJyjbZkmGno64YOOM0yHN1ZKYPgP 6qwHw9MTV/RkicLXjtKHv3FuKiutJ1RVAn2BlwbTF0P3IFUiYjUFDYFebpMfaUA3h43wFc3K9YXbM 3f8To6eDPr4eQbKHAFWG5beGZdy+pjzUclmNVieoZfEVTvw6NdWftjj2VfRPQa8dNuwzINspRWALQ bR0DIL8mA3WmY/Sp8B2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrdIJ-004ULy-Qt; Fri, 11 Jun 2021 09:17:40 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrdIG-004UL7-UE for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 09:17:38 +0000 Received: by mail-ej1-x636.google.com with SMTP id g8so3567524ejx.1 for ; Fri, 11 Jun 2021 02:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tT/Yhme4HpUxJW8MmdpDHTWwIDpMbpzEcGbpZ+AnSGE=; b=oqrGz3C4XTzBWyPPlCOe7wKQomXhQCEyJTjuBZuI5ImLQ3TJD4Vh/LWqTMpeJ9iQXm 4z++kNx0JE0vNMMXFfs6ozDm+zULaVpgIlZlb4zwvkrSeoIGtSiM1DYZu4PWz2Cr0wSm iB7LMHcATjL+sRL/4cnQVBXvLnnnyyPCjZBojIRZ4/tqldOsJaae+EZtMYIoOu7ddbtC +uiWcGCT0p5NbuBNhAQ+HsCUWyqmStS2JTVxA0h7pkXH331RNXNmjCwyTrLdsaHCeEmE lj8BMQw5Y4VBsEnDXusm65/nFHwQgwQhuvhtfPfkbZd6xMr+xTsqkhyTZn/G6m3Fxso4 CxDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tT/Yhme4HpUxJW8MmdpDHTWwIDpMbpzEcGbpZ+AnSGE=; b=diw5O7YOVTohwBOnuViHOEBhTsNR99163Bgo9ovAcCeWE5mZR6vl9IFebQ+I+6Nsee 8and112NVUESkH8YllHrd/gprvAIoOm+nNxOMyJU0VpZQDxXOERX33qxx9LF7603rQI9 gXGkoWGxK5HJCHEpqtYn43RPJ2ePJ8XFZo5ELOg1e3cgJYU1gNaBKX9PuBfMsF/vTT0j xbPulu9kXNI4Ht8HFLTmtaIwtcjxsmL90djGeQ3fMA3OPM+/g2JrBpe8udmWH1kP5MyC 2MWVJgIFby2oICQKsufJ0n3VRjqx4BOcv78XKDFyOqVGLLlY1yv8XJNo5gRNI0mysPcq gxNw== X-Gm-Message-State: AOAM5330l3JgW8AmWMwBTxha3qKGY5bfhG32sKQESyXHBdf1vpPxLz2s 2NSqz8FSJi0MV8D/lh7AXOU= X-Google-Smtp-Source: ABdhPJxL1EBhK72LCCLBXOmmSrmvpfplT+xDm4HCNYeQEmXEWq0ih+Xhk9nUoE0D3oE45Uf22v7chQ== X-Received: by 2002:a17:906:c010:: with SMTP id e16mr2793715ejz.214.1623403055047; Fri, 11 Jun 2021 02:17:35 -0700 (PDT) Received: from skbuf ([188.26.52.84]) by smtp.gmail.com with ESMTPSA id dy19sm2337908edb.68.2021.06.11.02.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 02:17:34 -0700 (PDT) From: Ioana Ciornei X-Google-Original-From: Ioana Ciornei Date: Fri, 11 Jun 2021 12:17:32 +0300 To: Andy Shevchenko Cc: Ioana Ciornei , Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Calvin Johnson , Cristi Sovaiala , Florin Laurentiu Chiculita , Madalin Bucur , linux-arm Mailing List , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , "linux.cj" , netdev , Laurentiu Tudor , Len Brown , "Rafael J . Wysocki" , Ioana Ciornei Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver Message-ID: <20210611091732.wms3g3mnghvmcw3n@skbuf> References: <20210610163917.4138412-1-ciorneiioana@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_021737_017969_1E90E0F0 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 12:00:02PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei wrote: > > > > From: Ioana Ciornei > > > > This patch set provides ACPI support to DPAA2 network drivers. > > > > It also introduces new fwnode based APIs to support phylink and phy > > layers > > Following functions are defined: > > phylink_fwnode_phy_connect() > > fwnode_mdiobus_register_phy() > > fwnode_get_phy_id() > > fwnode_phy_find_device() > > device_phy_find_device() > > fwnode_get_phy_node() > > fwnode_mdio_find_device() > > acpi_get_local_address() > > > > First one helps in connecting phy to phylink instance. > > Next three helps in getting phy_id and registering phy to mdiobus > > Next two help in finding a phy on a mdiobus. > > Next one helps in getting phy_node from a fwnode. > > Last one is used to get local address from _ADR object. > > > > Corresponding OF functions are refactored. > > In general it looks fine to me. What really worries me is the calls like > > of_foo -> fwnode_bar -> of_baz. > > As I have commented in one patch the idea of fwnode APIs is to have a > common ground for all resource providers. So, at the end it shouldn't > be a chain of calls like above mentioned. Either fix the name (so, the > first one will be in fwnode or device namespace) or fix the API that > it will be fwnode/device API. These types of cyclic calls do not exist anymore. The fwnode_mdio does not call back into of_mdio but instead it directly implements any necessary operations using the fwnode_handle. The only calls happening are 'of_mdio -> fwnode_mdio' so that we leverage the common fwnode handling and do not duplicate code. Ioana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel