From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD05C48BCF for ; Sat, 12 Jun 2021 03:29:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B26061073 for ; Sat, 12 Jun 2021 03:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B26061073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T7mBsOtw66u28byHZRdoDZDm+swEyf/QkPLHlKUq9Cc=; b=RyD+YeVcny/liS qDJazYvV5uNLXpgUyd0LXME1wht04Yc9/17dcaY0UvrHwFkxl+LNyPya/lgz2xYmfsosIAxhBDVFZ tCXA1rrZYIZBQ7tnRWCDK0bx5B+ctf1ATZOf3teCBNBP49IK7Y5iJ1Pq4++FWHSk2jbtUs4LSF1sh 9+7Urdi19IecnekwTgl2flsjW/7gSrq6wvgkHFMJbOAeqlTGArxY4fqeV5sKhweY+SVsRBfrisdbr K3bXazEBS+yljeZR3L7vGL247dbuHKdkkU0FGSC6q/2f3MoV/kjYjqmoeNOh/L/57KJcW3N4Pbq3+ KvDgsrEw3Y8GR8053vEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lruJ7-007gOS-K3; Sat, 12 Jun 2021 03:27:37 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lruJ3-007gNR-IF for linux-arm-kernel@lists.infradead.org; Sat, 12 Jun 2021 03:27:34 +0000 Received: by mail-pj1-x1036.google.com with SMTP id md2-20020a17090b23c2b029016de4440381so7058297pjb.1 for ; Fri, 11 Jun 2021 20:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wMbJzEFA4rizeAED4h0yeaNqBh4tC+L5roFT//ohrj0=; b=X5FQFhk4+/SkVAlz4VPwkLe6H0Ir6Dir/Hy625SgB2RA0op3Kd/4UsRqRLCbAKCoOx DuV67LDfpukyDdxC8Sv6272FEQqvkMjjjwRYm+M6Ck/g4NXuWx/3aMIBX9NTLSp3kXFf 8y21X5nKs4ZtFw4Hzdx/0f2/j8FD1OeA8/tsF2JatUOrGExLVPhnKBQXaSrg2ZUIrAuM 2U01NxNYsn70PIaNHN+XSl+HepOqAqvuBXf5aEOT0ffP+aadqkAJ7FGtkWiefLBhbDAL csMZ4qWtK2g2/2BzDzdd7jCZPiyeJpys5Xg5xNnz7BMavZkBxz01MhkKOBWDJl7XqVwj MKwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wMbJzEFA4rizeAED4h0yeaNqBh4tC+L5roFT//ohrj0=; b=FWeAHkm1ovu+D5UNO3oveyDdGaM5uiMAgDdgaSNH0w7X/18wFIWSaWap+bWBxqaPUy PNQplth5p98H8sA66qBibqvifC5a30VKlD/diFRlA2p1gaSvO24cal6Ex0S6XoNbMvd5 J6sl8Dz125RHa5kryvDqj1L2/3OjhvMIQBfK85WifWGeTP51gadvHG/iOo70rQbWe9po euGCX0mfXogzy2CRpQ9YreMIG9P2Wi2mRqIZdfp2vGLcUIuNx/2xM07CahGke39l35MC +kJYvfrkU1hkhZRUJLPDXBEOFVHx1t/W12su0AhIvXI/0kh/VAik3BGwuIKWsUPljPHk 7FeA== X-Gm-Message-State: AOAM532zF434Sy/lSHR5/JW41WQz4MXVPZqsvH2ongL+L1KHX+OBulpf GRT0Lnqlo2YmaDRddM/oRKVrnLtXDn2yzA== X-Google-Smtp-Source: ABdhPJytUShYTPDharDBywS2Z7+9/SAE4GGzuMWqdRZhU84lmAt50glv7oQXNpqThsQEZhK1FhfJ7w== X-Received: by 2002:a17:90a:f291:: with SMTP id fs17mr12148977pjb.8.1623468447896; Fri, 11 Jun 2021 20:27:27 -0700 (PDT) Received: from leoy-ThinkPad-X240s (ec2-18-167-84-74.ap-east-1.compute.amazonaws.com. [18.167.84.74]) by smtp.gmail.com with ESMTPSA id c130sm6176886pfc.51.2021.06.11.20.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 20:27:27 -0700 (PDT) Date: Sat, 12 Jun 2021 11:27:21 +0800 From: Leo Yan To: Denis Nikitin Cc: Suzuki K Poulose , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Daniel Kiss , Coresight ML , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v1 0/3] coresight: Fix for snapshot mode Message-ID: <20210612032721.GB36748@leoy-ThinkPad-X240s> References: <20210528161552.654907-1-leo.yan@linaro.org> <5cf3effb-fccc-9385-6328-6d1e2e5ccdf3@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_202733_659349_C30A3E98 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 01:31:41AM -0700, Denis Nikitin wrote: > Hi Suzuki, > > On Thu, Jun 10, 2021 at 9:04 AM Suzuki K Poulose wrote: > > > [...] > > > > Are you able to confirm if the patch 3 alone fixes the above issue ? > > I am not convinced that Patch 1 is necessary. > > > > Yes. "perf cs-etm: Remove callback cs_etm_find_snapshot()" alone fixes > the issue. Based on current testing result, we should give high priority for patches 2 and 3. The patch 1 is controversial for how to handle the trace data kept in multiple AUX buffers; essentially it's up to how we understand the snapshot definition. I confirmed Intel-PT and CoreSight have the same behaviour for capturing trace data from multiple AUX ring buffers when snapshot occurs. I'd like to leave patch 1/3 out, and resend it if we get conclusion. At the meantime, @Denis, if you have observed any profiling result (or profiling quality) difference caused by patch 1, the feedback would be very valuable. Thanks a lot for Denis' testing and insight review from Suzuki! Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel