From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6BBC2B9F4 for ; Mon, 14 Jun 2021 14:53:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB88760FE5 for ; Mon, 14 Jun 2021 14:53:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB88760FE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AVRGaaYSllDfFN9GppKv0tC5F0An9PE0Y9UGHYkMPqw=; b=OzTjjqc4NLF4c/ Mt+x9ap4S0sDCaaRhUs/wDKk39eVZIxbuYReCDJsGtcpSQCaqg1NpqzaFOmqiVAKwWjkRAnPuiHaK rHK5uYG8SIvE+3BRlKtBLXnjU3LgJ0rX2qUF29HvisZOe4QWdxwbRCu9BnZ3AImlCGMQlXLm7E1PT vwDSTZ/PGHZK/dRfA9TkivRK5I4AYQfpBMgXtL1F9d8aAr8frdeL2V0E4PgPgE/Q4vvBAHjKPEES/ rBw45LZi/obUx40sRLUVSzQJ4CKUXq9clUwQPRicUHUDnTux96GoXU1RcOT3I7DklACFA5TlRPYBb 8EA/QzSyF1WtDjV32Xeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnwG-00Ec5H-3Y; Mon, 14 Jun 2021 14:51:45 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnw9-00Ec38-Bz for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 14:51:39 +0000 Received: by mail-ed1-x52b.google.com with SMTP id dj8so46873432edb.6 for ; Mon, 14 Jun 2021 07:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iPS/AZ5OVoA17Ep2xDFclnfOIRqkv3Pi1b98SldC/nc=; b=Pgr6MjSK54xlCpS0V58dbIdvJLsSQi+8s+UK24Rah/l48O4cX4Xahlo3bWMXZBgDFW ht3GbcZ3Oetq6O8MnXEUdgUHLQY3QbVWEVRMh+R4Q+iFa2fwSUU+svZj8FWg8S7HUPU4 o5T+RHhw3q7PYNBcxVHW5WOr1dL7G/OsXLNZZbII42h9k190QI2uY2TaHxWLAbINBaGX uRcdk0bTyrXcY171uA5q98Pn5S1w5Fn59SiUrY8x8Pzrd7+gUX3MCt0NXhDyxy08lJFa QW/k92iWisJVfaKnoY9SkCE0+Q7B6pkMfI/gzhpGSPMQ4oggD5xRJziEgsU+vnVqAC2B o0tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iPS/AZ5OVoA17Ep2xDFclnfOIRqkv3Pi1b98SldC/nc=; b=nbeoLnmnQB3uwBL3W9PeQwxn4WXR8zQIyi279QP/dgb0/htzZmv7+9tXFXsj7tGb9p 8F3I7OdX/G/oYCqlL6wBnY+nvLgtIepCLCAaR2lOVYwFAutKd3ZBd46TmFH4wDutXkLF FvrnaPibTHhOjbSdPV+S6teDzpECX7XYwZEgO3fVagagSwWbFQ/P5B62b6zVykqoLP5z AuLNkUzxOkdkja9xIbbheN7j4gIkUouLdiy/w5438vEPnbYRlpf7OfG5vqKeQVI5hWgM 3LQewG4hAdaPjmW9L2Qn/wTT1tto0KR6xV8dE71evm6euXKIzr8dtPrk8u82EWaw5qUS hObg== X-Gm-Message-State: AOAM53255hFx3n2KGyd0OKaDEfzq5NIveGmGHZjaAQDlEYp1FhYsapWX JzbpMA02trpetzyZrk2w7VU= X-Google-Smtp-Source: ABdhPJwfKM0u0TkINVJk4m3DvxL3a5aUgoF3SVA1nBk1jtYk2IQ9CWeZo4M/BYdRIYOu6BpxLVM2kQ== X-Received: by 2002:a05:6402:35d1:: with SMTP id z17mr17701920edc.159.1623682291063; Mon, 14 Jun 2021 07:51:31 -0700 (PDT) Received: from skbuf ([188.26.224.68]) by smtp.gmail.com with ESMTPSA id q5sm4929313ejc.117.2021.06.14.07.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 07:51:30 -0700 (PDT) Date: Mon, 14 Jun 2021 17:51:29 +0300 From: Vladimir Oltean To: Shawn Guo Cc: devicetree@vger.kernel.org, Li Yang , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vladimir Oltean Subject: Re: [PATCH] arm64: dts: fix node name for the sysclk Message-ID: <20210614145129.63v2tau6ly6wtqbm@skbuf> References: <20210608112658.4087235-1-olteanv@gmail.com> <20210612075346.GZ29138@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210612075346.GZ29138@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_075137_460200_BCB1FB6B X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, On Sat, Jun 12, 2021 at 03:53:47PM +0800, Shawn Guo wrote: > On Tue, Jun 08, 2021 at 02:26:58PM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > U-Boot attempts to fix up the "clock-frequency" property of the "/sysclk" node: > > https://elixir.bootlin.com/u-boot/v2021.04/source/arch/arm/cpu/armv8/fsl-layerscape/fdt.c#L512 > > > > but fails to do so: > > > > ## Booting kernel from Legacy Image at a1000000 ... > > Image Name: > > Created: 2021-06-08 10:31:38 UTC > > Image Type: AArch64 Linux Kernel Image (gzip compressed) > > Data Size: 15431370 Bytes = 14.7 MiB > > Load Address: 80080000 > > Entry Point: 80080000 > > Verifying Checksum ... OK > > ## Flattened Device Tree blob at a0000000 > > Booting using the fdt blob at 0xa0000000 > > Uncompressing Kernel Image > > Loading Device Tree to 00000000fbb19000, end 00000000fbb22717 ... OK > > Unable to update property /sysclk:clock-frequency, err=FDT_ERR_NOTFOUND > > > > Starting kernel ... > > > > All Layerscape SoCs except LS1028A use "sysclk" as the node name, and > > not "clock-sysclk". So change the node name of LS1028A accordingly. > > Wouldn't it more flexible to use alias/label for finding the node? > Using node name/path looks fragile. Thank you for the advice, I will keep it in mind next time when I design my own bootloader device tree fixup scheme. However, in this case I did not create it, and implementing your suggestion to find the sysclk node through /aliases would require changes not only to the bootloader, but to the Linux device tree still (and if we're modifying the Linux DT, why not just go with this patch). So yes, the existing mechanism is more fragile, but I am not sure if we gain anything by artificially creating an additional dependency in the process. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel