From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD51AC2B9F4 for ; Mon, 14 Jun 2021 15:05:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8512A61356 for ; Mon, 14 Jun 2021 15:05:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8512A61356 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vyj+iEI2dvvppsa8tv/9/UQyrEdHkpy2eS04AE6zuBs=; b=VxZRHogp/+ZsZa 4DNnEPEIxDS5fH18Z3RD03m605Djoqmzc5PcDfN/bQzyIyz1oGSffZRrFjRuiIFooNQN965CnoRB3 vuecUU8WI2kx7Dm4mhhRm6+WlS+qkfCvy2ybb3h++Y/ei0w2eRh9+oJ5EakOj8LD6AJHe+imN8YuN qpWrM69q6dUvGTCJr8I/0H2VK2HuKe7MylmiJ2XHOwV38xRPtyabggpmFbtZbKclvT1pV+j9vz6df 3LmHp5uIGnaX5j8s9ahU8we0M+Sdyj1Ns05cVT9bIw/r5Sx8E80TaW+FQwKtdiyeU/N9jQ/TAJ8sv YyE7hUbluMziF/ftsoqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lso7y-00Eehk-CH; Mon, 14 Jun 2021 15:03:50 +0000 Received: from mail-il1-f174.google.com ([209.85.166.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lso7u-00Eegk-G1 for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 15:03:48 +0000 Received: by mail-il1-f174.google.com with SMTP id i12so3072572ila.13 for ; Mon, 14 Jun 2021 08:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ORcJk31TiVnuEogk3RJcUiauMJCVCh/REeNy+uWJyuI=; b=YxrdkMRGjcbaY7f/EDx9k1eeswH9fNDcnK7+Hg8zCZe8jF8HkcRwWFvQRMV+IXoO1w zjoERfhABRzWAoPZcVN6MwxWWFek8icMmhh3+vTa1lAC+GJZj++X1lMQXGL2bUL3h2zM 1kAE7x2vhG/Db+uzLR499SntjBbJb5LPgYCchVgobVLYRu4ghlG+XutD8UdRmfvGhZSN m/Ty+M+U6lBO2pZqxOwxGLyGvndlky9QbpaPBFrCt9/0kebbklU3HLR3Cu43yv1Vo+9w xjQL8awqUPciMWmSaPpEUdc19dbKriGLN2aoSOeshCBYd71KKSFa57kmfgXzoVQhKpBB G0Xg== X-Gm-Message-State: AOAM532aMyF/D9nZkauWYg7Lt7EFXeukrT1gxoVJ6eEavOAZciIiqUHF CzcsP8jX3bvn33LC4I/AmA== X-Google-Smtp-Source: ABdhPJxevxIhIoghxuFi1Czoup2tc4Tf11I/KvnTMIECwiSsVK/e/doraZRmwywMjpT9+SnmMWGoQw== X-Received: by 2002:a92:190f:: with SMTP id 15mr13571076ilz.45.1623683023926; Mon, 14 Jun 2021 08:03:43 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i13sm7633657ilr.16.2021.06.14.08.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 08:03:42 -0700 (PDT) Received: (nullmailer pid 758861 invoked by uid 1000); Mon, 14 Jun 2021 15:03:41 -0000 Date: Mon, 14 Jun 2021 09:03:41 -0600 From: Rob Herring To: Nobuhiro Iwamatsu Cc: gregkh@linuxfoundation.org, michal.simek@xilinx.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, shubhrajyoti.datta@xilinx.com, navam@xilinx.com, peter.crosthwaite@xilinx.com, soren.brinkmann@xilinx.com Subject: Re: [PATCH] dt-bindings: serial: convert Cadence UART bindings to YAML Message-ID: <20210614150341.GA747048@robh.at.kernel.org> References: <20210613213359.296400-1-iwamatsu@nigauri.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210613213359.296400-1-iwamatsu@nigauri.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_080346_562148_9675FD00 X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 06:33:59AM +0900, Nobuhiro Iwamatsu wrote: > Convert serial for Cadence UART bindings documentation to YAML. > > Signed-off-by: Nobuhiro Iwamatsu > --- > .../devicetree/bindings/serial/cdns,uart.txt | 27 -------- > .../devicetree/bindings/serial/cdns,uart.yaml | 68 +++++++++++++++++++ > 2 files changed, 68 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/serial/cdns,uart.txt > create mode 100644 Documentation/devicetree/bindings/serial/cdns,uart.yaml > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt > deleted file mode 100644 > index 4efc560f90abbd..00000000000000 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt > +++ /dev/null > @@ -1,27 +0,0 @@ > -Binding for Cadence UART Controller > - > -Required properties: > -- compatible : > - Use "xlnx,xuartps","cdns,uart-r1p8" for Zynq-7xxx SoC. > - Use "xlnx,zynqmp-uart","cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC. > -- reg: Should contain UART controller registers location and length. > -- interrupts: Should contain UART controller interrupts. > -- clocks: Must contain phandles to the UART clocks > - See ../clocks/clock-bindings.txt for details. > -- clock-names: Tuple to identify input clocks, must contain "uart_clk" and "pclk" > - See ../clocks/clock-bindings.txt for details. > - > - > -Optional properties: > -- cts-override : Override the CTS modem status signal. This signal will > - always be reported as active instead of being obtained from the modem status > - register. Define this if your serial port does not use this pin > - > -Example: > - uart@e0000000 { > - compatible = "cdns,uart-r1p8"; > - clocks = <&clkc 23>, <&clkc 40>; > - clock-names = "uart_clk", "pclk"; > - reg = <0xE0000000 0x1000>; > - interrupts = <0 27 4>; > - }; > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > new file mode 100644 > index 00000000000000..ce467fa464bfd0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/serial/cdns,uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence UART Controller Device Tree Bindings > + > +maintainers: > + - Michal Simek > + > +allOf: > + - $ref: /schemas/serial.yaml# > + > +properties: > + compatible: > + oneOf: > + - description: UART controller for Zynq-7xxx SoC > + items: > + - enum: > + - xlnx,xuartps > + - cdns,uart-r1p8 What you want is: items: - const: xlnx,xuartps - const: cdns,uart-r1p8 > + - description: UART controller for Zynq Ultrascale+ MPSoC > + items: > + - enum: > + - xlnx,zynqmp-uart > + - cdns,uart-r1p12 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: uart_clk > + - const: pclk > + > + cts-override: > + description: | > + Override the CTS modem status signal. This signal will > + always be reported as active instead of being obtained > + from the modem status register. Define this if your serial > + port does not use this pin. > + type: boolean > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false unevaluatedProperties: false because you could have child nodes with attached devices. > + > +examples: > + - | > + serial@e0000000 { > + compatible = "cdns,uart-r1p8"; This is wrong based on what the binding said. > + clocks = <&clkc 23>, <&clkc 40>; > + clock-names = "uart_clk", "pclk"; > + reg = <0xE0000000 0x1000>; > + interrupts = <0 27 4>; > + }; > -- > 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel