From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>,
Evgenii Stepanov <eugenis@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm64: mte: allow async MTE to be upgraded to sync on a per-CPU basis
Date: Mon, 14 Jun 2021 19:04:58 +0100 [thread overview]
Message-ID: <20210614180457.GK30667@arm.com> (raw)
In-Reply-To: <20210611215101.1060663-1-pcc@google.com>
On Fri, Jun 11, 2021 at 02:51:01PM -0700, Peter Collingbourne wrote:
> +static ssize_t mte_upgrade_async_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + ssize_t ret;
> + u32 val;
> + u64 tcf;
> +
> + ret = kstrtou32(buf, 0, &val);
> + if (ret < 0)
> + return ret;
> +
> + tcf = ((u64)val) << SCTLR_EL1_TCF0_SHIFT;
> + if (tcf != SCTLR_EL1_TCF0_NONE && tcf != SCTLR_EL1_TCF0_SYNC &&
> + tcf != SCTLR_EL1_TCF0_ASYNC)
> + return -EINVAL;
> +
> + device_lock(dev);
> + per_cpu(mte_upgrade_async, dev->id) = tcf;
> +
> + if (cpu_online(dev->id))
> + ret = smp_call_function_single(dev->id, sync_sctlr, NULL, 0);
Forgot about this. I get it now, you only need to kick the CPU that is
getting changed. This looks fine.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-14 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 21:51 [PATCH v3] arm64: mte: allow async MTE to be upgraded to sync on a per-CPU basis Peter Collingbourne
2021-06-14 17:56 ` Catalin Marinas
2021-06-14 18:02 ` Catalin Marinas
2021-06-14 18:20 ` Peter Collingbourne
2021-06-14 18:04 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614180457.GK30667@arm.com \
--to=catalin.marinas@arm.com \
--cc=eugenis@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pcc@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).