From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7D9C2B9F4 for ; Mon, 14 Jun 2021 18:08:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A7061075 for ; Mon, 14 Jun 2021 18:08:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A7061075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8KnCHhZxNAXeo67fcGBwEHUaSxrxO7QrL6wdyPoTJ7Y=; b=Dj13CNrmtQW4uD qOY2ZZBBDsfrJqKZDjpSaCYSGyo1cW2nnFetKpNBXFG2cn96nLhYZ/dfCKKip3QDK7pE6jIOTutV8 2P/HPUP5t+VfSEuVPJrgmmQ3yCVUfb0S83l8bvzgzBorNn1WcnTq9A87UOKyLx7GhP08HvHGcXDbV 1cw7W69D8glKwdTN4GvWQxkvuf0h9LB4EqmW0evtksgizXyOS9DL2j6lS19xyOsYv7sKpAIBgjEGN lJs1619iri2Wo3gnB6cDqntCBKMa/Z2wVr3Dd4kvTrv0RnOGzdUQ9gImOI/V3tEJWMxN9y/c0P1Ak TJAtJiJI3ugU8xy5dQHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsqyX-00FbtV-Gu; Mon, 14 Jun 2021 18:06:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsqxL-00FbS4-35 for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 18:05:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B845610A3; Mon, 14 Jun 2021 18:05:01 +0000 (UTC) Date: Mon, 14 Jun 2021 19:04:58 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Vincenzo Frascino , Will Deacon , Evgenii Stepanov , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] arm64: mte: allow async MTE to be upgraded to sync on a per-CPU basis Message-ID: <20210614180457.GK30667@arm.com> References: <20210611215101.1060663-1-pcc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611215101.1060663-1-pcc@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_110503_201399_2FC243C6 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 02:51:01PM -0700, Peter Collingbourne wrote: > +static ssize_t mte_upgrade_async_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + ssize_t ret; > + u32 val; > + u64 tcf; > + > + ret = kstrtou32(buf, 0, &val); > + if (ret < 0) > + return ret; > + > + tcf = ((u64)val) << SCTLR_EL1_TCF0_SHIFT; > + if (tcf != SCTLR_EL1_TCF0_NONE && tcf != SCTLR_EL1_TCF0_SYNC && > + tcf != SCTLR_EL1_TCF0_ASYNC) > + return -EINVAL; > + > + device_lock(dev); > + per_cpu(mte_upgrade_async, dev->id) = tcf; > + > + if (cpu_online(dev->id)) > + ret = smp_call_function_single(dev->id, sync_sctlr, NULL, 0); Forgot about this. I get it now, you only need to kick the CPU that is getting changed. This looks fine. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel