From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B79AC48BE5 for ; Tue, 15 Jun 2021 13:53:46 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 323056105A for ; Tue, 15 Jun 2021 13:53:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 323056105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4EeMDMJSkAPtiC1/lxmbKe0DOXwGYxkMH16zcC06FKI=; b=y6s22iAcZtHpdJ jKPMaEGPk5YsyexWn6f1sGNPBHOt0rKtv1CDRo0++Gn16m5A3bWDrmtopGHHhbNgqJNIcBQdTiKmN OtM4S2BH0CmV6BAh4pvK6qtbRv6WVa1Eq+RT1xdXMgXthPSY8kK8LWfa5F+RCZvOTqzDR604YDiiL DvZvDGaa0MUBxZoLpt9aQphIM5UvID2Zex+pMDUvhAzQnbxgZfXqsUASjijlejMjPFDJVBJ0pEVOY ae0/R6WMCX5kLPl4l6CpQOsPIuw85a7zEfJjr0vjfX4nHb+DLbkDh6vZpEvrBD6w9+t2+IBtjTItG BsmpZUvr000f1yQJN2Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9Oc-000IAd-10; Tue, 15 Jun 2021 13:46:27 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9FZ-000DEY-6z for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:37:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=epcVeaXntTNBXbO/CE89ENmOkYuu6dNpJ39/vdWtBBg=; b=lW7O45wHLUC+8uYFW3QUWGmI1r ErjGikfc8s0JUZbhB5NayxUw4sm690o+eYfvqMN7xDX6k1wKm0uwZLkVaWMI4dLYOWMZ/vEJTxum4 FOZEJZLINdDd36DqfQqpe7Bu/ejZrwbYMgCLw9kjY2FeyUMR+XF7HKD01MikShrwNn+jrUrp6SIxf 3PR5/+EUYXkkmbp8a0MGwVzwnl6BNoE2BUOfyp45szkDda8lA/yWnZ/XPem1IzqtRW8nfXyL3NUxm E2I3JntbYY2WVNyUG/VmOrD67+pVAzgKae6XyN7akniybbYtaEz0ajl9jTvDUjpoeuDTrJx+zOn/r CPh+Gf0A==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt7Ki-007mPq-N1 for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 11:34:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52A0D61107; Tue, 15 Jun 2021 11:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623756862; bh=RLHnzoMTdyqvCPaFePwEAEn92hiuYy3UYx98zf4AdoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5PyJbAK2WD+yuDAzIb+yjT96WoSAR1Uxus4MT4grKrVnNBA06aWZBC7OLRZi7V2o oXIp8eCXgQ6B0uGQkLFAgN7Az44gTOODemxM0ak9pGoBzrQdXUf/wBTOE8XAdOokhh fIuOOt6OUOzGxKoCjUUsKarSSniY2zOzrvHlpcm/xE9xrmHGXplcq0WNTfEFLPKh5s BznHMsjzvGrwwAh6ygZ0HY5WVYowVDi1pBGKs3elTmqOJOaArvNnDNNyPW+6fxxC1d AciXvwdQqKuO811GyZN7N4blOiUHrfTyh9JLmNQo/4ZMbWzS+hRSVUNjsNkJiI70hE 0niD87Ra91Iew== Date: Tue, 15 Jun 2021 12:34:17 +0100 From: Will Deacon To: "Leizhen (ThunderTown)" Cc: Robin Murphy , linux-arm-kernel , Joerg Roedel , iommu Subject: Re: [PATCH 1/1] iommu/arm-smmu-v3: remove unnecessary oom message Message-ID: <20210615113417.GA20598@willie-the-truck> References: <20210609125438.14369-1-thunder.leizhen@huawei.com> <20210611103220.GB15274@willie-the-truck> <2a0b7f37-156a-775f-ade4-015cade472c6@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a0b7f37-156a-775f-ade4-015cade472c6@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_123423_723869_ADC3B6C0 X-CRM114-Status: GOOD ( 24.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 07:22:10PM +0800, Leizhen (ThunderTown) wrote: > > > On 2021/6/11 18:32, Will Deacon wrote: > > On Wed, Jun 09, 2021 at 08:54:38PM +0800, Zhen Lei wrote: > >> Fixes scripts/checkpatch.pl warning: > >> WARNING: Possible unnecessary 'out of memory' message > >> > >> Remove it can help us save a bit of memory. > >> > >> Signed-off-by: Zhen Lei > >> --- > >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 8 ++------ > >> 1 file changed, 2 insertions(+), 6 deletions(-) > >> > >> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > >> index 2ddc3cd5a7d1..fd7c55b44881 100644 > >> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > >> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > >> @@ -2787,10 +2787,8 @@ static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) > >> void *strtab = smmu->strtab_cfg.strtab; > >> > >> cfg->l1_desc = devm_kzalloc(smmu->dev, size, GFP_KERNEL); > >> - if (!cfg->l1_desc) { > >> - dev_err(smmu->dev, "failed to allocate l1 stream table desc\n"); > >> + if (!cfg->l1_desc) > > > > What error do you get if devm_kzalloc() fails? I'd like to make sure it's > > easy to track down _which_ allocation failed in that case -- does it give > > you a line number, for example? > > When devm_kzalloc() fails, the OOM information is printed. No line number information, but the > size(order) and call stack is printed. It doesn't matter which allocation failed, the failure > is caused by insufficient system memory rather than the fault of the SMMU driver. Therefore, > the current printing is not helpful for locating the problem of insufficient memory. After all, > when memory allocation fails, the SMMU driver cannot work at a lower specification. I don't entirely agree. Another reason for the failure is because the driver might be asking for a huge (or negative) allocation, in which case it might be instructive to have a look at the actual caller, particularly if the size is derived from hardware or firmware properties. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel