From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A64C48BDF for ; Tue, 15 Jun 2021 19:55:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA48461185 for ; Tue, 15 Jun 2021 19:55:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA48461185 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fFVWRd38bCVPCTFRC5Pm5Me2MXdUchtOSDxP85ovFX8=; b=ZSONVwnbfNNY+2 3nz8cyccJ/A5eJflYqOsGHefyR3a2NXQNPMGEgTa/VjbCK6KiREGLym75I06F01mf153Gwt8TZXja UmuWCOAaWtmcStghOqIuaVtjqbdyxHqOZvp7eZzQs7lUyR+H7XMGrALwzcg4k17szH6fdPaur7qr9 CyTB7pDdgmSIZmabIldeGmkzDiPFc983SlpKQEwVFJ6r7LZww1ZK8AyohXDNCgM4GeuHhJcM/5U4g Xx6CzSjcA8CcechNT54TIMUp5tFwvm4ASh92tTu7+2mP4xqr0G/nggx2MR/5x45fS740w3YUkFBNS SxXQciHBaj8TyFdqIgeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltF7V-002b2V-SW; Tue, 15 Jun 2021 19:53:10 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltBD9-0013YL-Tn; Tue, 15 Jun 2021 15:42:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=3yEoT072I6MOxjNG7YT4qxHaaxCVzQrNLMVgWw47rQ0=; b=fmMWlKx648f7R93oqI2HPgoP/L gVhnTqcXtoTW27ZtpAbOaZIOF0BeSEt6ou0mFeJPOyrk92bpWcc0CQqDlxbtcTlIYZjJibAgV0tCb 9YWr16G+oImN0G0y7G4PKZxH/PrJWh3d3w4Zaq0KVyAufLz+vsEIhwdB7TSgJb2SqZu6wAltQBJds hIIXixhQJXcXduKNMpXZecpx+ZwRXCgTKnhJmd/R8bWcjuDZlfTkMX63E70sGqdfahqGm/huTX5KI YXfE58G7CMdvFBtDSHXXFm3SwS4YYG0f83hq2H+oIE676umF9/IAxeNIiAVObfhyXJcd3tw7XenRn 2dvNOvHA==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltBCz-0081KZ-G6; Tue, 15 Jun 2021 15:42:42 +0000 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1D766145C; Tue, 15 Jun 2021 15:42:30 +0000 (UTC) Date: Tue, 15 Jun 2021 11:42:29 -0400 From: Steven Rostedt To: Mark-PK Tsai Cc: Matthias Brugger , Matt Helsley , Sami Tolvanen , , , , , Subject: Re: [PATCH v2] recordmcount: Correct st_shndx handling Message-ID: <20210615114229.3b1f2c5f@oasis.local.home> In-Reply-To: <20210615064720.21950-1-mark-pk.tsai@mediatek.com> References: <20210615064720.21950-1-mark-pk.tsai@mediatek.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_164240_616796_24964753 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Jun 2021 14:47:20 +0800 Mark-PK Tsai wrote: > One should only use st_shndx when >SHN_UNDEF and SHN_XINDEX, then use .symtab_shndx. Otherwise use 0. > > This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX. > > Reported-by: Mark-PK Tsai > Signed-off-by: Peter Zijlstra (Intel) > Tested-by: Mark-PK Tsai > Signed-off-by: Mark-PK Tsai Please explain the two signed-off-by's above. If you are just tweaking Peter's original patch, please add at the start: From: Peter Zijlstra (Intel) And then just above your signed off by, add what you changed: Tested-by: Mark-PK Tsai [ Changed something ] Signed-off-by: Mark-PK Tsai But state what you changed. Thanks! -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel