From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC90FC48BDF for ; Tue, 15 Jun 2021 20:51:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56CF7610EA for ; Tue, 15 Jun 2021 20:51:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56CF7610EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FKcTwK+Uc1VavduT2agrJGrEVyn/z6yMEoDQ6TII/zo=; b=cI4Ug4hPmLYQ6G Xz/wuwp6HtYcLxE55B5vsD19LwoLgq0YN8oYOU2dobyVF8xLYp4G0aECnuxFSsYWMRQYK16brB4CU DSb8NX0wz5x2KzzlP8qLzsMohjQNaH8vynnjVWNXHWmKkftB8e4Vn2M0QL7YBnnlC0y5Ywr3wY+Jd o0IWr+7Y1D4cpjRjZV2c/nbb0Lh7X1ILcarImolOKNwKlKYdUCPMF6CYlefzwkB+llDVNjKiSRmva urroDOi3CVJge1I8Ee8RMVM6lNggO7Eb8+3qEiqLf38r6lkXdOWfEQdziHoU8ouwd82Tj5c4kCpMw phwHd3mlbQmw3q/SxWqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFzb-002uJ8-Sc; Tue, 15 Jun 2021 20:49:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltCWn-001axD-Tw; Tue, 15 Jun 2021 17:07:08 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E05B6143D; Tue, 15 Jun 2021 17:07:04 +0000 (UTC) Date: Tue, 15 Jun 2021 13:07:02 -0400 From: Steven Rostedt To: Mark-PK Tsai Cc: , , , , , , , Subject: Re: [PATCH v2] recordmcount: Correct st_shndx handling Message-ID: <20210615130702.0292284e@gandalf.local.home> In-Reply-To: <20210615163245.26164-1-mark-pk.tsai@mediatek.com> References: <20210615114229.3b1f2c5f@oasis.local.home> <20210615163245.26164-1-mark-pk.tsai@mediatek.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_100706_090458_5EF5AA15 X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 16 Jun 2021 00:32:45 +0800 Mark-PK Tsai wrote: > > On Tue, 15 Jun 2021 14:47:20 +0800 > > Mark-PK Tsai wrote: > > > > > One should only use st_shndx when >SHN_UNDEF and > > SHN_XINDEX, then use .symtab_shndx. Otherwise use 0. > > > > > > This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX. > > > > > > Reported-by: Mark-PK Tsai > > > Signed-off-by: Peter Zijlstra (Intel) > > > Tested-by: Mark-PK Tsai > > > Signed-off-by: Mark-PK Tsai > > > > Please explain the two signed-off-by's above. If you are just tweaking > > Peter's original patch, please add at the start: > > > > From: Peter Zijlstra (Intel) > > > > And then just above your signed off by, add what you changed: > > > > Tested-by: Mark-PK Tsai > > [ Changed something ] > > Signed-off-by: Mark-PK Tsai > > > > But state what you changed. > > > > Thanks! > > > > -- Steve > > Sorry for messing up. No problem. It's a learning process. > I've fixed it in v3. Thanks, -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel